From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15863A04FD; Fri, 8 Apr 2022 18:48:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABE414067E; Fri, 8 Apr 2022 18:48:31 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 49C4F4003F for ; Fri, 8 Apr 2022 18:48:31 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 16DA0CC5 for ; Fri, 8 Apr 2022 18:48:31 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 157A2F43; Fri, 8 Apr 2022 18:48:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=ALL_TRUSTED, AWL, NICE_REPLY_A, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.6 X-Spam-Score: -3.7 Received: from [192.168.1.59] (unknown [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 66066119B; Fri, 8 Apr 2022 18:48:28 +0200 (CEST) Message-ID: Date: Fri, 8 Apr 2022 18:48:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4] eal: add seqlock Content-Language: en-US To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , dev@dpdk.org Cc: Thomas Monjalon , David Marchand , onar.olsen@ericsson.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, konstantin.ananyev@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, Ola Liljedahl References: <20220408142442.157192-1-mattias.ronnblom@ericsson.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= In-Reply-To: <20220408142442.157192-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022-04-08 16:24, Mattias Rönnblom wrote: > > PATCH v4: > * Reverted to Linux kernel style naming on the read side. In this version I chose to adhere to kernel naming on the read side, but keep the write_lock()/unlock() on the write side. I think those names communicate better what the functions do, but Stephen's comment about keeping naming and semantics close to the Linux kernel APIs is very much relevant, also for the write functions. I don't really have an opinion if we keep these names, or if we change to rte_seqlock_write_begin()/end(). You might ask yourself which of the two naming options make most sense in the light that we might extend the proposed seqlock API with an "unlocked" (non-writer-serializing) seqlock variant, or variants with other types of lock, in the future. What function writer-side names would be suitable for such. (I don't know, but it seemed something that might be useful to consider.)