From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB78FA034F; Fri, 10 Sep 2021 10:07:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95F0F406B4; Fri, 10 Sep 2021 10:07:14 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 78CA74067E for ; Fri, 10 Sep 2021 10:07:13 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E833C7F56B; Fri, 10 Sep 2021 11:07:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E833C7F56B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631261233; bh=52oY9+k+3IZRgpaRWcKIVa7xIpY06HCL4Tkq2TKxjpY=; h=Subject:To:References:From:Date:In-Reply-To; b=HFPwb1uTxgq+JCCRCe4Xhuo1NXxCHdiRnwEeIFlbRaIFwb6QKv5QrfqD/y0+AkeWA 7MjWI1INIsa8VuoaRpy3dDaMmwkKAagK0XqKKDvFdQh/94uj0qmtWD1y4oAP3KLUy/ uEZgmjrPY/NLO77lCs6sO0anahC517aLrf91PPUg= To: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org References: <20210830104232.598703-1-thomas@monjalon.net> <45c1e73c-bb60-c5a4-c4f0-7971b4066c03@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 10 Sep 2021 11:07:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <45c1e73c-bb60-c5a4-c4f0-7971b4066c03@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/21 8:02 PM, Ferruh Yigit wrote: > On 8/30/2021 11:42 AM, Thomas Monjalon wrote: >> A lot of flags are parts of a group but are documented alone. >> The Doxygen syntax @{ and @} for grouping is used >> to make flags appear together and have a common description. >> >> Some Rx/Tx offload flags and RSS definitions are not grouped >> because they need to be all properly documented first. >> >> Signed-off-by: Thomas Monjalon >> --- >> lib/ethdev/rte_ethdev.h | 71 ++++++++++++++++++++++++++++------------- >> 1 file changed, 48 insertions(+), 23 deletions(-) >> >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> index d2b27c351f..0924c9fc68 100644 >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_ethdev.h >> @@ -276,7 +276,7 @@ struct rte_eth_stats { >> /**< Total number of queue packets received that are dropped. */ >> }; >> >> -/** >> +/**@{@name Link speed capabilities >> * Device supported speeds bitmap flags >> */ >> #define ETH_LINK_SPEED_AUTONEG (0 << 0) /**< Autonegotiate (all speeds) */ >> @@ -296,8 +296,9 @@ struct rte_eth_stats { >> #define ETH_LINK_SPEED_56G (1 << 13) /**< 56 Gbps */ >> #define ETH_LINK_SPEED_100G (1 << 14) /**< 100 Gbps */ >> #define ETH_LINK_SPEED_200G (1 << 15) /**< 200 Gbps */ >> +/**@}*/ > +1 to use Doxygen grouping, and changes looks good to me. +1