From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 57356106A
for <dev@dpdk.org>; Tue, 6 Dec 2016 20:48:53 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga105.fm.intel.com with ESMTP; 06 Dec 2016 11:48:52 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="1078334873"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
([10.237.220.29])
by fmsmga001.fm.intel.com with ESMTP; 06 Dec 2016 11:48:51 -0800
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
<1480875447-23680-10-git-send-email-hemant.agrawal@nxp.com>
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com,
shreyansh.jain@nxp.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <dcc47c4e-7388-bd61-2d67-0376270e8693@intel.com>
Date: Tue, 6 Dec 2016 19:48:50 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1480875447-23680-10-git-send-email-hemant.agrawal@nxp.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 09/32] lib/ether: add rte_device in
rte_eth_dev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2016 19:48:53 -0000
On 12/4/2016 6:17 PM, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> lib/librte_ether/rte_ethdev.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 3c45a1f..6f5673f 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -1626,6 +1626,7 @@ struct rte_eth_dev {
> eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */
> eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. */
> struct rte_eth_dev_data *data; /**< Pointer to device data */
> + struct rte_device *device;
I believe this change should not be part of a PMD patchset. This change
is more generic than the PMD.
Won't Shreyansh's patch already do this?
> const struct eth_driver *driver;/**< Driver for this device */
> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */
> struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */
>