From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C73A034C; Tue, 18 Jan 2022 17:18:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0821742731; Tue, 18 Jan 2022 17:18:34 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 3599F4068E for ; Tue, 18 Jan 2022 17:18:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642522712; x=1674058712; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=bUvbLs7gP7zw+3QO9Pmwd5PlaaI7hSMhyk/AdADLTeE=; b=fF+x60OXWSoAkQt92Gi+ugZ0zigsUl//4yblaB7HyIpEWnzLdGpghMER tfb+09Gbw4Iswj+L/US5Hb5ZNH8ksKQNCK1kuF3FKbFAoZDO+0IHUvr2F kuKXeAifPEZR1jVv2yMyNzO2vBKelUv+idp/VlLMXKN2pBKVZabWkQtKO KslTJBR2uOPDcOBhKDzxJICib9ZhINjUDwi3sq7VHsqBHKa1BaarJ2C7F raOB8ucyIi4Su4AgLUnKpfvqpSnPoiweza3EE1ddDsPoz7N8jjToP+X9N B3e6lgqkxdpJszIzS7za1x390A7pQRNIDfhmrRMGGZYbvKdYRksgIKony w==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="305586154" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="305586154" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 08:17:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="492714190" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 18 Jan 2022 08:17:18 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 08:17:18 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 08:17:18 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 08:17:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D7M4XiZ4R08CitdTUQL9ioErYBf/rIHncoL7D1IxPASosP2zZ05LviLmZwpg0kFZTKlhfLgYnzsCb3ROmoLYZJq6a39WbKnDC5Ysl6hRkahclxQqJX0Fd1adyuHfYUiDXYRBgCyLCaX24fM/iqwsIqe7R1Z7W3yIn01RETmbn4uZnxCYbve7eOfd1tXCqw4Vgd/I+Gsb8DYjcxkga72I6dABaxMCar3rVN2FBGAqrmhNL24jN8rribRkBL8A3m9a51E4MiHQGhtfvYw0+wmBVzQbJbj23gP6T6QcclsFxHDBJrXeyjG3aAg98smnV10Pr+gsZhAafJD9RFUCTlrG0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1gWGR7U7N1xZDiyChldMr3YSRc5QoVf5As6OAh7lcP8=; b=gucGRQZdXkGBBMMK25fcvfuqUd7Zd0Rc6VymLzvTkS3owOK94wvIpYp5/nm7UOpJL1r4v7WhWEVGnsczjKhBUClgN/B5DjEQMXPPPQiNz7ByZd9KjoBsQxUqi+67gUmGaIJgARbYsCTlW08pX7pVUahmDmws9uhdw3rPERjep9RNLiWbstBb7fjm244KzlxPAv1X9mP1emevGouwSR8w/ByTJkoF2kHsmyzYNjFh7rZ9rD7cmPSPZs6RgIhNfCMFhJHeUN0gPGOJnhm1cGaXVEmEtJcibwT4Nd72256qtO4xDPOJoq0h6MHHaDsm29/8jPDhNQXd1roe/tmv7FOlmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB1650.namprd11.prod.outlook.com (2603:10b6:405:11::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Tue, 18 Jan 2022 16:17:16 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 16:17:16 +0000 Message-ID: Date: Tue, 18 Jan 2022 16:17:09 +0000 Content-Language: en-US To: Yunjian Wang , CC: , , , , , Anatoly Burakov References: From: Ferruh Yigit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: log the largest free block when dumping socket memory X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0007.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52aa3c6f-f4c1-4904-f4bd-08d9da9dfe25 X-MS-TrafficTypeDiagnostic: BN6PR11MB1650:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B97y76opbBfzv/Hw/OYaqigjaME3whc5EKSS02y4tbA6YGIhRxjCYn4tDyErd+7HiRq1Yrh+KaqRTAFCTZvwyGQHAnoZQlfpj0NrcFXarR0y63I/k4zxvAFN/8MV+uIHNBNNT+8bh/nWYJSe0ndr2t84XqgX0P9VAkz3tS3Pi/inz9DIlFzTdSbCYYmsx1Z9EU0ENXViFHycHwoSCmmO/jA3E6qNYwt3EUhcc5jEba0iOFZ6ZZcbLnAM3nGLWkh84iUmP/v3EGfcIcZJYwILCoMcbPFPvh2jMIf3ruoCdBIiXycVrHR5r1ZnM4Q8ZA7QsB697/1GcsKVuNgSpb9uL8o0cEoUeqKP3mNjuc0eiG3yvFlj8vduqzs+n5Q8rbmFSajTiATb598ml8HFA38LHlgc5JM+Z+K8QlXxbtCYda+U50/0Ip36eDMiI8CYxsnQHbsqo1o9T14NS1LCBXLM3CAnysjKUHqnehA8sS3Wc447153Iv198uEz5T3frFMz/aiRtu6sw1mYmBXDJ3m9+cH4u3/Jt3vKT61SGiDg2lxZT3jHJ2KPrsFwO2d6V/SIlz+kExuIHv6L54IHmdNBfmVQ6e5VmXDSj5hWW6OPV0olq56VubrhuTYFx2m9VlFfOdpq5AiMn3bycpaD6csMGzzNVK/Ferp+vFTr+14MkMJK66JMbtBdppRDzYJhQ7weFvela11stpJtKBrEqgjSGmA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(4326008)(6506007)(2906002)(66946007)(107886003)(38100700002)(82960400001)(66476007)(53546011)(83380400001)(26005)(186003)(5660300002)(31686004)(66556008)(508600001)(86362001)(31696002)(6512007)(2616005)(8936002)(8676002)(6666004)(316002)(44832011)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEljRElJM0NFdFlwaDc5UTlvOUR0RnFrZU5uOGFCWEFWc0VYSm4rNldxTHIw?= =?utf-8?B?RzA3YkhIMmlESHM3NmxOeEdXc1hqelBlR0xtNElVRDdIc1ZqMmp1bjV0dkRF?= =?utf-8?B?ZEk1Y1RwWmtWcHlZMmluSGhHTXFTUnl5N3hkVklxc0M5UDRZbFVUcWRYa1VE?= =?utf-8?B?VU9keTI2Y2s2dXNnOFd6aktCeXRCMExwUzV3Smp6Y3R4ZFB3ZzhrSDhPd0Yx?= =?utf-8?B?eDRRaHExMEYvSEhjbXV2OGczVWN0MFlXcm5ublM3OXFnalFJV0lHbHBiKzVo?= =?utf-8?B?Y0pKd1kzOXZJRng1c3dhcnJETC9Kait3dlZOSGVWRDE2d1hBVU15elNpcHBk?= =?utf-8?B?N3NFSTJtNUc1NWxTZkVBYWlCZnJXLzJFSTJDRG9ONWZMZW1SSnNTTHl6djRF?= =?utf-8?B?Zk1jaitBUSsyNjlTSHVxNzY1Uy9BNVFPU1FxZEdMVXBjUVJRUzAxTElmL0xa?= =?utf-8?B?Zi95V2thZFZ4QjNtOEtHSDNZbXM4Y2hZeStYSDErVTE5dzNralF5d0RNeit1?= =?utf-8?B?aDFLT0trY2dyRGlJUnFwc000a3FtemQxaTNaNUNsZTgra0ZtRUx1N1VWeTlC?= =?utf-8?B?SFJxb1kzcEhzVUlGcW8wSXlCdTFFMVFxWjM2MXhBM0sybXI1aGlEMDl0ZTNR?= =?utf-8?B?bVl0M2xXbnY2RjhURWtEcktXQnVmMXJCYy84ZDY3dmZRLzFtRENUZWs5TUhD?= =?utf-8?B?ejlEb1JNNHdpVXpZcFNxeUtVT0lTRGUvT2RmUy8wQXNERTV2d1RUSGxWOXRH?= =?utf-8?B?bVZUV0ppcVRNaVVtWnpsc2R5dGE5MkQ1UFNSMTY3SVpzN2phNklMYXZjUnZL?= =?utf-8?B?RnFXRWtZdjlqS2huK0NGRElPT1VrTnUvV1NrV2lsZ2pxWkVCVjE4WkIxY3NK?= =?utf-8?B?NDFCanROaUVrQS9uQ0UrRXZFZE8xc2dGWGY3SjFiZXNNYitkN2FqWGRLKzNo?= =?utf-8?B?OFpYV1B1QnUzNTVSMjFDUys0TlFoOG9HOVE3d0s5REd6RVF2NmF1cDB2eTl1?= =?utf-8?B?dXErSTk2d25jWTB2M0I0T2F1Q2tRUmFlVm9HZE4yODBsdE4rRFJ2WXBhQkVl?= =?utf-8?B?QklOT2t3eTdFcG9oTm1lS0xMeFFTVi9CUDg2d1V1QnkrNHFZNWJ6cDJVSkRp?= =?utf-8?B?akhhTlU3blJ5YlM3SkN4a01nS0tVRG81S3hEaDVubUk2T2t2dUhXU1RObjRw?= =?utf-8?B?QVVoZ21MMTVIZ3ZGVFFNRmg5KzdWZjA3RlVwMEFXUTJHN3NFeHdkS29FSjk0?= =?utf-8?B?VUpzSTJyVkNUdXR4NjR0N05wSlJac3UzR3gwcTFlZTlIN2ZXeFFjSmQraUFE?= =?utf-8?B?MXZCd1owcW1GQ3FKZWZXRGxUSVdKK0JxZDRnRjZDTmVWK09nNjBBdjB1UUd0?= =?utf-8?B?N0JKMStiWXlvejZERjBwem1zMFVCRHE4RzRxUWUzOUVaak94R3Z6YWV4ckZx?= =?utf-8?B?S2lUOW1QbzIzaWdhVk1XcHdOMjYxeUlRemU4MFRqang1SGgwWEplZ0FPblhW?= =?utf-8?B?dkFJeVlHMTBmdnNOY2FBMExMeDhGZ2ZpOGdOKzJHVnpzNU8rVVNXaEFiV05B?= =?utf-8?B?eUdEK25CNXg3YVRxTzZETjF0VzhxNHd3MUJOcEpQZ2dQaFBZWWVzYkFZYmFY?= =?utf-8?B?RzFzbTlBaW9SYVRqRkpiZUtBVmVEZmowY0FVQ1lsdVBvQTdQZlJTOW44djVu?= =?utf-8?B?T255UWVOQmUvNmpzbE1zL2JYeUVJcU5YZlZvUmJldFBqRk1nM2QrTmxtSEpB?= =?utf-8?B?R0lxSDVMbFhZdnJ5V3VQRXdZbzlDWkpCdFhHU1E2U0EyMU4vZXlLNHlWczh1?= =?utf-8?B?Q25RUDBDaytPUW1VOVhvckgrcmNPZDVCaFV3U0J2OWN1ZEZkYUxtVFEvV01X?= =?utf-8?B?dFBzYzMweWMxZlVFYjg3M3RNaEx1WkExVUJwN24yTkpUK1pWTFJaQTd5bGdw?= =?utf-8?B?R3RMelF4MkdyT1FlcEEyYlVUdUJoWllSM2dUR3g3SHFoN1lOaEFiUUVFMlRa?= =?utf-8?B?Ylc0SEdBSDZtWjg2R05Ka3N0T0hPSFp6TDUweG1LRjEzaGFlRU5sZ1NaaTF0?= =?utf-8?B?S09XRG1Ud2E1SlErbE5sQVBiT0VJM2tVZmxjWi96Rml0SWQrKzN3d2lML0w1?= =?utf-8?B?Yk1ITGRwZ20zMkNOK3FpbE93SnkyV1lPZHgzMEJXcGRlMXc0d082bDB5dFVL?= =?utf-8?Q?xaE0bxsUNYQqIBTXu2grZ7s=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 52aa3c6f-f4c1-4904-f4bd-08d9da9dfe25 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 16:17:16.1068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0uDsWnt8mMMVAiQlmJOCBlsTWXDC7gLHTb9zXPVd1sWZhXIbyI3czFe6l/AhVwoCZBvmiDlsi4LeR8ZUKS6mfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1650 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/27/2021 10:49 AM, Yunjian Wang wrote: > Add log print of the largest free block in dump_socket_mem. 1) What do you mean with "largest free block", is largest continuous block? If so is this physically continuous, or vfio continious? 2) Why this value is good for? Why we want to display it? > It is useful to also log when dumping socket memory. > > Signed-off-by: Yunjian Wang > --- > app/test-pmd/cmdline.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 6e10afeedd..d7bddf065a 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -9825,6 +9825,7 @@ dump_socket_mem(FILE *f) > size_t total = 0; > size_t alloc = 0; > size_t free = 0; > + size_t greatest_free_size = 0; > unsigned int n_alloc = 0; > unsigned int n_free = 0; > static size_t last_allocs; > @@ -9840,22 +9841,27 @@ dump_socket_mem(FILE *f) > free += socket_stats.heap_freesz_bytes; > n_alloc += socket_stats.alloc_count; > n_free += socket_stats.free_count; > + greatest_free_size = RTE_MAX(greatest_free_size, socket_stats.greatest_free_size); > fprintf(f, > - "Socket %u: size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf \tcount alloc: %-4u free: %u\n", > + "Socket %u: size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf max: %.6lf \t" > + "count alloc: %-4u free: %u\n", 'max' is not clear what that value is, can you please update it? > i, > (double)socket_stats.heap_totalsz_bytes / (1024 * 1024), > (double)socket_stats.heap_allocsz_bytes / (1024 * 1024), > (double)socket_stats.heap_allocsz_bytes * 100 / > (double)socket_stats.heap_totalsz_bytes, > (double)socket_stats.heap_freesz_bytes / (1024 * 1024), > + (double)socket_stats.greatest_free_size / (1024 * 1024), > socket_stats.alloc_count, > socket_stats.free_count); > } > fprintf(f, > - "Total : size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf \tcount alloc: %-4u free: %u\n", > + "Total : size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf max: %.6lf \t" > + "count alloc: %-4u free: %u\n", > (double)total / (1024 * 1024), (double)alloc / (1024 * 1024), > total ? ((double)alloc * 100 / (double)total) : 0, > (double)free / (1024 * 1024), > + (double)greatest_free_size / (1024 * 1024), This is not displaying the total value, but last value. Need to gather values in loop to be able to display the total value. > n_alloc, n_free); > if (last_allocs) > fprintf(stdout, "Memory total change: %.6lf(M), allocation change: %.6lf(M)\n",