From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB035A034E; Thu, 23 Apr 2020 18:32:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE5FD1C439; Thu, 23 Apr 2020 18:31:56 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B96831C2F5 for <dev@dpdk.org>; Thu, 23 Apr 2020 18:31:55 +0200 (CEST) IronPort-SDR: fjTLTZVU1ssGoc43K3pIHNNvthYLRacctyBeq2pNqVia9V4SNPJeqAkrYzzxe2GpQ46KW3+5Q6 Cnz36FXDK/KA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 09:31:54 -0700 IronPort-SDR: KyF4e76eyTtus7msVSZIJyQ6mlFPo57mPNkN8Ex4N/FQngSP+pblgKjPhphJBfF9iUo4uR2JMU C1mcen5Uj03Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,307,1583222400"; d="scan'208";a="457559608" Received: from rmenon-mobl.amr.corp.intel.com (HELO [10.212.65.39]) ([10.212.65.39]) by fmsmga006.fm.intel.com with ESMTP; 23 Apr 2020 09:31:54 -0700 To: Thomas Monjalon <thomas@monjalon.net>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Cc: talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net References: <20200422072747.15960-1-talshn@mellanox.com> <15414965.hlxOUv9cDv@thomas> <20200423120643.0173e2d2@Sovereign> <3727963.e99z0qppnp@thomas> From: Ranjit Menon <ranjit.menon@intel.com> Message-ID: <dcee9d23-312a-9005-ec75-a1f02375aae2@intel.com> Date: Thu, 23 Apr 2020 09:31:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <3727963.e99z0qppnp@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 4/23/2020 3:48 AM, Thomas Monjalon wrote: > 23/04/2020 11:06, Dmitry Kozlyuk: >> On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: >>> 23/04/2020 01:51, Ranjit Menon: >>>> On 4/22/2020 12:27 AM, talshn@mellanox.com wrote: >>>>> From: Tal Shnaiderman <talshn@mellanox.com> >>>>> >>>>> Move common functions between Unix and Windows to eal_config.c. >>>> >>>> Like other files in common, we should call this eal_common_config.c >>> >>> I am not sure about the interest of repeating the directory name >>> in the file name in general. >>> Do you see a real benefit? In general, no. But in this case, it does make a difference, IMO. When seeing all the files in EAL together, it clearly stands out that these are common/shared files and any change therein will affect others beyond Windows. IMO, I prefer it the way it is. >> >> It allows using VPATH in Makefile. If filenames are identical in different >> VPATH directories, make can't pick both. Makefiles are being deprecated, but >> they'll be around for some more time. > > Makefile will be removed in 20.11 > > ranjit m.