From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0079.outbound.protection.outlook.com [104.47.40.79]) by dpdk.org (Postfix) with ESMTP id F28671075 for ; Tue, 21 Mar 2017 07:22:57 +0100 (CET) Received: from BN3PR03CA0095.namprd03.prod.outlook.com (10.174.66.13) by SN2PR03MB2270.namprd03.prod.outlook.com (10.166.210.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.17; Tue, 21 Mar 2017 06:22:55 +0000 Received: from BY2FFO11FD029.protection.gbl (2a01:111:f400:7c0c::100) by BN3PR03CA0095.outlook.office365.com (2603:10b6:400:4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via Frontend Transport; Tue, 21 Mar 2017 06:22:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD029.mail.protection.outlook.com (10.1.14.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Tue, 21 Mar 2017 06:22:55 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2L6MpLi020894; Mon, 20 Mar 2017 23:22:52 -0700 To: "Wiles, Keith" References: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com> <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com> <37546ac7-1c60-5992-5ebf-eef8e905017e@nxp.com> <70A6BC7D-3F07-4484-A8E4-ACB14522355B@intel.com> <43b90881-7fc7-8f75-f040-2ad8ea922333@nxp.com> CC: "Hunt, David" , Olivier MATZ , DPDK , Thomas Monjalon , "hemant.agrawal@nxp.com" From: Shreyansh Jain Message-ID: Date: Tue, 21 Mar 2017 11:58:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <43b90881-7fc7-8f75-f040-2ad8ea922333@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131345509756660404; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39840400002)(39860400002)(39380400002)(39850400002)(39450400003)(39410400002)(39400400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(199003)(377454003)(24454002)(189002)(9170700003)(966004)(86362001)(104016004)(50986999)(38730400002)(47776003)(6306002)(65826007)(65806001)(4001350100001)(64126003)(229853002)(8656002)(76176999)(54356999)(4326008)(36756003)(31686004)(31696002)(23746002)(50466002)(53376002)(77096006)(105606002)(5660300001)(6246003)(305945005)(110136004)(65956001)(106466001)(2950100002)(356003)(33646002)(8676002)(54906002)(53936002)(8936002)(83506001)(189998001)(2906002)(93886004)(230700001)(81166006)(53546009)(6916009)(85426001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2270; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD029; 1:kiTm8FwYW0NpGqcFLpI8Qgwvwco/Jg+Oiz5QkGVsAO0oQ5e7szizfWvH3adym1RQk8rUTxMxGPNaEs1BMEaPBkuyc/FA5lPSToxg0JgF8RDloUcUpowdmSLjAANk4fYr+tJL6BgrP7c7C1VxOXh2/RM6qxDDnNvZ6dYUTnUMtdyF33fzLIwjy0YI7avPDXjGlDgGilhU4uE3iwxhMhVr0nSDPwsN+S2gJngqB9t+14zbjZtoukZ2ozyerOaldvS/FsI7LwIhMt62u7KHC40IuT/MtTdVMuzrYT9W8gdTx2GUBwvr0bBJEHFhs6FPmC++mTvkCxh/39Z5in89qGJcLVGsqYd2HMKwwY3HyCwuO3xp/rgklTVddxRUKhsqpfrvemxAsE3ki+Zkahz1ts9ce4Af+NYKXbNZW6+9lxqZXeVJ23w4l0BJUw3rM523noSuq0ctnTrJrO5FHTlHD4W3+DCSyjS8G1jncHejllgh65Zrz9RPO47IqQ9y4z2rWdwM8egarV20iH36+sRK7LZyB2twawUPG8w4dtJRCl1bN49tCUHi4qYo8G5snfg6zNQU2eakXD17pBxVk1h1XKdeh5Kj/z4QIOnDlaLBlI//1SRiaS6RXFGSLI2jXStsRA3S X-MS-Office365-Filtering-Correlation-Id: 449fb6df-0fdf-44e1-6ab4-08d47022b65a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN2PR03MB2270; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 3:aqhYEzoutMm68D3xKeHCybiyYngFMuQsKoJje5Mpi5Cpx1bJ8FiDdK82gf35G3HLVtv5lnSs8ZYhU5JHIr7PFTm/DfGUkKFv/sgsD0wiH0z7J+cHdeU+iXpvqukFB2lE0YouArB45QyqVX1qwJ7vYjOP53XYcf6W/jOLCEm5Bf8Mie47CO0jbj4jrqykP1YJCGNXvFeUH49sqTw0Cln0CPP5KkWEkohnlVivbYPUwxx3Gplm92m9P/1OVhdwN8Bj1BO3bTcDvDThJdGhXC5OX1zuD63wCk9uy2n1sjmvKNzzv/KAoCTruqlZOXrVqLjPdLyJiF92GDLGeFXTgUskQa1CJ4F517IAYVSJPRT8cymWhgNP4uhJYZQenaMQemQK; 25:p6HUfnZled7tPNPtsT2rK1OW9VB8GPq5Wx6RzYgWkojAe793mYkESrdWJaALq2bU/T8tQLlz7+io8h6YZmzuJR2o4BWYEWpxiJREwvHOWvnv4Rw+QDrEnl+mxMX5zCpAHtKhP4XrF0hB69TmGvSSe4zAP41ctYG77ame3bG8KZM5eLLYutTmJx2cdkpI24Cjf1stFbaNUxIN2hDRg8ATniiSGKb3Z/7Vj4RdnF4NReygZ6JRsctZ7FI9t8TqDqHulNopqGVUhzkhIzJdJzj7GhPzMF4q9CqErjAT5gJwxakPoRwB7/uwE3z+6z5+Y3mIpz/k5yG83USLCsTtj05T04YEUe0tT+NQ3AoobZkc2cFAwUx9PtuYAOxY2YEfK92nsd/DUyUU5SLcfE2a+ypawpEuSFSXKkbUXtylLL1EOvPEXB6Q0QbFDG0CKTtsq/qoL5lUVV05tLzVjNoP1f7lZA== X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 31:nta3/yzHVLqMT2KnJmmFtRSg2ncmlDPi1vnQKdl3rG+vlNqWql/tlVn+SYd0PgkVgtKLG7bC36+0gFpEKSgk0cLgwAsYV6baF4qJM38GVY1gcv7HQab2Q0loOBTBnGa10yMnja0zRCT1/3FZIzbbw+wUjdCBFNcPJtezjTcYYw2Oqd1wh/gjkm8IuM3om/AK+Lcxnhns2TQDgWXO+n33Oq5HOzFCUge5HKG3ORW+iNrp9yKe7hQcM8Tdx3ATOGhYt/8KIsZeeLkmI9zmMxJufg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(13023025)(5005006)(13017025)(8121501046)(13015025)(13024025)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123561025)(20161123563025)(20161123559025)(20161123565025); SRVR:SN2PR03MB2270; BCL:0; PCL:0; RULEID:(400006); SRVR:SN2PR03MB2270; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 4:InC0Cfiiu9puYUglVyTcv1QniBrSH9hcqqKwqmMBQ+qugiW07k3di/YMBoAAIc7oBJxGzuZKnHWzvjmKuSHKBSNW2W3k9GjswELVte5gfWHflB8t9Ubr5aiBLli624Pl7p7EjicFeeItLmf55E0pHcGOdIJDPY0S68ysO98y0+PkESkBWsTIbzEG+BxHMZAB1YA6COqVor5sqBKnfziE04OANY4Zhuq7fU48CKZM9cLyTn468RVejzkX3WH30R6W6hTpagmQq1FYlEDjBDhGdWhTh7TFQv5QG5Dd7I0jWB/CV1WpswAOMmwTx/QfwX/2ykp+NqQNFJPCK7MttI16RaHOKhbYniEyUIn9VkHM4SxybXKALqG5Ydkc2JwvdKzh36Tou2+Ent+fFoDffSMrgjOTOjNdOmYKTMQMAwkokahvAk+/NwBosZ+rnmeoAwjyu/sIItZNy3Kb/YNasxCuko2p/Td1pj922PTHuwtNDWsS1RYXHsIg6vZU+2PuLwLpMrwhg/DZ/+Eggp/KFVttqd71C6nw/jtQHpuB2hY/iOiLdFdsyt5i8kMbq+3or+DBLxuyTkCy5Sh6ClV3N4VEZES8gsrFZHLawtmuwBFnoF3Frm1e55yEM6OnHlLyg0ij/6DK+x8NUclWriBcSZqlUvt41d1iFYcZeY0P0LeoMgKKEjxi/G3N9MDBqJMPpHERCcUa3wHxnr+ZGWsO9S676gKOArifioQ2Jy3PN8ULSwS6xz8JMxn3qTbdatP8WH3x X-Forefront-PRVS: 02530BD3AA X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR03MB2270; 23:0Aw3sj6u9Z1NsFauuvGog/u9Mx7c4WI+PPYWc?= =?Windows-1252?Q?yz/UpUnOqCDgShkZj17ZkJ1JPUaC/FmOTZeKj3G4Hp/IPzki7Tf1E9Jy?= =?Windows-1252?Q?BV4sNjDNGlWwFFJfMkYyjChe+Hz5ADcHyf7H7Em2QAEia1bWrSPjAcC6?= =?Windows-1252?Q?250DRWY0Q85uTj0mf+QrGQqt00ZHZVbXLDgiEftnaCfm0y8T8Gp+t0VF?= =?Windows-1252?Q?mRKZds+9kiIlViHqTOgo1qhGUV89VmZU0TngB8Qc/wL/C5P3NcTcdZNJ?= =?Windows-1252?Q?YFq6rgxeQ7Nwg787ZeO5EzeaP2QuInxNX47inmjt7AgD5l8cHLW8zSyK?= =?Windows-1252?Q?kCwnT0V4EtQP4ga+UciQvatgr7sDdVz0mkaKGt6vYYj9HvNBPs8T+UOU?= =?Windows-1252?Q?BMkY/DxzrM4FTHdhblUEXmMMUQGScXJFZkviMkriV48VVSlLA9k+ITct?= =?Windows-1252?Q?FmjaA2YME77hU75RPwCsizpH8TNC0EoygnQkDbtCDJ5hWjGLrU1NQjdB?= =?Windows-1252?Q?vHhLczLQ9x+T4Ld9N24ZOTbpiDzGst9+cL7JFTf1wU1f85PtVAGYkM7y?= =?Windows-1252?Q?aDsAUFvAnvpaEo25YZuvlsbt4OkhKK6UbYZcyMi9csmKJHz5R2abHTaS?= =?Windows-1252?Q?8jrprcblWfaLhQ9jl9EnkEAEJb26BVslb2aazmwbUDGwx4V+S4JsnaOa?= =?Windows-1252?Q?vjhXSUXAePFKM0eNuv7QccW1kHbhPHaZ5ptj8FrwfIhEV5Gm/s7OM7LD?= =?Windows-1252?Q?CmYgv3zC64D8RSPxpLvbdTnbSA0Utl39lMWGeaDuhZ7KQufgfpy5huwp?= =?Windows-1252?Q?UvQollIloSYIvm4LeVSXIDziAx46twU+41LbT2ZM/LQNjJzivg+LbFms?= =?Windows-1252?Q?TRN0a/zaq4PUqiI0vjPV09jiCcasT7EEcFtBsU6rW9ByUE3C3GX/bBHC?= =?Windows-1252?Q?vPavAmg4SBIUmdDtW8jxNCDk4ir4lJr+oqp8WaT1t5F9prWmD9F68Ga8?= =?Windows-1252?Q?sRNRVFNFpzAk1U8UsP+Jd8pQD7Dk2hgLF27HsVK8UicfLQAxyK89MH4e?= =?Windows-1252?Q?Tazq+nO9jKM1h86G0mkVa4L9OASm/gVC1UUCABl1fdpQnUyGEcZgyLFT?= =?Windows-1252?Q?SEYY/misbWsIywRqvYkNQxscJvxzn8GbQsyiDkL8weZyGw9GCbCRYD8S?= =?Windows-1252?Q?0cEovprnm3+0Bjlo7cJO3vfXaENbSqAB53NDutTKGbjG9HzvtM6GNvbF?= =?Windows-1252?Q?3DNw6lqce0GJgIGDvo4L1Hs/l7h/HKFgp5ADZx0vraMe2jSFLRWTVbLf?= =?Windows-1252?Q?/rN+LxWqR5nTURvR0AGY3aVQwmftnKwD4cA87n/gbFiAyDM3ZGGyDQq5?= =?Windows-1252?Q?r2yFJ6VxIQ1YL3fOgap52zrFiaHRcppYh0qtFxytfU9thvXF5j9oNQx7?= =?Windows-1252?Q?KK+86udYDzXoaRH397as3qGXEl85yFUkm0h91OFDIfO3R1BnkVnOKyGN?= =?Windows-1252?Q?vHfUN6aCdeDBZDpLTktD/cegdJARV0o8vgcXs0fenJjcNeV/UBeuz/yl?= =?Windows-1252?Q?BFl/C0L9JoO+uAsBJK0It4C+3JcFhm9QFNW4kPb50zNlU3gn/fXb/McP?= =?Windows-1252?Q?spsgkq3i5dDXo26J5eEqfE0VZjReX/QnsLaapYGV+taCk3xJ1hljuEMX?= =?Windows-1252?Q?1V21n37GWZF51mUQp5KA6UmVJXxFH0=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 6:kUaa7jZdE8wNV4XqGRYjuWH3Yt95DrG8wxxY9ezUevREAp1zvqiU/1Qtr8GkeMB8vQzBhJthTdvl4O0/whZt4nAOqJJYgm6ZstXpitqadFBwmbASHWYZglZoKOWt0aH6o14EdiWbl9Fj8Nr0kSQrkhkDDezyZ1mozMH/ElFaljffcaghwBvoOl0Vs997ewDiPO+qD+f8IPxVHuXg/qEcqNK7TVm/YBDqWX97gFhMW2sAKx3EXqZxu0HZy5opalaZH25iv4E//uTMlIMsDXU+XWdQSx4InWr4Zd5qEn7Kt4qM/VRKL3ZEGRpp+g5gpXxyW5hK+j48xLRbZ2PskwTVa7Irnyby9J1EoxlscExeDGfg0KeuDXcJxaVwJlPxVzH3L4TfT9HbsDLQonJLEPLLLBYX138jBVjNuKH577NcGSs=; 5:AF6o5vso1i9PB4obu1y+PkhCTxZgCsCmoPaKTjwMJnMUDR1SmlA5otCTyPtPY2Rc6gSRaZKDpkwto+n4LcDxa2/8/lRbTMkw8UxPC9Z3rxXyrWqHhZtJWjAMsnP25uTLDGVct4gy4gQlUvw2e7omhuOLQaLcihRD2wew2shybBWx1R90sEP2x5N1ElHkwg7B; 24:x1Z/DVGgyVuROkHox1EZwIt6pUUF5YNnP+/24S+K2V1Uieh8jF3PMZi2Qf4FSnJk0CrIhcn1Qez4aDGOGdAODfYsQrxO4iViFpArvQg77z8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 7:0L3hGIlHjFalpwSYk/oEoArTqYZUSzjhEsxUiXqunzVh6jk0bTs02/x++emxf61+M9kRoOSHSb/C3dEfzNfat8V9np0R2N07p+Po+fmNYOuDWK3r5sjWgkFEWKMfYWmuptUGpAy4PF5i7UBL+nEEekrvb7AkCl0VfLzSc+s+4TO0If9dJRAhgGZL++ZF+QJ+7rDB26fnhvCaR8goWr4o9ylhyA8A0gPaEkiodlSgA1L04NEo4dwbYHhmGgUOvAapLlVP2sKw5ursfZ8K2ML07Q+zMNAjl3jVlKi7hXeIz78sULJpFe9/NGcj0X1uV6544rkjyautv1Ggfzbl9KVv7Q== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2017 06:22:55.4164 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2270 Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 06:22:58 -0000 On Tuesday 21 March 2017 11:55 AM, Shreyansh Jain wrote: > Hello Keith, > > On Tuesday 21 March 2017 11:32 AM, Wiles, Keith wrote: >> >>> On Mar 20, 2017, at 11:55 PM, Shreyansh Jain >>> wrote: >>> >>> Hello David, >>> >>> On Monday 20 March 2017 08:20 PM, Hunt, David wrote: >>>> >>>> On 20/3/2017 10:03 AM, Shreyansh Jain wrote: >>>>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. >>>>> Stack mempool handler moved from lib/librte_mempool into >>>>> drivers/mempool. >>>>> >>> >>> <...> >>> >>>>> -} >>>>> - >>>>> -static struct rte_mempool_ops ops_stack = { >>>>> - .name = "stack", >>>>> - .alloc = stack_alloc, >>>>> - .free = stack_free, >>>>> - .enqueue = stack_enqueue, >>>>> - .dequeue = stack_dequeue, >>>>> - .get_count = stack_get_count >>>>> -}; >>>>> - >>>>> -MEMPOOL_REGISTER_OPS(ops_stack); >>>> >>>> Shreyansh, >>>> Could I suggest you add the parameter "--find-renames" when >>>> generating the patch files, as this will reduce the size of the patches >>>> significantly, making for easier review. The patch line count in this >>>> particular case would be reduced by approx 75%. >>> >>> Thanks for suggestion. >>> Yes, I forgot to use this option while creating this patch. If there >>> are comments and v2 needs to be created, I will keep this in mind. >>> >>>> Regards, >>>> Dave. >> >> I guess I missed an email, but what is the advantage of moving the >> ring/stack files to the drivers directory as they are not drivers in >> the sense of a NIC PMD or any other driver. You can still >> enable/disable them in the config files right? >> > > Just as reference, following is where this was being discussed: > > http://dpdk.org/ml/archives/dev/2017-March/059690.html > http://dpdk.org/ml/archives/dev/2017-March/059753.html > and > http://dpdk.org/ml/archives/dev/2017-March/060501.html > > Also, a while back (I can't trace that mailing list exchange), it was > decided that all mempool drivers (stack, ring, others...) would be > moved to drivers/mempool. Just to add, discussion at that time was to have: drivers/bus/ drivers/mempool/ drivers/net/ There was a drivers/common as well, but somehow it didn't go down well in discussions. > > For NXP's DPAA2 PMD, we use an offloaded mempool for which there was a > patchset by Hemant [1] which adds that driver to drivers/mempool. In > the same breadth, ring and stack are also being moved to > drivers/mempool as independent drivers (non-offloaded category). > > [1] http://dpdk.org/ml/archives/dev/2017-March/060476.html > > In my opinion, this would make the lib/* area free of handler/drivers > (almost) and it is a good change. Also, ring and stack use a > 'registration' mechanism - just like PMD and are good candidate to be > treated as 'drivers' now even though not entirely like a PMD. > > You see any downside of this? > >> Regards, >> Keith >> >> > > - > Shreyansh > >