DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID
@ 2021-02-21  0:51 Dmitry Kozlyuk
  2021-02-22  9:20 ` David Marchand
  2021-03-01 21:51 ` Nick Connolly
  0 siblings, 2 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-02-21  0:51 UTC (permalink / raw)
  To: dev
  Cc: Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam, Dmitry Kozlyuk

Add device ID of VMWare Paravirtualized Ethernet v3.

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 666a69c..db97366 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -42,6 +42,7 @@ HKR,,Icon,,-5
 %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
 %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
 %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
+%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
 
 [netuio_Device.NT]
 CopyFiles=Drivers_Dir
@@ -99,6 +100,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
 Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
 Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
 Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
+vmxnet3.Description = "VMWare Paravirtualized Ethernet v3"
 netuio.SVCDESC = "netuio Service"
 
 [DMAr.reg]
-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID
  2021-02-21  0:51 [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID Dmitry Kozlyuk
@ 2021-02-22  9:20 ` David Marchand
  2021-02-22 17:54   ` Tyler Retzlaff
  2021-03-01 21:51 ` Nick Connolly
  1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2021-02-22  9:20 UTC (permalink / raw)
  To: Dmitry Kozlyuk
  Cc: dev, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam

On Sun, Feb 21, 2021 at 1:52 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> Add device ID of VMWare Paravirtualized Ethernet v3.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  windows/netuio/netuio.inf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index 666a69c..db97366 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -42,6 +42,7 @@ HKR,,Icon,,-5
>  %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>  %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>  %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
>
>  [netuio_Device.NT]
>  CopyFiles=Drivers_Dir
> @@ -99,6 +100,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>  Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>  Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>  Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +vmxnet3.Description = "VMWare Paravirtualized Ethernet v3"
>  netuio.SVCDESC = "netuio Service"
>
>  [DMAr.reg]

Is there no other way than hardcoding those values in the driver?
Something à la driverctl?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID
  2021-02-22  9:20 ` David Marchand
@ 2021-02-22 17:54   ` Tyler Retzlaff
  0 siblings, 0 replies; 5+ messages in thread
From: Tyler Retzlaff @ 2021-02-22 17:54 UTC (permalink / raw)
  To: David Marchand
  Cc: Dmitry Kozlyuk, dev, Narcisa Ana Maria Vasile, Dmitry Malloy,
	Pallavi Kadam

On Mon, Feb 22, 2021 at 10:20:41AM +0100, David Marchand wrote:

> > diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> > index 666a69c..db97366 100644
> > --- a/windows/netuio/netuio.inf
> > +++ b/windows/netuio/netuio.inf
> > @@ -42,6 +42,7 @@ HKR,,Icon,,-5
> >  %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
> >  %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
> >  %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> > +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
> >
> 
> Is there no other way than hardcoding those values in the driver?
> Something à la driverctl?

This is how support for vendor / device is expressed for a driver
to the Windows PnP subsystem.  The device ids listed in the .inf
file are used to match the driver when the device is enumerated.

It's not really hardcoded though (not compiled anyway) so the list
of ids in a .inf can be changed without recompiled it is just a text
file.

> 
> 
> -- 
> David Marchand

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID
  2021-02-21  0:51 [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID Dmitry Kozlyuk
  2021-02-22  9:20 ` David Marchand
@ 2021-03-01 21:51 ` Nick Connolly
  2021-03-17  9:54   ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Nick Connolly @ 2021-03-01 21:51 UTC (permalink / raw)
  To: Dmitry Kozlyuk, dev
  Cc: Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam


> +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
>
Acked-by: Nick Connolly <nick.connolly@mayadata.io>

PCI hardware IDs verified against:
https://devicehunt.com/view/type/pci/vendor/15AD/device/07B0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID
  2021-03-01 21:51 ` Nick Connolly
@ 2021-03-17  9:54   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-03-17  9:54 UTC (permalink / raw)
  To: Dmitry Kozlyuk
  Cc: dev, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam,
	Nick Connolly

01/03/2021 22:51, Nick Connolly:
> 
> > +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
> >
> Acked-by: Nick Connolly <nick.connolly@mayadata.io>
> 
> PCI hardware IDs verified against:
> https://devicehunt.com/view/type/pci/vendor/15AD/device/07B0

Applied, thanks



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-17  9:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21  0:51 [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID Dmitry Kozlyuk
2021-02-22  9:20 ` David Marchand
2021-02-22 17:54   ` Tyler Retzlaff
2021-03-01 21:51 ` Nick Connolly
2021-03-17  9:54   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).