From: fengchengwen <fengchengwen@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"viktorin@rehivetech.com" <viktorin@rehivetech.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"juraj.linkes@pantheon.tech" <juraj.linkes@pantheon.tech>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method
Date: Wed, 19 May 2021 08:23:58 +0800 [thread overview]
Message-ID: <dd05ab1f-e4b2-284b-0e1a-cb6e51e4d3f3@huawei.com> (raw)
In-Reply-To: <394de3ea-f0ba-a5a3-e751-be04f479281d@intel.com>
Thanks a lot, Ferruh & Honnappa.
On 2021/5/19 0:27, Ferruh Yigit wrote:
> On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote:
>> <snip>
>>
>>>
>>> Currently, the SVE code is compiled only when -march supports SVE (e.g. '-
>>> march=armv8.2a+sve'), there maybe some problem[1] with this approach.
>>>
>>> The solution:
>>> a. If the minimum instruction set support SVE then compiles it.
>>> b. Else if the compiler support SVE then compiles it.
>>> c. Otherwise don't compile it.
>>>
>>> [1] https://mails.dpdk.org/archives/dev/2021-April/208189.html
>>>
>>> Fixes: 8c25b02b082a ("net/hns3: fix enabling SVE Rx/Tx")
>>> Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Looks good to me.
>> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>>
>
> Applied to dpdk-next-net/main, thanks.
>
> (Only this patch, 2/2, applied, not whole set)
>
> .
>
next prev parent reply other threads:[~2021-05-19 0:24 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 8:28 [dpdk-dev] [PATCH 0/2] bugfix for Kunpeng930 SVE compile Chengwen Feng
2021-05-12 8:28 ` [dpdk-dev] [PATCH 1/2] config/arm: add non-SVE march for soc kunpeng930 Chengwen Feng
2021-05-12 8:44 ` Jerin Jacob
2021-05-12 23:00 ` Honnappa Nagarahalli
2021-05-13 4:49 ` fengchengwen
2021-05-12 8:28 ` [dpdk-dev] [PATCH 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-12 23:12 ` Honnappa Nagarahalli
2021-05-12 23:21 ` Honnappa Nagarahalli
2021-05-13 0:51 ` fengchengwen
2021-05-13 20:42 ` Honnappa Nagarahalli
2021-05-13 10:04 ` Bruce Richardson
2021-05-13 4:41 ` [dpdk-dev] [PATCH v2 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-13 4:41 ` [dpdk-dev] [PATCH v2 1/2] config/arm: select best -march parameter for kunpeng soc Chengwen Feng
2021-05-13 4:41 ` [dpdk-dev] [PATCH v2 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-13 6:16 ` [dpdk-dev] [PATCH v3 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-13 6:16 ` [dpdk-dev] [PATCH v3 1/2] config/arm: select most suitable -march for kunpeng soc Chengwen Feng
2021-05-13 6:16 ` [dpdk-dev] [PATCH v3 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-13 13:08 ` [dpdk-dev] [PATCH v4 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-13 13:08 ` [dpdk-dev] [PATCH v4 1/2] config/arm: select most suitable -march for kunpeng soc Chengwen Feng
2021-05-13 15:24 ` Jerin Jacob
2021-05-13 23:12 ` Honnappa Nagarahalli
2021-05-14 10:23 ` fengchengwen
2021-05-18 13:25 ` Honnappa Nagarahalli
2021-05-18 13:45 ` Jerin Jacob
2021-05-13 13:08 ` [dpdk-dev] [PATCH v4 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-13 22:19 ` Honnappa Nagarahalli
2021-05-14 2:53 ` fengchengwen
2021-05-14 9:53 ` [dpdk-dev] [PATCH v5 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-14 9:53 ` [dpdk-dev] [PATCH v5 1/2] config/arm: select most suitable -march for kunpeng soc Chengwen Feng
2021-05-14 9:53 ` [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-14 14:12 ` Honnappa Nagarahalli
2021-05-18 12:41 ` fengchengwen
2021-05-18 13:11 ` Honnappa Nagarahalli
2021-05-18 13:12 ` Honnappa Nagarahalli
2021-05-18 13:24 ` Ferruh Yigit
2021-05-18 16:27 ` Ferruh Yigit
2021-05-19 0:23 ` fengchengwen [this message]
2021-05-19 8:08 ` David Marchand
2021-05-19 9:27 ` Ferruh Yigit
2021-05-19 12:16 ` fengchengwen
2021-05-19 12:37 ` David Marchand
2021-05-19 13:35 ` fengchengwen
2021-05-18 14:40 ` Ferruh Yigit
2021-05-18 15:15 ` Bruce Richardson
2021-05-18 16:12 ` Ferruh Yigit
2021-05-18 15:48 ` Honnappa Nagarahalli
2021-05-18 16:00 ` Ferruh Yigit
2021-05-18 16:12 ` Honnappa Nagarahalli
2021-05-18 16:37 ` Ferruh Yigit
2021-05-19 0:18 ` fengchengwen
2021-05-19 13:25 ` [dpdk-dev] [PATCH v6 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-19 13:25 ` [dpdk-dev] [PATCH v6 1/2] config/arm: select most suitable -march for kunpeng soc Chengwen Feng
2021-05-19 14:05 ` Jerin Jacob
2021-05-20 22:38 ` Honnappa Nagarahalli
2021-05-19 13:25 ` [dpdk-dev] [PATCH v6 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-19 15:02 ` Ferruh Yigit
2021-05-20 1:11 ` fengchengwen
2021-05-20 7:57 ` Ferruh Yigit
2021-05-20 8:24 ` Ruifeng Wang
2021-05-20 10:55 ` fengchengwen
2021-05-21 5:21 ` Ruifeng Wang
2021-05-21 6:53 ` fengchengwen
2021-05-24 5:38 ` Ruifeng Wang
2021-05-24 8:43 ` fengchengwen
2021-05-24 10:03 ` Ruifeng Wang
2021-05-24 13:15 ` fengchengwen
2021-05-24 13:12 ` [dpdk-dev] [PATCH v7 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-24 13:12 ` [dpdk-dev] [PATCH v7 1/2] config/arm: select most suitable -march for kunpeng soc Chengwen Feng
2021-05-24 13:12 ` [dpdk-dev] [PATCH v7 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-24 13:23 ` [dpdk-dev] [PATCH v8 0/2] bugfix for Kunpeng SVE compile Chengwen Feng
2021-05-24 13:23 ` [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc Chengwen Feng
2021-06-17 7:03 ` Thomas Monjalon
2021-06-17 23:33 ` Honnappa Nagarahalli
2021-06-21 0:52 ` fengchengwen
2021-06-23 8:08 ` Thomas Monjalon
2021-06-23 8:24 ` fengchengwen
2021-05-24 13:23 ` [dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile method Chengwen Feng
2021-05-25 6:04 ` Ruifeng Wang
2021-05-27 7:07 ` Fengchengwen
2021-06-12 7:09 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd05ab1f-e4b2-284b-0e1a-cb6e51e4d3f3@huawei.com \
--to=fengchengwen@huawei.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).