From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EC6642C82; Tue, 20 Jun 2023 11:29:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B503B4113F; Tue, 20 Jun 2023 11:29:55 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id 1C5F3410F6 for ; Tue, 20 Jun 2023 11:29:54 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f8775126d3so1504743e87.1 for ; Tue, 20 Jun 2023 02:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1687253393; x=1689845393; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oHhipc0a8/iCxrIAgHT/j5gCwN+Y99m8CnYtZkiiDI=; b=DKKId+hYoNJUrXqZXIfEYS1CDG+A9iGwJUYnu54lzkN6/0xH631e8Hj956FD+gFzY3 FyKndaS6PWP89hzZI/Fq2KDThZIaNg4zhWwinnPpgXfAEZFlsbxi4jt8WiHpGcMTQ2cO Ucn1BydG8c/IkjSU4lHwTVxqXt48sMph72Eqli3QlMvioLm8dITGVQVqVXgQkr3Vbmng oJB0Y+rBFZcyQvOC0m5jvu0iin7kRyOBdxogBI+/PJdjqcITo+8H9NYpdJm0whJ6PbLr iCDSqJTlCs4rkCyQhuXYBEy1dzS5ImRmVPoSQ0Mj+NY2rjqM3HS2jcXIIOkbrF683R8M 0VXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687253393; x=1689845393; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6oHhipc0a8/iCxrIAgHT/j5gCwN+Y99m8CnYtZkiiDI=; b=TTymLKs+YZAj6Z4ALQmuZa4LJfHlQJ+s/UG61MAwnJAzMWY+9pbizN0OH47C2yI2rg mynl5MMtGcuHJ/ZgHsLRH5kkFNRshiu+IZ5O6AWJOvwES7C/0OR8YdLNH19Bt/rQWHYd iILrMe5n4BMX1N+YQyNt74Nmsgbrl9iKk1Edzvai+vtt1Ejp8BOU6Ennh6e7L5mzzsbj 3x+sypQjfXhaZ21kMDh5jtDwUZXilYPo13FtSvz8Ms5ghqJpT7qeWp5tzirtVyrNk1ZC FmMVqch820r3AwKtnD9C+iiQnRx2crK/z1ARItyQ1TLQtpPVypTUCjCuLTlJIPoDL6pD UzvQ== X-Gm-Message-State: AC+VfDy6FAIx9SyNY2A6K1y+whRrtNwUE4BaMBDGwA+0lz6odjMMSkR8 DujDv/RXiIyCaQxVALNlBaW6 X-Google-Smtp-Source: ACHHUZ5YsZRHknn4ZVSVbIS+L0P9z8BJ/ns+ftof8daQU5Yq2bD4aCmWo7DtjKnstfzJar4Arelwsg== X-Received: by 2002:a19:6714:0:b0:4f8:5713:7dd5 with SMTP id b20-20020a196714000000b004f857137dd5mr6777109lfc.10.1687253393524; Tue, 20 Jun 2023 02:29:53 -0700 (PDT) Received: from [10.17.1.39] ([185.13.181.2]) by smtp.gmail.com with ESMTPSA id y10-20020a5d4aca000000b0030ae6432504sm1568713wrs.38.2023.06.20.02.29.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 02:29:53 -0700 (PDT) Message-ID: Date: Tue, 20 Jun 2023 11:29:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini Content-Language: en-US To: Ashwin Sekhar T K , "dev@dpdk.org" Cc: Thomas Monjalon , Nithin Kumar Dabilpuram , Satha Koteswara Rao Kottidi , Jerin Jacob Kollanukkaran References: <20230620085134.3124796-1-thierry.herbelot@6wind.com> From: Thierry Herbelot In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ashwin, I will resend a patch with a fix also in npa_aura_pool_fini Thierry On 6/20/23 11:27, Ashwin Sekhar T K wrote: > Hi Thierry, > > Could you please add the same fix in npa_aura_pool_fini() as well. > > Thanks > Ashwin Sekhar T K > >> -----Original Message----- >> From: Thierry Herbelot >> Sent: Tuesday, June 20, 2023 2:22 PM >> To: dev@dpdk.org >> Cc: Thierry Herbelot ; Thomas Monjalon >> ; Nithin Kumar Dabilpuram >> ; Satha Koteswara Rao Kottidi >> ; Jerin Jacob Kollanukkaran >> >> Subject: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini >> >> External Email >> >> ---------------------------------------------------------------------- >> Unlock mbox when an error is detected. >> >> Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC >> APIs') >> Signed-off-by: Thierry Herbelot >> --- >> drivers/common/cnxk/roc_npa.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/common/cnxk/roc_npa.c >> b/drivers/common/cnxk/roc_npa.c index 377439c2baaf..38e149da82cc >> 100644 >> --- a/drivers/common/cnxk/roc_npa.c >> +++ b/drivers/common/cnxk/roc_npa.c >> @@ -245,8 +245,10 @@ npa_aura_fini(struct mbox *m_box, uint32_t >> aura_id) >> if (rc < 0) >> goto exit; >> >> - if (aura_rsp->hdr.rc != 0) >> - return NPA_ERR_AURA_POOL_FINI; >> + if (aura_rsp->hdr.rc != 0) { >> + rc = NPA_ERR_AURA_POOL_FINI; >> + goto exit; >> + } >> >> /* Sync NDC-NPA for LF */ >> ndc_req = mbox_alloc_msg_ndc_sync_op(mbox); >> -- >> 2.39.2 > -- Thierry Herbelot Senior Software Engineer Tel: +33 1 39 30 92 61 http://www.6wind.com/ Follow us: https://www.linkedin.com/company/6wind/ https://twitter.com/6WINDsoftware https://www.youtube.com/user/6windsoftware