From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, arybchenko@solarflare.com
Cc: Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>,
dev@dpdk.org, igor.romanov@oktetlabs.ru, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: don't ignore RSS key on device configuration
Date: Thu, 13 Sep 2018 16:23:50 +0100 [thread overview]
Message-ID: <dd31675d-e469-c648-0ee5-c5b4ba3b9d7e@intel.com> (raw)
In-Reply-To: <CAG2-Gkm5P6vXXh1wQB3ibz_mUyMwevX0phciFoetbpqbn157tA@mail.gmail.com>
On 9/4/2018 2:27 PM, Chas Williams wrote:
> On Wed, Aug 29, 2018 at 3:51 AM Andrew Rybchenko <arybchenko@solarflare.com>
> wrote:
>
>> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>>
>> Bonding driver ignores the value of RSS key (that is set in the port RSS
>> configuration) in bond_ethdev_configure(). So the only way to set
>> non-default RSS key is by using rss_hash_update(). This is not an
>> expected behaviour.
>>
>> Make the bond_ethdev_configure() set default RSS key only if
>> requested key is set to NULL.
>>
>> Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>
>
> Acked-by: Chas Williams <chas@att.com>
Replaced with:
Acked-by: Chas Williams <chas3@att.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-09-13 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:51 [dpdk-dev] " Andrew Rybchenko
2018-09-04 13:27 ` Chas Williams
2018-09-13 15:23 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd31675d-e469-c648-0ee5-c5b4ba3b9d7e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=arybchenko@solarflare.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=igor.romanov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).