From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 7C8C71B027;
 Thu, 13 Sep 2018 17:23:58 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 13 Sep 2018 08:23:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,369,1531810800"; d="scan'208";a="88476618"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56])
 ([10.237.221.56])
 by fmsmga004.fm.intel.com with ESMTP; 13 Sep 2018 08:23:50 -0700
To: Chas Williams <3chas3@gmail.com>, arybchenko@solarflare.com
Cc: Declan Doherty <declan.doherty@intel.com>, Chas Williams <chas3@att.com>, 
 dev@dpdk.org, igor.romanov@oktetlabs.ru, stable@dpdk.org
References: <1535529084-5947-1-git-send-email-arybchenko@solarflare.com>
 <CAG2-Gkm5P6vXXh1wQB3ibz_mUyMwevX0phciFoetbpqbn157tA@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Openpgp: preference=signencrypt
Message-ID: <dd31675d-e469-c648-0ee5-c5b4ba3b9d7e@intel.com>
Date: Thu, 13 Sep 2018 16:23:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAG2-Gkm5P6vXXh1wQB3ibz_mUyMwevX0phciFoetbpqbn157tA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: don't ignore RSS
 key on device configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Sep 2018 15:24:00 -0000

On 9/4/2018 2:27 PM, Chas Williams wrote:
> On Wed, Aug 29, 2018 at 3:51 AM Andrew Rybchenko <arybchenko@solarflare.com>
> wrote:
> 
>> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>>
>> Bonding driver ignores the value of RSS key (that is set in the port RSS
>> configuration) in bond_ethdev_configure(). So the only way to set
>> non-default RSS key is by using rss_hash_update(). This is not an
>> expected behaviour.
>>
>> Make the bond_ethdev_configure() set default RSS key only if
>> requested key is set to NULL.
>>
>> Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>
> 
> Acked-by: Chas Williams <chas@att.com>

Replaced with:
Acked-by: Chas Williams <chas3@att.com>

Applied to dpdk-next-net/master, thanks.