From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5A2B45D0B; Fri, 15 Nov 2024 07:02:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D70342EF2; Fri, 15 Nov 2024 07:02:13 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 376EF42E52 for ; Fri, 15 Nov 2024 07:02:01 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XqRG12bjgz21ktZ; Fri, 15 Nov 2024 14:00:41 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id CEE5C14022D; Fri, 15 Nov 2024 14:01:57 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 15 Nov 2024 14:01:57 +0800 Message-ID: Date: Fri, 15 Nov 2024 14:01:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/14] use rte_strerror() for rte_errno To: Dengdui Huang , CC: , , , , , , , , , References: <20231114082539.1858594-1-huangdengdui@huawei.com> <20241114114000.1677350-1-huangdengdui@huawei.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20241114114000.1677350-1-huangdengdui@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Series-acked-by: Chengwen Feng On 2024/11/14 19:39, Dengdui Huang wrote: > Whether strerror() needs to be replaced needs further discussion, > but rte_error should not be used by strerror() because rte_errno > may be an RTE-specific error code. > > This patchset use rte_strerror() instead of strerror() for rte_errno. > > Also, I tried to add it to checkpatch, but rte_errno can be used as an argument to any function > and the checkpatch script should not return an error, so I didn't do that. > > Dengdui Huang (14): > eal: fix use rte errno for libc function > eal: use rte strerror > pdump: use rte strerror > bus/vdev: use rte strerror > common/mlx5: use rte strerror > net/af_xdp: use rte strerror > net/bonding: use rte strerror > net/failsafe: use rte strerror > net/memif: use rte strerror > net/mlx4: use rte strerror > net/mlx5: use rte strerror > net/tap: use rte strerror > app/dumpcap: use rte strerror > test: use rte strerror > > app/dumpcap/main.c | 2 +- > app/test/test_bpf.c | 10 +++++----- > drivers/bus/vdev/vdev.c | 2 +- > drivers/common/mlx5/linux/mlx5_nl.c | 10 +++++----- > drivers/common/mlx5/mlx5_common.c | 6 +++--- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- > drivers/net/bonding/rte_eth_bond_flow.c | 4 ++-- > drivers/net/failsafe/failsafe.c | 2 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > drivers/net/failsafe/failsafe_flow.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/mlx4/mlx4.c | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++--------- > drivers/net/mlx4/mlx4_rxq.c | 4 ++-- > drivers/net/mlx4/mlx4_txq.c | 10 +++++----- > drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 +++++++++++----------- > drivers/net/mlx5/linux/mlx5_os.c | 16 ++++++++-------- > drivers/net/mlx5/mlx5.c | 8 ++++---- > drivers/net/mlx5/mlx5_mac.c | 2 +- > drivers/net/mlx5/mlx5_rxmode.c | 8 ++++---- > drivers/net/mlx5/mlx5_stats.c | 2 +- > drivers/net/mlx5/mlx5_testpmd.c | 10 +++++----- > drivers/net/mlx5/mlx5_trigger.c | 12 ++++++------ > drivers/net/mlx5/mlx5_vlan.c | 2 +- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- > drivers/net/mlx5/windows/mlx5_os.c | 10 +++++----- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > lib/eal/linux/eal_dev.c | 2 +- > lib/eal/unix/eal_unix_memory.c | 2 +- > lib/pdump/rte_pdump.c | 2 +- > 31 files changed, 93 insertions(+), 93 deletions(-) >