From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9EDC45C9B; Wed, 13 Nov 2024 00:40:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F73C402BC; Wed, 13 Nov 2024 00:40:15 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by mails.dpdk.org (Postfix) with ESMTP id 8791840265 for ; Wed, 13 Nov 2024 00:40:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PA7b2XG33avm/bjaOva5qnVmt23s2MXiPl8aqwwX/HyVyHBqjyTDplblnIjX1GjiM881Hfse5JdXiT8utoPsimUD1Gk7BCcENcK0LRLlHPlHBE+BJ1uFfJ3K8xqj5Ycc4t29VFBqT7mP1P82gUZT6Y0L4Jsexy3ZL1f4FHUzdH7xjOZMel6yTehOrke3iUjtWOMHxpBVZ9iiGa1QWUCROZ3QEqV2Bw8TlhwJLOY4IdNXd//s1wYv+xlS0mXULT52GfqGUE1ksFimIYvzbO6WavKlwf2fNexitBUYijnlOl6ktfR6icLr/J/7QevbG/VEdQlDj0BYrp7KFJRchcXxmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HO3cbC4NaNgdqJ2S8fpN/Wsdv+TGoBCF2A0Ei+JbLhk=; b=pSpJQvjLLP62nuMSzmLgDXNovRQcOSLXhSKrEqTODjjvJXM2VnJhZmlogbvtUCmRNzQcRWU2fB82wtPt/GaXD1g5LRgtdOIBmYrsEMdYOTKN97ssiRISKU8au/nrUubtdcVH/jUGtpAWRKYfd9MWg7tTPSjyf/fifaiaXhxqrgdZQqpcbR3Me/FurbwJeV0ruZ8aeP5LBFbDK3d0ofGqZhvRywnDpAV4g3qXuI+S+AQxFL1kAhscX3t0zrQGqvJzDe/HcDPfSiMCu1sCK0g9LmU78EoZHaFmC2ZqU87c3djoHw9j4WHtuB4elRvDHZaZuiPYqpRa5HjDzhM+RaaDWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HO3cbC4NaNgdqJ2S8fpN/Wsdv+TGoBCF2A0Ei+JbLhk=; b=YpxqoC3EtMGSHN5RKfyNxuR4e0P9zWvn8oOfNjp9w9DpP8Km4o5HnQkn/oYud7T6gS+H5XsDFwvAiLp9w3am+nkB99roqwJyd4MaDq5lDRubH9QrtzbaZoigNzDrhGdhGnPo2DIsvweHNG1Vr/yzXVMzLuthBEr3dRw6nLUWHAQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SN7PR12MB7935.namprd12.prod.outlook.com (2603:10b6:806:349::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Tue, 12 Nov 2024 23:40:10 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8158.013; Tue, 12 Nov 2024 23:40:08 +0000 Message-ID: Date: Tue, 12 Nov 2024 23:40:02 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 08/17] net/r8169: add support for PHY configuration To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241112095804.42091-1-howard_wang@realsil.com.cn> <20241112095804.42091-9-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241112095804.42091-9-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P194CA0015.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::10) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SN7PR12MB7935:EE_ X-MS-Office365-Filtering-Correlation-Id: 0739791b-b983-4005-0b5e-08dd03735718 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UWVhUWt4SEl1MjN3VkJVWTNvUnJ6VHBmc25BaldTU3luQ1pPWDJjZjBGNzlL?= =?utf-8?B?cUpMaUYyalFpRGIwSE56cm5MVWhuOVhFRmtuNzFWRWEvMVJyWFlzV0luL29I?= =?utf-8?B?a1djWVg1QmFRV0tYUW9uYTZoNy9XUU82UVN6aHl4OXIwRVp0enF0WmtaYWhu?= =?utf-8?B?T2JvenBvczFKZ2lHT0NoeFRUOEM3WmNVeU9GUlV3RXkweEhVWThYcmd5Vkgr?= =?utf-8?B?VkJXQnJYRG5OSjM5MG9qMC90Qmh4WXpuUjlCMjNtTXExRzFtWWJUc0o4Um9p?= =?utf-8?B?K3BzSkJ0VVI5ZHdjTGs3WEdTK2ZySldZeUpBWUw4ZkZWR2NGOGdIaGlhQ1FG?= =?utf-8?B?cVFwUk8rQ1hOZHRESWMwVGhpbXJpM1JScmZyZlVoVGZzWmNwdzdhV3hwWEpG?= =?utf-8?B?T0J1R2ZjK0QxRVBGbS9sSVVnOGQ3a2l2VlZmTjZVRWlCcEZPZGJQTzJHT1Za?= =?utf-8?B?OGd3bEx3UjNKL296dFMvZnJCWmkyZjdnSW14anU1V0hqU1pFQTlGMVVpOEtu?= =?utf-8?B?QXNQTm9MQ3dBV3VBb1hDa0J4QXBQbXRDQU5VajhRT1ZkNjNXMWZsUWlqVjRl?= =?utf-8?B?SWNVK1RWR2o1TXpRa3B1SE1UM1FoaStCMld3VG1za2ltaUtRbFF6M1ZNR1l6?= =?utf-8?B?YmthRGxBYTNFTVNFb2RieGxOT1EwWTN4RG9FSmpEZi9lUFM0RFRlSnlmV29y?= =?utf-8?B?ZmdYeG9GNnhpMmF1MDlXVzFlMElPdldHR1kyTUZWcUhGNENOdFNweXJybUpQ?= =?utf-8?B?NHVzQ1hBSTB3RzFDUVl6dWp2K05vYTNGSjdUWGEvV3FuSW5DU3pxYmhVYjRk?= =?utf-8?B?NElHQmF3V29HS2J6amJKekZmQmwyNklzUzF0Wkx2Y3o1QlcxWmJ2RGlzZDZs?= =?utf-8?B?TENKZTlnWWhrZWg2cHpuaHozY3YxQU0vMWJPdUFYck9kOFNLL3NpNGdJcXBa?= =?utf-8?B?bHJIaWdOL2diN0RGYnhMQ0hTSGJkN3c1MTdxSCtYZjc3UytKZmVjbUd1dmJl?= =?utf-8?B?Tzc1SHhZeDA4M2IvdUhXVzNLQVE1dk5zMFpLTFJSczl1QU5PdFVYQkR0dmR3?= =?utf-8?B?UmtqbFZ6ejJCUS9oY2I5dEJPbjhqQkZLcGllbXVMTklNalE0aVI2WlF0L21T?= =?utf-8?B?WWg1bUJOTHAzaG9BVE82U3NxU1plcW10NWRCVTAyWldhcFFLaWdraFZUa1Zp?= =?utf-8?B?Zm9Lcys4TXJYVzd5aXJhVDRKWklHN2EzY3RibmdyYlBON1VLOVVDQ1MxYVdm?= =?utf-8?B?aWtYWHNNZkVZWENIT1pveUVUUG5PdzVVc3Z2cGRTTkd3Q3h0QTV6VGVWMVVC?= =?utf-8?B?b1JJdjdGdW1CcEl5VjlVQWlqSkZXN1A1M3FRakdVMS8rMzR4UTZ3dnV4bng2?= =?utf-8?B?MEgrN2VRL2VJcEVHWWhsNFFFdWI1MjkzRS9GYy9qZEJFaTVVM0w4VUxlMDY1?= =?utf-8?B?eCtlVnFVQlVkSHBGRkZZeDhMcXUvSmJrRS90bFh2OVRvdTRUNGNlblNCSjJv?= =?utf-8?B?REdvbm1vcjIzcTVzT2JGN3l5SkovSmVheE9ka0d4WjduUVM2eTVPVnlpZlBj?= =?utf-8?B?QWNqZ3N4c3hEOGFzY0tHSTh4MUJqQkg5VnUwZlNHRXZNU1MzTjRBdC9BUmVj?= =?utf-8?B?dXpUMzNlN3NhRCtPWTZXaHpxWE52ekpVWnJKbmZOakUvZldxSXNMTC9CVlBz?= =?utf-8?B?V2RCeGpPUk9ZWHdVVHVnelVsS3dZMnpjdVFVUmdUSWxQSDhFN0xsTiswM0px?= =?utf-8?Q?rambmAuSVM3zQegMzjQr18stEchJ5fDxu4DdcYw?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlUxYVRVN2RzcTA5cGJDQzVCZzFuVjZBOFlkY2FoV1Y3YitIZGJlYWpnQlYz?= =?utf-8?B?dVEwMjNaVHBHRTVBQ1hQZUlBZDh5ZmhCb2F3aHhlU1M3aDNZd0xjeHV0ckFV?= =?utf-8?B?NnVRRDdwVkt4NE81TitidlJUalhBYzNOZ1daa2JMbHNBNWtNNHVnR0FZVlhs?= =?utf-8?B?eVlMZGxtY21rVWh6MkQrZW5Fdm44NHhMeU9JSHJLMmdPOXBwQ0dKZnozb214?= =?utf-8?B?QVpncC9tMm5CWUpOL3dvdktYQTcveWxkMFJvd05EZVZwYmVMRWUzMlA3bGVn?= =?utf-8?B?Wmhtajgxa1VKS3h3dFFIaXZ1WDNOTDk0WGxNcWR1UUpMTUdMcEM1YWorWXZS?= =?utf-8?B?UUdrL2JLOU52THdhaG5adHlKWm81bXA0MFVOSDU3bTh0V2RUb0s5a3RlSG5i?= =?utf-8?B?Y1RLUmFPR2dTVVZnQ0dQc1czRDJ2Z1poK2VadHBEM2hTMVBPREdiamlOczJo?= =?utf-8?B?OFZOWkF1QVhTWEhrOVFzNGJNUGNvVGZHMTJxaWtWb1VLRlRna3cwUGlSRFVP?= =?utf-8?B?bW54TkYySW94V2JYT3ZzdW8vWkhrRExvNEN5VjRmdDFjUmdQd2wwdnI0V3Vn?= =?utf-8?B?M01taFBBNVlYdGd4T1pYUzNCdGFscEJOV084MmZSc2tjYWNKNXlBVXM2MHc0?= =?utf-8?B?bHowdGhYWDllNGdNR1RmaWtIRUROUmtZN1RZUisyMGVvT3puQTFwVkpnMkFm?= =?utf-8?B?aTRNTnBoZm16dms3a0QraVZpK0d1d1NFRGpxZEFNaFFlV2FwWFNTVGhXNG5s?= =?utf-8?B?SGc2UnNJM3p3T3IvdTRkMlB4UmRXdjI2cGdhdmYvSVFEbDhFSnNobTRzUnlK?= =?utf-8?B?RG9VeEZ1bFNTdkRGSUw4WC9NYmZaVUdTM3VScjRyU1dmTkRFazdpVWxVSTRK?= =?utf-8?B?YmZsQmNTbkdlOFB1UnhROVRWdU56aXBqSS9UWmtOckZ2dmVOaDVHMEdGMTBu?= =?utf-8?B?U01ZbXp3Zyt2dElUV3R1UkdYNk1BRGwwQjhBdHpMaDFzL0gxL0c0eWtPa211?= =?utf-8?B?K2t1ZFB5M1pUU3pINy80TnEwTzRjaGJYL1YyaDM5LzY2WUpTdHJuWkFrNHdG?= =?utf-8?B?ZzlrRWtlUFg4SSt0N1o1dHFIWTlka1podFhaNzQzMTRRQzAvSGNmcjM4V05M?= =?utf-8?B?U2FGZk9nU2RlRlI5UnA3L1BFdEpPSU9ML0lrTEJMa3ZPNXhlWm11WFRLeklQ?= =?utf-8?B?Z0JjaTk4SnhFcXhrWjBhSHhFeEovQXhpTDFaRkdtMWVDMzAxemNwYjl0ODdB?= =?utf-8?B?MXVHeDUvUHFaTytHdURLWDVXdXMwYTVTcFV5YVFOS1BQMHArMnhjbWdXZVQx?= =?utf-8?B?d1NQSnZSMXNqM0czNGhjSUFnc1NSa0VUODd5ZjBqVmgxWHZ3Y0cvWWlkdWdB?= =?utf-8?B?Mk9ldlVvanpvNktPNUxudEJZV2VlakZjdllMMndmdkwxbmJlVXVtTXhhQkJP?= =?utf-8?B?VHNpT1ZrR3M5YUZqZUdCUjkrenBUYkRUV1o0RGpmOThaNUdmVlg5VnhLdStt?= =?utf-8?B?L28vcDlBeGVTc2hzdEZ6MEhzcldia1dYbjBVV2lnRUZHWk9wOEF0OGE1SzRv?= =?utf-8?B?bER0UXIvK1IvbEJlcGluKzg3UGV3NzY2L2Y5M3dhZExUUUE4c05WSWJraWNK?= =?utf-8?B?bzhLNmJQRU9ub2ZnOUV6bHJpcFQybnNTMmwwZUs4WVRNV21WcnlKU1p3Zk1o?= =?utf-8?B?KzVmbkl3Rm8xNUR2Sm9FbmU4YXA1TFRDbC9CbjhGb3dhcjJKQ1NhbjVGZHZm?= =?utf-8?B?S3Y1SnREWmRBMVp1bTdCeDV3MlZzaUNnQ0JIdTBnRnRtVzhUekVyeHNVenph?= =?utf-8?B?dFpXM1Avb0tIU3RxSjlvN3B2MlFmR3JLN0U0M2xCRDQ0OE9NSXpTSkNYRjVz?= =?utf-8?B?RGlyN1BUYmxtZ3RnZ1JMazdCbTg3VmdOSE4zdTNMSkREa1dBeWtXUm8wVmVx?= =?utf-8?B?L0xoWXIwY2xid01hNWM4cGxSSkhzSm9TeWxkaDRSZEVFQ2hiK3UzblN5Njhz?= =?utf-8?B?b05rVS9tZWd6RHoxekh4dVpjQ2JzQ0hkSElQa0ZHT0FBbExmSStlOG9yV0dL?= =?utf-8?B?c2M2b0h0dWtWTGJJQ0ZWWnFNZk5QYVdsUkpDUzFlbk9iQUJYSDEvUEZlZW1q?= =?utf-8?Q?CGx8PQkcWbV8qzmIxfJvPWTIp?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0739791b-b983-4005-0b5e-08dd03735718 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 23:40:07.9786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OPG+bQhoeXTXpNQw9y4QkDxcpAeb1qCsYlzjOh5RMhF+lmwxR7IAQgV8tAMynpRC X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7935 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/12/2024 9:57 AM, Howard Wang wrote: > This patch is for phy configuration which contains phy power up/down, > phy config, ephy config and so on. > > Signed-off-by: Howard Wang > checkpatch warnings: CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone #407: FILE: drivers/net/r8169/r8169_phy.c:587: + if (hw->NotWrRamCodeToMicroP == TRUE) WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'? #677: FILE: drivers/net/r8169/r8169_phy.h:86: +#define ADVERTISE_PAUSE_ASYM 0x0800 /* Try for asymetric pause */