From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48ADDA00BE; Wed, 20 Apr 2022 14:38:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA1A040C35; Wed, 20 Apr 2022 14:38:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 44A11406A2 for ; Wed, 20 Apr 2022 14:38:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650458286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7trQ+R4q0cNfxLQlagVl/7pXHsh2IL+ZJFOlgQVQEA=; b=JvPq7o0NNE6FmfRl1yTEPI0T578F3iuK/oeGavYC1WsQ36mEUZTRDSoW2m+OrxRdcJe5NZ RH83/5+z1HK+qwWSLZ+qou5hlB2UCXaglVKvIcjXLYQEzDy2W1YeWhIxxlNvIfDPB1cyoY Q900OcMQAnbjMa6a9x1Zz0wLN1HxlLg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-370-oVt3ajgxNgGovWuWwywW-w-1; Wed, 20 Apr 2022 08:38:04 -0400 X-MC-Unique: oVt3ajgxNgGovWuWwywW-w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 004E0811E83; Wed, 20 Apr 2022 12:38:04 +0000 (UTC) Received: from [10.39.208.35] (unknown [10.39.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AEE0465197; Wed, 20 Apr 2022 12:37:57 +0000 (UTC) Message-ID: Date: Wed, 20 Apr 2022 14:37:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: Xueming Li , dev@dpdk.org Cc: Matan Azrad , Viacheslav Ovsiienko References: <20220224132820.1939650-1-xuemingl@nvidia.com> <20220224155101.1991626-1-xuemingl@nvidia.com> <20220224155101.1991626-4-xuemingl@nvidia.com> From: Maxime Coquelin Subject: Re: [PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown In-Reply-To: <20220224155101.1991626-4-xuemingl@nvidia.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/24/22 16:50, Xueming Li wrote: > When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread may suspends > still active and write notifier through kick socket. still be active > > PMD kick handler thread tries to install hw notifier through client > socket in such case will timeout and slow down device close. socket. In such case, it will > > This patch skips hw notifier install if VQ or device in middle of > shutdown. > > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c | 17 ++++++++++------- > drivers/vdpa/mlx5/mlx5_vdpa.h | 8 +++++++- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 12 +++++++++++- > 3 files changed, 28 insertions(+), 9 deletions(-) > Other than the commit messages comments: Reviewed-by: Maxime Coquelin If you are fine with my suggestions and no other revision needed, I can fixup while applying. Thanks, Maxime