From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array
Date: Mon, 21 Dec 2020 17:07:21 +0800 [thread overview]
Message-ID: <dd937157-b1f4-be98-bd93-ba001cc4babc@huawei.com> (raw)
In-Reply-To: <1608504422-29220-1-git-send-email-rahul.lakkireddy@chelsio.com>
在 2020/12/21 6:47, Rahul Lakkireddy 写道:
> From: Karra Satwik <kaara.satwik@chelsio.com>
>
> Start from index 0 when going through the FEC array. This will allow
> "off" to get printed for RTE_ETH_FEC_NOFEC mode.
>
> Fixes: b19da32e3151 ("app/testpmd: add FEC command")
> Cc: stable@dpdk.org
>
> Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 3f6c8642b..a6a5baa4e 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -3701,7 +3701,7 @@ show_fec_capability(unsigned int num, struct rte_eth_fec_capa *speed_fec_capa)
> printf("%s : ",
> rte_eth_link_speed_to_str(speed_fec_capa[i].speed));
>
> - for (j = RTE_ETH_FEC_AUTO; j < RTE_DIM(fec_mode_name); j++) {
> + for (j = 0; j < RTE_DIM(fec_mode_name); j++) {
As RTE_ETH_FEC_NOFEC is mode which every device has, so we think it
should not be regarged as "capabilities".
Thanks.
> if (RTE_ETH_FEC_MODE_TO_CAPA(j) &
> speed_fec_capa[i].capa)
> printf("%s ", fec_mode_name[j].name);
>
next prev parent reply other threads:[~2020-12-21 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 22:47 Rahul Lakkireddy
2020-12-20 22:47 ` [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps Rahul Lakkireddy
2020-12-23 6:02 ` Li, Xiaoyun
2020-12-23 12:25 ` [dpdk-dev] [PATCH v2] " Rahul Lakkireddy
2020-12-24 11:18 ` [dpdk-dev] [PATCH v3] " Rahul Lakkireddy
2020-12-25 1:06 ` Min Hu (Connor)
2021-01-15 15:27 ` Ferruh Yigit
2020-12-24 7:53 ` [dpdk-dev] [PATCH] " Min Hu (Connor)
2020-12-21 9:07 ` Min Hu (Connor) [this message]
2020-12-23 12:31 ` [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array Rahul Lakkireddy
2020-12-25 13:49 ` Rahul Lakkireddy
2020-12-23 6:07 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2021-01-15 13:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd937157-b1f4-be98-bd93-ba001cc4babc@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).