From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CACC04575E; Wed, 7 Aug 2024 17:39:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5D96402D3; Wed, 7 Aug 2024 17:39:49 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2044.outbound.protection.outlook.com [40.107.93.44]) by mails.dpdk.org (Postfix) with ESMTP id 8B7684028C for ; Wed, 7 Aug 2024 17:39:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q1Ka4xES6uaee1IzR+5L942lURyJuTMc6x85TWg/cMgBmhTJa6jriWLRI/EYTZX3/5R2dy6FfPXgCxTB8Hf/XWFL8rbf8Z2XHtkg/fMB0qTw8peCtUYKm0FsbT/fJDP6KqFSMhsiV10UHKS+UPfV/z6vL39fZvjG7aZ1jW4C1sPfbI7OPdkCPQ/QudBEZW6NwNSYT4JUMWjHjvzaqNOISU35gS6bc0hT718DlCPAq2BEJKX6hoWb0h0gEyW3OBlBPdZ8UF5kejxoNAdMk4NYJRYyWqMKMpvDhqmV1tMaoVC4hmvm69k9Q4jX8G6tUY/gd/qb1LqUGE+hrGbe4OSFvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fdaGKKSTwZYLA0d9MOk6mc0FAHcFwbEKqA+U1hTpEic=; b=phupbD5nCZwpw0tACFqB81wfqqYueq1+MZ0QTGEpJCKgNdkUnMHCK0DHXlcHoQ3T4NdHhHghrAekq7rFAdYZoxL0DfOSfG4SM+6hMIf81U90pcl64LlTF0Mbot6o0rhHqHZmNmGiCneTA4O0WAmfxiQQ08RFTCvlrfeiqqeGYuZWgkbd4xzztLOQF6pEuzEgrg6sDyQmmmdXfiEZaIIx+ED+7+1jUDuvr7iByFYKN65XA6Xhwvqdh9STkqYJmuJEHUbumtfgFSiPqlMihcoSv79aIESPu4o8KrxQB1eEUPRF+7sWPab+VSRsdSszUy4tuRaruXaet+PgyTnvyVJaTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fdaGKKSTwZYLA0d9MOk6mc0FAHcFwbEKqA+U1hTpEic=; b=w/XWVxSxzVPROMZD7n/lzyrH0SpG3CUbFC0AQ039CUppfXsQFKxvWJ0Q8l22wfAqfpbBXb0ZBp2Mrj3ptIrYWt+YgAdsO5v84TjpPQPPWWZUnYL8Mksm+6YVlvQxtVtpSSqf27AqQy+HuhDroxkMi9TtP9/FVuWi8vn8K46gm1w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7344.namprd12.prod.outlook.com (2603:10b6:806:2b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.23; Wed, 7 Aug 2024 15:39:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7849.008; Wed, 7 Aug 2024 15:39:45 +0000 Message-ID: Date: Wed, 7 Aug 2024 16:39:41 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/17] net/dpaa: enhance DPAA frame display To: Hemant Agrawal , dev@dpdk.org Cc: Jun Yang References: <20240801105313.630280-1-hemant.agrawal@nxp.com> <20240801105313.630280-12-hemant.agrawal@nxp.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240801105313.630280-12-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0201.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7344:EE_ X-MS-Office365-Filtering-Correlation-Id: d874af3e-9324-47a2-6e0c-08dcb6f729dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cFVhYjNiTDh2SDUwbmgvWkMrZ1Jya0JvMEswcmwvN2ZQNXdRS3lQR1lkNGQ0?= =?utf-8?B?cEk4dWw2MVZXRGFRS041R1EyUndEMHVwdmFiNVBLOGJMRlF2UXhUYytJTTBE?= =?utf-8?B?eXY1N04xTzVSOFoyS3FOd25hdVBWZ0U3V3luS2Q1RmFlMHpzUXJham1aTEY0?= =?utf-8?B?aGxHWHliZmgzTnVMME92QlZwZTB0RzM2eU8vZWwvRlNuWVhCTmZjZTYyMzVS?= =?utf-8?B?K0lrZDluVDB1UVovRHdlRlladUoxODlYTDhGWlBLamhCYWZiRE5HdnFMR20x?= =?utf-8?B?a2NSdHVGd1o1NHZBSHJ3dVZONk9zVmN0L24zRElod3VQRzFqZzBVL2tnQm9x?= =?utf-8?B?V2NJa1ZmYmcwZVdjK0dFeFFKamp4cGFRVnJCODhJR2FoM0RZMW04V2N2SVFZ?= =?utf-8?B?RGhldHFQRHpxa2haU04raEhFQ1hadVhlTGQrdUUwbDgvM3ZEM1JtUiswaW5o?= =?utf-8?B?TW1Xdy9jVEZNVjJiMHpJNmRRcVBaOE1QVzhZTU5hWHNFQVRDdWRLNGtjUXk2?= =?utf-8?B?ZkRxdWJiMENjSmFMeXJxUFBQQnQ4TG80cEJnSWI3dmFDU2lNdXE4MEtMMng4?= =?utf-8?B?dHRaQ1JqYWh2OEtFQmtWanNTeUpTeDFSanJhbFdwQlE5aE5aci82eHUvQnRN?= =?utf-8?B?YW5YaEdscnQxQXVFZWdQNkplMlVoQmJ4Ujk1SmRaTWhMdHJVZzdXSVROVHM5?= =?utf-8?B?dzB1cHp5VkNoU2FVYURMTTMzSHdKOGN1bFJKSUVjOXR2MFJSWHhIN3JpeUgx?= =?utf-8?B?N2h6bGFicGxqYmk1VytZVnpNRXphRHpYUzFYTXlLdXJDUzk0UzdBT0FWZ3U4?= =?utf-8?B?eFFuMjBQSGhBT1pib1BSYXpjTnNIYmQzSGYzTy8rZFR1QUpsMUJYajRpYTRx?= =?utf-8?B?TGR5MXBjLytRSSs0N2pGMitmems1V1dSaUM0VG1YZWIrcXNqMHVRa05nSHNi?= =?utf-8?B?V3dmelRjL28zYysyMUVxTXlkZm5xSTFkdzhSNmxlN2lYaGVNR3dsdnBVUVBQ?= =?utf-8?B?Zkc3c1krMzZEUjBIYUUyQ082ZFpsd1M0OXFkYlg3OEpjTHZ0M3BadVlKWlNG?= =?utf-8?B?YVVSVzJ1cmpJdjlWVFV6T1o1ZS9OVkpmWExlTzBMY0I3ckhJTG1jZ01yalV5?= =?utf-8?B?OEZ5QkR3K2FnTDUrWnBqb0QrdTRjRXVUaTN5Nm5TR1ZJZWF1ZDdyaGxFdmpG?= =?utf-8?B?RXk2ai9FRjU1YnNYd0VVVjZ6Q1VsdllYN2JVaFhrRk5EZ25WTmM0b3JqY0ZC?= =?utf-8?B?QmI3M2RvODVnQU1BOUFXY1VlMGI2dDRmUzZpRDRZWjV1YTJEbEgwTm40eUVL?= =?utf-8?B?RUEyaHdtNGpnVUxhV2xqMEdmUytXRVBIL1V1aTdqY1hMYkhmRytxOXgxVHY1?= =?utf-8?B?VUZwSEZjNWh6YVZRcWNHMUx0Vi9iR253VVNtS2hvaDVnWFoxbXhpVDFtTzFs?= =?utf-8?B?R3hNUGR3S3ZkNTlQU0F2QVpTcStNdzlOWDY1dE5uejJFejJXN3dKcHdHUHk3?= =?utf-8?B?R0ZmL0VCZlJkVktKaytzR3hWbVFQZDdtZE5aV21uN0I0cExObkF6alpIT2lk?= =?utf-8?B?bmRPZFBHeTc1U1ovZlNwdlU1SHF3T3orUExtQjdZNTgveXVQWWJ1dkFDUnhL?= =?utf-8?B?cUt1dXp0MzliMWdyNWM3UXRVRkFNQ0x4RGlsVmljUHN6KzhRVFBnMlY0djJr?= =?utf-8?B?b3dzaWlBcHdzRVNQVzM3OXZEMEFHWWlIeXlSVk1NSlo5MS9xanFiOFhaRkox?= =?utf-8?B?MkNyeHF1UDBxMHhnUTlmSVFDRnlDc1UydzlTQjFMRjBiTlRMRWorUUtPekRt?= =?utf-8?B?aGtMMDNTdDZIbCs1cWNTdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWtBYitCOHlkZlVZczBBRTdoRGVvOVdxcVJKUXZPM1BaOTgyRkVTVU1selFx?= =?utf-8?B?TXRuY2MvemF2emNjWmhnV2hIaWlHL0dOSWZGdTJSelQ5MDJUUlIrL1lKTk13?= =?utf-8?B?MWNTRUhtOG1uZnl3dlNtbVVwMnhJTmRqYTV0czlHMktlT1I3Z3JCaFJMdmdp?= =?utf-8?B?SGlSakY1R2NhWlYxVzFPOURiaWF2TXM5cVRvN2IyQWxPaEpvWkxiNFpKbVBL?= =?utf-8?B?eVlKSEpuZSt2YUFrbjd4RWMxcGpnbUhIY2xoTnE2b0dwYU9JazBQT0Vpd0xW?= =?utf-8?B?ZVJYTGN4cW1TcE5sNGJHVUZmMG9Ib2gycVkweUVtSDZPNEcwb2RZcXBKZHpv?= =?utf-8?B?dDhHQUE0aGUwV2FGdklJZW5QaTRSV3FyWkhpbWl1Q1JmMXdVVzJmSlprU09p?= =?utf-8?B?anV2T1d1ZGJwVEMwOXE1d2E1R1JsSFRkM0JFZVVzTTh1VitKODFOeWxBV2Jo?= =?utf-8?B?cERHTzlZUXYrNFdiaDV1VytsNjBaWWV2YzRqOThrVzQzRW4xMmFuUjBkMHky?= =?utf-8?B?aVRscEh0bUJ5Wnd2N3ZsUndhNUVSZUF2RGZpNC9JQWtQdmd1bWFSeEpnKytH?= =?utf-8?B?cUVuTHE4ZktwR1c1d2prSVZTR3RaZzA1cnZWRTVWbE5iV083UlZCczBzQ3h0?= =?utf-8?B?UU02cWtlVTZxK0d3R1BTc1pObmhuRjBDSnMzaDQrSlZKaDF3ZXdES0FNZ3lD?= =?utf-8?B?RGVuNkc0djZpaDJHZ1VmaXd6dWN0YnlUODRNU3RSVENiTHJzTzliMlM0Mncx?= =?utf-8?B?YXlIcVpoRk0xOGkzZFRmeTFSTzhBOUh3S3JwbmZodHRVSU4zTE8yZ1lkbGt1?= =?utf-8?B?VVhua2lxVnRGUS80L1VPUlRIM04wNWQ0V3BLS09KcDAvVnA0Vm01L095cG9u?= =?utf-8?B?VUx1UElGdnhPY1ZCVWR5ay8vY1RBcUNLZVE4U1lBN093TVVSZG9qZWh6dTND?= =?utf-8?B?RmtFeDVXekVuUmFwRWZUcFF5TzAxRHV6dmVQOGNkMjVHSEdZNjlnVmNKdXhv?= =?utf-8?B?SXBNVlV0VzltNE1YTW1MTE5GVjJnY1BMS0ZNaUpBZ0lkdjVsbDhzNTRJaFBD?= =?utf-8?B?bWF2NkpBL0dnWnM4aGN5bHM1VzJoTGxNcHNzYWdPWjdhNFpsdnhRNjMxdlJL?= =?utf-8?B?VndiRVFHQjVoOUpLZTZLcXBWTi9pV3lnemtyakVTUDVISkVZMnA0S1FDM1do?= =?utf-8?B?TkFmQ1RlTFgvWHB1K2xOZlExTEtkSXhzZzdySGEvbTI0aThReG4wa0lEU0Nk?= =?utf-8?B?OUNBM0RMNWFtWkdVRWwyY1ZEU0JhdkUyeEVxaHU4dGR5Yy9HSTN2cnlZS1RC?= =?utf-8?B?YTNUL0RIak5QdW0yZ1lhaTFjeVE1cGQ1cTErMkh1bUUwNVRRSG1iSGdtYnN4?= =?utf-8?B?RHViWlZOTnYvQm9qTzFPS2F3aWFCNDFpM0hIT2ZYd0p4c1RDUzg1dWdmZzZa?= =?utf-8?B?QzM1RUJsdko0Y0kvaDRpZHQvTnBLTXBvSCtJMlEzZTJMdkRhM1d3WUNKS2ZM?= =?utf-8?B?akNqd21OekVyZk9YNUtEZHg0Q093ZVJqZ0Y3YUVIZTBQTU5mSUUxN3lwem41?= =?utf-8?B?eVhoWjdDajBkMnlYZnh3L3czb1JIeHRIY0ovT2s0cGdScnQzYmx3M3R5dXhP?= =?utf-8?B?NTJGM3A5T2JXdTdUVkxBdGd3a1QxWEJNalZ1Zk1ld3JtQWlYY09GbXZsUWpU?= =?utf-8?B?TnRvV3ZrV1VoSkhZR3dKTE5kRHdvSHgwQ290Ujg4ZGpZUHhBNGpDVmdvSzdu?= =?utf-8?B?M01VQkhKKzRoY3VmMVUrdlgvNm9mSlRjZm5BajZTbnc2M25KeVdBaDNocHZq?= =?utf-8?B?dlp1SjNCYmJCMmx2OWN6YmVXVHdORm5EV0FhLzBTK202T0x0MmtYK242aXBp?= =?utf-8?B?T2U0ZzBaWmt2RGRleC9NK1VxcnNFODdDcmJuSHJCaE5oUEpQRVNQVUFxU0la?= =?utf-8?B?M1F0TzNHWnBvUE5NbkhVdVMraU5hUWN1SEhBSENPTG41ZlMvVTVvWUFZdmhV?= =?utf-8?B?KzNwOSs3R2Nqdjg2eHdyeWduaHNNbnlNWWpBV1BqVFRBRlUzbDlQeUtxc1c0?= =?utf-8?B?ZmlFUG9pUk55T2c0MWlabzJBZEtveUZxbXlNYUJWUVF6anpMNXpHcklDa0VB?= =?utf-8?Q?JMf3vyssLY6NSy2oOKUStidfI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d874af3e-9324-47a2-6e0c-08dcb6f729dc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 15:39:45.7020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HzJlKXuEz9Z+HQpHaWiVRf3Q257xTnNUp4UvVrykHFGG9oZX0R4x7zCFApwpdMYD X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7344 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > This patch enhances the received packet debugging capability. > This help displaying the full packet parsing output. > > Signed-off-by: Jun Yang > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/dpaa.rst | 5 ++ > drivers/net/dpaa/dpaa_ethdev.c | 6 ++ > drivers/net/dpaa/dpaa_rxtx.c | 138 +++++++++++++++++++++++++++------ > drivers/net/dpaa/dpaa_rxtx.h | 5 ++ > 4 files changed, 130 insertions(+), 24 deletions(-) > > diff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rst > index 580edd9327..448607e9ac 100644 > --- a/doc/guides/nics/dpaa.rst > +++ b/doc/guides/nics/dpaa.rst > @@ -227,6 +227,11 @@ state during application initialization: > application want to use eventdev with DPAA device. > Currently these queues are not used for LS1023/LS1043 platform by default. > > +- ``DPAA_DISPLAY_FRAME_AND_PARSER_RESULT`` (default 0) > + > + This defines the debug flag, whether to dump the detailed frame and packet > + parsing result for the incoming packets. > + > If this is for debug, why not implement it as devarg. Environment variables are supported by a few drivers, and as DPDK drivers are userspace applications we can benefit from them, true. But that is yet another way for configuration, I am feeling it is more suitable way of configuration for applications. For drivers we already have a devarg way, sticking to same configuration way provides more consistency for users. > > Driver compilation and testing > ------------------------------ > diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c > index e92f1c25b2..979220a700 100644 > --- a/drivers/net/dpaa/dpaa_ethdev.c > +++ b/drivers/net/dpaa/dpaa_ethdev.c > @@ -2094,6 +2094,12 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) > td_tx_threshold = CGR_RX_PERFQ_THRESH; > } > > +#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER > + penv = getenv("DPAA_DISPLAY_FRAME_AND_PARSER_RESULT"); > + if (penv) > + dpaa_force_display_frame_set(atoi(penv)); > +#endif > 'penv' is not defined and build fails when macro enabled. It seems even yourself not testing with the macro, this is why using compile time macros is bad for long term, it is hard to detect when they are broken. Can't you convert this macro to some runtime configuration, that is enabled/disable via devargs, so easier to test, ensuring it is not broken. Or other option can be to switch ETHDEV debug macro, which is used more, by multiple cases, so more likely to be tested better. <...>