From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66AF3A0561; Fri, 5 Mar 2021 01:31:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E27024069F; Fri, 5 Mar 2021 01:31:03 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4F30840692 for ; Fri, 5 Mar 2021 01:31:01 +0100 (CET) IronPort-SDR: aYCBAH4V1cnQ9SCZmkrYDA544UJHjj0vFuDT6RyRTVin+OiPCLnNYNyIBEPBWN2x3bXOr/Hgn4 9OuQ5kPtKXrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9913"; a="248925644" X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="248925644" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 16:31:01 -0800 IronPort-SDR: ooux+y0JbiXv4zxZ0MEDFt9XKWPU+nhfdR/u7F0QJOYnmU60N9ZrXgxr5Uajo+nDkFW/iwMhr9 WXgFUA4FWWYQ== X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="368379890" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.212.162.83]) ([10.212.162.83]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 16:31:00 -0800 To: Dmitry Kozlyuk Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com References: <20210303215929.5616-1-pallavi.kadam@intel.com> <20210303215929.5616-4-pallavi.kadam@intel.com> <20210304021211.2dbac1a9@sovereign> From: "Kadam, Pallavi" Message-ID: Date: Thu, 4 Mar 2021 16:31:00 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210304021211.2dbac1a9@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, On 3/3/2021 3:12 PM, Dmitry Kozlyuk wrote: > 2021-03-03 13:59, Pallavi Kadam: >> Disable loading of private DDP packages in ice PMD on Windows. >> >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Ranjit Menon >> --- >> drivers/net/ice/ice_ethdev.c | 6 ++++++ >> 1 file changed, 6 insertions(+) > Are DDP packages unavailable on Windows or is their loading disabled because > reading from PCI config space is not implemented by netuio? In the former > case, please document the reason in commit (and probably in used guide?). > In the latter case, could you instead fix rte_pci_config_read() to return (-1) > on Windows, so that DDP loading automatically fails at reading capabilities? > This would ensure ICE PMD remains portable by compiling all of its code in > every platform. Yes, loading of external DDP package is not supported on Windows. Will update the commit message and the ice user guide accordingly in v2.