From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CE6D3271; Thu, 29 Jun 2017 09:37:38 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E3F50C04B333; Thu, 29 Jun 2017 07:37:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E3F50C04B333 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E3F50C04B333 Received: from [10.36.112.58] (ovpn-112-58.ams2.redhat.com [10.36.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 44EFF867EA; Thu, 29 Jun 2017 07:37:36 +0000 (UTC) From: Maxime Coquelin To: Ivan Dyukov , yliu@fridaylinux.org, dev@dpdk.org Cc: i.maximets@samsung.com, heetae82.ahn@samsung.com, stable@dpdk.org References: <1498653631-15307-1-git-send-email-i.dyukov@samsung.com> <3b44a715-612d-2ef7-aac2-15f74ac4aa07@redhat.com> Message-ID: Date: Thu, 29 Jun 2017 09:37:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 29 Jun 2017 07:37:38 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix checking of device features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 07:37:39 -0000 On 06/29/2017 09:21 AM, Maxime Coquelin wrote: > > > On 06/29/2017 08:07 AM, Ivan Dyukov wrote: >> On 06/28/2017 03:54 PM, Maxime Coquelin wrote: >>> >>> >>> On 06/28/2017 02:40 PM, Ivan Dyukov wrote: >>>> To compare enabled features in current device we must use bit >>>> mask instead of bit position. >>>> >>>> CC: stable@dpdk.org >>>> Fixes: c843af3aa13e ("vhost: access header only") >>>> >>>> Signed-off-by: Ivan Dyukov >>>> --- >>>> lib/librte_vhost/virtio_net.c | 8 +++++--- >>>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> Thanks for the fix Ivan, and sorry for introducing this bug. >>> Out of curiosity, did you noticed it because it broke offloading, >>> or just by code review? >> I didn't see any breakages. It's just code review. > > Ok, thanks. FYI, I just found another case in vhost.c, sending patch soon. Cheers, Maxime