From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0+QXf0=LK=ericsson.com=mattias.ronnblom@lysator.liu.se>
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by dpdk.org (Postfix) with ESMTP id 47ECD1D8A
 for <dev@dpdk.org>; Mon, 27 Aug 2018 11:24:03 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id AF8E740030
 for <dev@dpdk.org>; Mon, 27 Aug 2018 11:24:02 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 9BBF54002C; Mon, 27 Aug 2018 11:24:02 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 bernadotte.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-0.4 required=5.0 tests=ALL_TRUSTED,AWL
 autolearn=disabled version=3.4.1
X-Spam-Score: -0.4
Received: from [192.168.1.122] (host-90-232-97-171.mobileonline.telia.com
 [90.232.97.171])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id 9551440021;
 Mon, 27 Aug 2018 11:24:01 +0200 (CEST)
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
References: <20180711210844.5467-1-mattias.ronnblom@ericsson.com>
 <20180711210844.5467-2-mattias.ronnblom@ericsson.com>
 <20180722113254.GA30026@jerin>
From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>
Message-ID: <de18c3ec-7a33-71d8-3e9c-71d3e2337317@ericsson.com>
Date: Mon, 27 Aug 2018 11:23:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180722113254.GA30026@jerin>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP
Subject: Re: [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW)
 event device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Aug 2018 09:24:03 -0000

On 2018-07-22 13:32, Jerin Jacob wrote:

>> +static void
>> +dsw_stop(struct rte_eventdev *dev __rte_unused)
>> +{
> 
> You may implement, eventdev_stop_flush_t callback to free up the
> outstanding events in the eventdev.
> 

Is this support mandatory, or is it OK to leave it to the user to empty 
the machinery before calling stop in the initial driver version?

I can't find any other event device supporting the callback.

In DSW, the events can be a little here-and-there - in the output 
buffers, in the pause buffer, and on the input rings.

That said, assuming the worker lcore threads have stopped using the 
device and issued the appropriate barriers, it should be possible to 
round up the events from the thread running 'rte_event_dev_stop'.