From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0253A0562; Sun, 18 Apr 2021 00:21:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81E9F161B2C; Sun, 18 Apr 2021 00:21:26 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8F9CD40682 for ; Sun, 18 Apr 2021 00:21:24 +0200 (CEST) IronPort-SDR: O5ced/h/qxGE7q3AIknRPFLtlTdJmiaKhQhflcat/VwUy9ptarnl5ycBARGzGap8K1WLXLcsB2 Yap0DzcrVGAA== X-IronPort-AV: E=McAfee;i="6200,9189,9957"; a="280511974" X-IronPort-AV: E=Sophos;i="5.82,230,1613462400"; d="scan'208";a="280511974" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2021 15:21:21 -0700 IronPort-SDR: a0s9+s5eEGaEgmmUtRcMd1YoBg/4y5LOKLG+/BiRqUaQJtYE+eneQ6eFII8goaoXlVwy2cq9k3 5aPMCZfsVfQA== X-IronPort-AV: E=Sophos;i="5.82,230,1613462400"; d="scan'208";a="426029862" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.206.177]) ([10.213.206.177]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2021 15:21:20 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: anatoly.burakov@intel.com, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net, xiaoyun.li@intel.com References: <1614906276-34293-1-git-send-email-oulijun@huawei.com> <1618639954-31365-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Sat, 17 Apr 2021 23:21:16 +0100 MIME-Version: 1.0 In-Reply-To: <1618639954-31365-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v10] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/17/2021 7:12 AM, Min Hu (Connor) wrote: > This patch adds multi-process support for testpmd. > The test cmd example as follows: > the primary cmd: > ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ > --rxq=4 --txq=4 --num-procs=2 --proc-id=0 > > the secondary cmd: > ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ > --rxq=4 --txq=4 --num-procs=2 --proc-id=1 > > Signed-off-by: Min Hu (Connor) > Signed-off-by: Lijun Ou > Acked-by: Xiaoyun Li > Acked-by: Ajit Khaparde Hi Connor, I put some minor syntax comments, when they are fixed, Reviewed-by: Ferruh Yigit <...> > if (diag != 0) { > - if (rte_atomic16_cmpset(&(port->port_status), > - RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0) > - printf("Port %d can not be set back " > - "to stopped\n", pi); > - printf("Fail to configure port %d\n", pi); > + if (rte_atomic16_cmpset( > + &(port->port_status), > + RTE_PORT_HANDLING, > + RTE_PORT_STOPPED) == 0) > + printf("Port %d can not be set " > + "back to stopped\n", pi); It is OK to have long line for the strings, so it can be like printf("Port %d can not be set back to stopped\n", pi); > + printf("Fail to configure port %d\n", > + pi); No need to update this line. <...> > /* Fail to setup rx queue, return */ > if (rte_atomic16_cmpset(&(port->port_status), > - RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0) > + RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0) > printf("Port %d can not be set back to " > - "stopped\n", pi); > + "stopped\n", > + pi); These are syntax changes, I think can keep these lines as it is.