From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D83C346F00; Mon, 15 Sep 2025 17:22:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7065A4066A; Mon, 15 Sep 2025 17:22:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BD068402E3 for ; Mon, 15 Sep 2025 17:22:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757949760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7rWmCnkvrhYgsmpm0NwG04ti65+z7nDdRO5Smr0w7kM=; b=JZIEaie1jNrWqWqjbXFddRnGb1U7zDHKP2EOT07hD08t5N0A5XogYntilbKsqUC+Jtbux3 S7vg8hifunNfQi8ZuUtioScmDFeMuPS+YEhpQ0QKyczV4IelPsHyHycGNnQ74aL3dUkEnF EgRuvZCVOmEyzn8usUhKmMLVjVKF4aQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-j3pW00BONKWYFW_8X1VxPA-1; Mon, 15 Sep 2025 11:22:37 -0400 X-MC-Unique: j3pW00BONKWYFW_8X1VxPA-1 X-Mimecast-MFC-AGG-ID: j3pW00BONKWYFW_8X1VxPA_1757949755 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 481411800562; Mon, 15 Sep 2025 15:22:35 +0000 (UTC) Received: from [10.45.242.14] (unknown [10.45.242.14]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3917E30002D0; Mon, 15 Sep 2025 15:22:31 +0000 (UTC) Message-ID: Date: Mon, 15 Sep 2025 17:22:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] vhost_user: configure memory slots To: "Bathija, Pravin" , Bruce Richardson , David Marchand , Chenbo Xia Cc: "dev@dpdk.org" , "pravin.m.bathija.dev@gmail.com" , Thomas Monjalon References: <20250812023358.2400020-1-pravin.bathija@dell.com> <15537925.JCcGWNJJiE@thomas> <8391ac53-0b5c-468c-ae38-341842f5c492@redhat.com> <51a55a38-3ca6-4a68-9869-478a2fa8e500@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Zg-CVoxLm0Vm5MQoE-Wd6IgyQDCcP8-2SVIFDxByD9o_1757949755 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pravin, On 9/12/25 12:07 AM, Bathija, Pravin wrote: > Dear Maxime, > > As suggested, apart from the storage networking spdk tests, I have successfully run the following additional tests with dpdk applied with my patch: > 1) Bring up dpdk-test-pmd vhost back-end and dpdk-test-pmd virtio front-end and send network traffic back and forth > 2) Bring up dpdk-test-pmd vhost back-end and qemu running Alpine Linux connecting to dpdk vhost, sending network traffic back and forth > > Please let me know if I need to run additional tests. Also I'm happy to share the test commands and logs if needed. I think this is a good start. I expect some issues if you enable vIOMMU. By the way, have you noticed my review on patch 3? I expected a new revision with requested changes to be done, or at least explaining why they are not necessary. Thanks, Maxime > Thanks, > Pravin > > > Internal Use - Confidential >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Friday, August 29, 2025 5:01 AM >> To: Bathija, Pravin ; Bruce Richardson >> ; David Marchand >> ; Chenbo Xia >> Cc: dev@dpdk.org; pravin.m.bathija.dev@gmail.com; Thomas Monjalon >> >> Subject: Re: [PATCH 0/3] vhost_user: configure memory slots >> >> >> [EXTERNAL EMAIL] >> >> >> >> On 8/29/25 12:26 PM, Bathija, Pravin wrote: >>> Answers inline. >>> >>> >>> Internal Use - Confidential >>>> -----Original Message----- >>>> From: Maxime Coquelin >>>> Sent: Friday, August 29, 2025 2:18 AM >>>> To: Bathija, Pravin ; Bruce Richardson >>>> ; David Marchand >>>> ; Chenbo Xia >>>> Cc: dev@dpdk.org; pravin.m.bathija.dev@gmail.com; Thomas Monjalon >>>> >>>> Subject: Re: [PATCH 0/3] vhost_user: configure memory slots >>>> >>>> >>>> [EXTERNAL EMAIL] >>>> >>>> Hi Pravin, >>>> >>>> On 8/29/25 11:11 AM, Bathija, Pravin wrote: >>>>> Dear Maxime, Bruce, David, Chenbo, >>>>> >>>>> Could you please help review the code ? The goal is to merge the >>>>> changes >>>> before September 18 when the merge window closes for SPDK v25.09. >>>> >>>> I will help review the code, but there are no guarantee it will be >>>> merged in main branch before September 18th. >>> Thank you for your consideration. >>> >>>> >>>> Can you elaborate about the tests you have run? >>> - Run I/O tests using fio and libblkio engine to SPDK vhost user block >>> targets with multiple targets and different block sizes >>> - Custom system tests defined within SPDK framework >>> https://urldefense.com/v3/__https://review.spdk.io/c/spdk/spdk/*/26395 >>> >> __;Kw!!LpKI!nQ_7qq10Gy3KLQB0sGNsLi15QuRrmxDpIq6do36yuGMxY3T1iXey >> U6wQer >>> Zs7xZbVMtiozXTR7XAwqUJOi3Mf9hsM-gghA$ [review[.]spdk[.]io] >>> - QEMU bring up with SPDK Virtio block device >>> >>>> Have you ensured it is still working properly with Vhsot-user/Virtio-net? >>> Yes tests have been run to ensure this as listed above >> >> You have only run storage tests, not networking test. >> So the DPDK Vhost datapath has not been exercised, neither the IOMMU >> AFAICT. >> >> Maxime >> >>> >>>> >>>> Maxime >>>> >>>>> Regards, >>>>> Pravin >>>>> >>>>> >>>>> Internal Use - Confidential >>>>>> -----Original Message----- >>>>>> From: Bathija, Pravin >>>>>> Sent: Tuesday, August 26, 2025 11:47 AM >>>>>> To: Maxime Coquelin ; Bruce Richardson >>>>>> ; David Marchand >>>>>> ; Chenbo Xia >>>>>> Cc: dev@dpdk.org; pravin.m.bathija.dev@gmail.com; Thomas Monjalon >>>>>> >>>>>> Subject: RE: [PATCH 0/3] vhost_user: configure memory slots >>>>>> >>>>>> Answers inline. >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Maxime Coquelin >>>>>>> Sent: Monday, August 25, 2025 1:49 AM >>>>>>> To: Bathija, Pravin ; Bruce Richardson >>>>>>> ; David Marchand >>>>>>> ; Chenbo Xia >>>>>>> Cc: dev@dpdk.org; pravin.m.bathija.dev@gmail.com; Thomas Monjalon >>>>>>> >>>>>>> Subject: Re: [PATCH 0/3] vhost_user: configure memory slots >>>>>>> >>>>>>> >>>>>>> [EXTERNAL EMAIL] >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please try to fix your email client so that we can follow the replies >> inlined. >>>>>> >>>>>> Thank you for the input. I have made the necessary adjustments. >>>>>> Please let me know if there is anything missing. >>>>>> >>>>>>> >>>>>>> On 8/22/25 9:33 AM, Bathija, Pravin wrote: >>>>>>>> Dear Maxime, Bruce, David, Chenbo, >>>>>>>> >>>>>>>> I would like to follow up on the status of the patches and when >>>>>>>> we should >>>>>>> expect these to be merged into the mainline. >>>>>>>> >>>>>>>> Please let me know if I can help answer any questions you might have. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Pravin >>>>>>>> >>>>>>>> >>>>>>>> Internal Use - Confidential >>>>>>>> -----Original Message----- >>>>>>>> From: Bathija, Pravin >>>>>>>> Sent: Thursday, August 21, 2025 7:48 PM >>>>>>>> To: Thomas Monjalon >>>>>>>> Cc: dev@dpdk.org; pravin.m.bathija.dev@gmail.com; Maxime >> Coquelin >>>>>>>> ; Chenbo Xia ; >>>>>> David >>>>>>>> Marchand ; Bruce Richardson >>>>>>>> >>>>>>>> Subject: RE: [PATCH 0/3] vhost_user: configure memory slots >>>>>>>> >>>>>>>> Comments inline: >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Thomas Monjalon >>>>>>>> Sent: Tuesday, August 19, 2025 4:36 AM >>>>>>>> To: Bathija, Pravin >>>>>>>> Cc: dev@dpdk.org; pravin.m.bathija.dev@gmail.com; Maxime >> Coquelin >>>>>>>> ; Chenbo Xia ; >>>>>> David >>>>>>>> Marchand ; Bruce Richardson >>>>>>>> >>>>>>>> Subject: Re: [PATCH 0/3] vhost_user: configure memory slots >>>>>>>> >>>>>>>> >>>>>>>> [EXTERNAL EMAIL] >>>>>>>> >>>>>>>> Comments inline >>>>>>>> >>>>>>>> 12/08/2025 04:33, Pravin M Bathija: >>>>>>>>> - add protocol feature support add and removal of memory >>>>>>>>> regions/slots dynamically. >>>>>>>>> - this patch set has been tested with multiple instances of fio >>>>>>>> >>>>>>>> What is "fio"? >>>>>>>> Fio is an open-source tool to test I/O workloads on disks and file >> systems. >>>>>>>> >>>>>>>>> connected via libblkio to spdk target backed unix domain socket. >>>>>>>>> - please apply this this patch-set to dpdk mainline as well as >>>>>>>>> version 25.03.0. >>>>>>>> >>>>>>>> As mentionned previously, we don't plan to maintain 25.03. >>>>>>>> I understand you need it for SPDK, but I think SPDK should rely >>>>>>>> only on LTS branches. >>>>>>>> Is there a specific reason why 25.03 is required in SPDK? >>>>>>>> >>>>>>>> When we do sub-module init on spdk master, it uses dpdk version >>>>>>>> 25.03 from >>>>>>> it's own sub-repo. >>>>>>>> Our changes for vhost have already been pushed to spdk master. We >>>>>>>> have also pushed the same dpdk changes in the spdk sub-repo "dpdk" >>>>>>>> which is version 25.03. I was just ensuring that there is >>>>>>>> uniformity in the 25.03 >>>>>>> codebase, whether it is on the spdk sub-repo or 25.03 within dpdk repo. >>>>>>> >>>>>>> Ok, still, it would be better for SPDK to uses LTS as we have no >>>>>>> plans to add extra stable branches. >>>>>>> >>>>>>> Also, your series may be considered as a feature and not a bug >>>>>>> fix, so even if >>>>>>> 25.03 would be a stable branch (which it is not), it would not be >>>>>>> backported against it. >>>>>> >>>>>> Understood. I would request that we merge my changes into DPDK >>>>>> mainline before September 18 when the merge window closes for SPDK >>>> v25.09. >>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> v2: >>>>>>>>> - fixed warnings with e-mail address >>>>>>>>> - fixed warnings with typos >>>>>>>>> - there is a warning about __rte_packed_begin not being in pair >>>>>>>>> with __rte_packed_end which on reading the code turns out to be >>>>>>>>> false. It is an anomaly of how git-format generates the patch >>>>>>>>> and how check-patch checks it. >>>>>>>> >>>>>>>> When sending a v2, please use -v2 so it is reflected in the email subject. >>>>>>>> I will remember this for next time. Thank you for pointing that out. >>>>>>>> >>>>>>>>> Pravin M Bathija (3): >>>>>>>>> mailmap: add user >>>>>>>>> vhost_user: configure memory slots >>>>>>>>> vhost_user: support for memory regions >>>>>>>>> >>>>>>>>> .mailmap | 1 + >>>>>>>>> lib/vhost/rte_vhost.h | 4 + >>>>>>>>> lib/vhost/vhost_user.c | 325 >>>>>>>>> +++++++++++++++++++++++++++++++++++------ >>>>>>>>> lib/vhost/vhost_user.h | 10 ++ >>>>>>>>> 4 files changed, 296 insertions(+), 44 deletions(-) >>>>>>>> >>>>>>>> >>>>>>>> >>>>> >>> >