From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 193311C252 for ; Fri, 13 Apr 2018 15:38:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 06:38:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,445,1517904000"; d="scan'208";a="33433452" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga008.jf.intel.com with ESMTP; 13 Apr 2018 06:37:59 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Shahaf Shuler References: <20180412133422.104155-1-shahafs@mellanox.com> <7325634.395TUUszRC@xps> <23085973.mySOohilc8@xps> From: "Burakov, Anatoly" Message-ID: Date: Fri, 13 Apr 2018 14:37:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <23085973.mySOohilc8@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 13:38:02 -0000 On 13-Apr-18 2:08 PM, Thomas Monjalon wrote: > 13/04/2018 11:11, Burakov, Anatoly: >> On 13-Apr-18 12:39 AM, Thomas Monjalon wrote: >>> 12/04/2018 16:13, Burakov, Anatoly: >>>> On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: >>>>> a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n >>>>> >>>>> == Build lib/librte_eal/linuxapp/eal >>>>> CC eal_vfio.o >>>>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no >>>>> previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes] >>>>> rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t >>>>> iova, >>>>> ^ >>>>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1542:1: error: no >>>>> previous prototype for 'rte_vfio_dma_unmap' [-Werror=missing-prototypes] >>>>> rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused >>>>> iova, >>>>> ^ >>>>> >>>>> As there is no use for those dummy functions without VFIO removing them >>>>> completely. >>>> >>>> These functions are part of public API, like rest of functions in this >>>> header. They're in the map file. Should we perhaps go the BSD way and >>>> provide EAL with dummy prototypes as well? See bsdapp/eal/eal.c:763 onwards. >>> >>> Why using dummy prototypes? >>> Because the prototypes in rte_vfio.h are under #ifdef VFIO_PRESENT ? >>> Is it possible to always define the prototypes in rte_vfio.h ? >>> >> >> Well, technically, yes, we could. There is one function that uses a >> VFIO-specific struct definition: >> >> int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, >> int *vfio_dev_fd, struct vfio_device_info *device_info); >> >> I'm sure we can work around that. > > > Removing dummy prototypes need, would be a nicer fix. > OK. Shahaf, will you submit a v2 with this, or should i do it? I think it should be just a matter of #ifndef VFIO_PRESENT //define vfio_device_info struct #endif - this should take care of the problem of hiding the function definitions. FreeBSD will also need to be adjusted to remove dummy prototypes. -- Thanks, Anatoly