From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A139543AB3; Thu, 8 Feb 2024 02:06:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 392DB406BC; Thu, 8 Feb 2024 02:06:44 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2067.outbound.protection.outlook.com [40.107.93.67]) by mails.dpdk.org (Postfix) with ESMTP id F06A94069F for ; Thu, 8 Feb 2024 02:06:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YssCmW7YaltnA5zXnHMyxCUKcHWNPQ8UoXX7EaVxrMcfCKHomIbWQqZrRVeOjQF6UEeEFMg2pBXsCqgD2ULyWhatsaVhlpUMFE0mWsgJ/q8ta6BF61SsefwaOk2IHcz3bKvk0ekAlNVK8oQjO5AkFIukCO/WTQ5NAxe5BH0CTBAJz3Yu0QJmkKcLgRYzBdiOHzVX0zJLmp4+m3OAlfquCFS6EX9JRFCy9Of36fBd/ERl36acZN9fXID0E2AFro+4KK9KYLTo/axDjneFb2gq0Ad3ee0jqlg2R5mIgZT3h7vuYACkXahUIUckBmcogOneoeAehraGhM8by1S7Sq260g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hTor4UYlX2WrmyZAywxh4lAEvEKh0Kr8nY/he37tS14=; b=RsnJQbiHPmr6AWe2Z5MaRg5dvqTeWe8wEXqGDosnUdmGNknnxMPVZ4rhMxM9daanllywvJ+EYkyFV7hjx6+GaUP+ppbF1545eVcnu3ANbnjH8H5BnYzLcRPPXb7+QOz8hdEBtRZhbZD98Ydcoxk2NKDGAZ9vramQ4sQJN8YfPA2+6lHfgR8O11cXpVEXYkm/sBr8FGlFjBOSpkLzMw58O727y92hYZtMueqfmF7GT0qD7cWBnmiSqYKb0gC+Nc+tqJMUGoGtZgyhym7mBpz28gytItIg9LcV+TXHL39ub3vK0rRzdNqu4oIfnbHN195L6KF/siRC4TqrpmIzol/SAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hTor4UYlX2WrmyZAywxh4lAEvEKh0Kr8nY/he37tS14=; b=J5qHq0/SD4xor7/6FG95ndoVk8S81eQW2Z4jtCykrWy4JhBFVJVt4VUFMv87ekfguIqRkJth3lXG6eW/XBNYjY9y32lmYW/6Ybz4HCAcTFtxFnul//VqT/lqLojtA7spoValH005l2EywORV7q+9DX0rr3lkcNhQ3N7Mnxp/BcU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4309.namprd12.prod.outlook.com (2603:10b6:610:a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Thu, 8 Feb 2024 01:06:38 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Thu, 8 Feb 2024 01:06:38 +0000 Message-ID: Date: Thu, 8 Feb 2024 01:06:34 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/memif: remove extra mbuf refcnt update in zero copy Tx Content-Language: en-US From: Ferruh Yigit To: Liangxing Wang , Jakub Grajciar Cc: dev@dpdk.org, nd@arm.com, Ruifeng Wang References: <20231208023801.3156065-1-liangxing.wang@arm.com> <4a0e96d3-9370-4954-b2a6-abc4b37a8659@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <4a0e96d3-9370-4954-b2a6-abc4b37a8659@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0669.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4309:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c97f1fb-df48-4142-b2a1-08dc284233e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EcgLNZstdzQEtvIH2KIHfJJviBrutWfNUGZ6HLG310wAO/BHBgLf/M+uy4P1aVYE7sMFwztRxNm5JqUCctpzuG3u6djD2Xt+1M+gHSAj3i2NDiLKtNvAn22xK7MzxzsK+gWjbM1AKfxvRZTWK338vVE1EE0mbxFmxccMDaAR/Hh1Ey5c/QizEh2XikOD3zjnfLOGBwRxpIEvwr1L6gGkIkaE8YlxXHzAYBpCYLPRYcRKOGz7r/fAhUrNjLvLKp5cI82OL7kOz8AodHcV8O0FUOM29VmkVBjLkKnpqUII5yH2G5Qv+b7NZDwF2M2s9pPI1mTxAvMfFoEbfzY+KOWUsLsWMqK4Akc8PYt8o1p2Eae96N+G9DSPkHbzzGFTcouCm70deeCNozjkvP6gyjx5Vd59uyHdF7mc2IATXlaFGEKzwj4PRNwgGJYidIBKv3i55sMown7T3N3jNlS6fIODXx1vZD3wxkeyEW0ADjP87pHb5OsT3LOLefLNRCvzuP04KaMd3m3zyQFuhZcr3yVUCuKQGcId42a38eR5xQdlOQiTRDkpBf6vJiubkaeu6hR0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(346002)(396003)(136003)(39860400002)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(66556008)(31696002)(41300700001)(6486002)(86362001)(36756003)(8676002)(316002)(8936002)(4326008)(15650500001)(66946007)(5660300002)(53546011)(110136005)(6506007)(66476007)(2906002)(38100700002)(478600001)(6666004)(6512007)(2616005)(44832011)(83380400001)(26005)(31686004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlZZZmRBMUlYYmdOYTJmTTIwMFZFdExkZVlTaGRGUThNS0xFTndiKzZrdVhz?= =?utf-8?B?aExURjNmazJXUzBhMWRIbnA3Vlc1dVlsZDYvd3VxZ3ZqdERyRDl3SW1YT0Nr?= =?utf-8?B?UmJ4QUtzdW93MFlFeVNsd2d3aTNFNi8rTi9qQ2tTSkYvYzdidjR2bzJWdk40?= =?utf-8?B?V3VIRC9tNElOVEhoMXFPc0Y0TGpSaStYazFTaHhFL0xKTDE3UTN6SVdUci91?= =?utf-8?B?RkVtY1A4ZEdZemNSSitsR0pSWHplb2s4WFprZ2lqSmh3NHRnV09mRGJiOWZT?= =?utf-8?B?NG5Dc2dKaUIwVzVkaFlmZDNyemVJVFkvbDJLd2NmbWY0aVZsbTBKNzdERWFR?= =?utf-8?B?MEszYSt1bnpzeFNDcUU4dm1tK21waFAzcFpjVWtoUFlvL0RWTVloZVYyQnZY?= =?utf-8?B?WjhXUUVEV2pBTGcvR3FRRU1rWXBzRWl3ajFPOXZ3NlI4MU81YkdVMWdTQ3E1?= =?utf-8?B?SVYrU1Zvd2JkbjhJYnEwbEJiV2JUZ1VLUElmZGdjQ2VLL0JtYTRjeHkyc1lq?= =?utf-8?B?Q1JSQ1lYbHA2TjlWK1dwS0g1NWRZZTNYVlI3RHB3MmpIcndadnV6VEQxTEpm?= =?utf-8?B?cHJ6b1dLa3lvZlZnNmdydlAwcXpwSXFTNE1scG5VdEU3N0hnbmU4L0p1UUcy?= =?utf-8?B?TlhHbGkwanJXZDZCbUtveld1ZEtpME5HSnFrbzQ3aXVvbloxUXVpSmw4bHRU?= =?utf-8?B?U01pT2pac1FWVExMQTVUcFNzVWZFOFZ6TTlWM1hKdjgwT1QzZ1hGYWsrQ290?= =?utf-8?B?dDVMaDVjQ1E0SzhOUGhvZ1VYc3Ereld4c0ZlQVhtVXZLNlhLN1ludlJlbVZK?= =?utf-8?B?aVdxMFJpbzBJQ2o1bGQ0V2JyQ0gyMnRmU09iMldGN01abnljdngwbkZTeTd4?= =?utf-8?B?OUtoSVhYamxIZ2ozUDRJVVRUK1lxMDVuTmVIejFlL3FFZk9SVTlKWWYySTgz?= =?utf-8?B?eEgyVmNVOFR0Q2lveFB2d2U5TW5WajE4Z2NKdnhSQUhJNEx3Q2JJeWJWc01S?= =?utf-8?B?Zjl5SVhEaTBlRllZZTZsS1dDQ0YwNGRXdG8rb0dmd0V3Y2FtbUE4eGp5UHR6?= =?utf-8?B?RDdSNTAveW1WSlNOZ3AzbGFwMlU2bzdCVE9xa0IySGt6T003VU1MQ2JqUjlS?= =?utf-8?B?TjVHRm82N1QvRGxLTVhtSVNvQVp0Ulo3SExNd0k0RGlSaTlyczM4aW9obE9Z?= =?utf-8?B?bi8xVHYySVQ3dnMrZTJPQmFOSkJpY0FzWDJMZlJxdVljNDdreHZnbWtYTWVZ?= =?utf-8?B?OW15aHhENTY4eExubHhlN0syQXJicmtkc2YvWWNHVGZnV2Naa2wzcC9GdHJz?= =?utf-8?B?b1FSTFdQWTNlN3RtaHArci9kU0RuWVRTY3FKUGh3WXlRUUlUa2FrM1FydU1H?= =?utf-8?B?TzVFOHlmc0RkZHlDYnJWU3dTKzlPL0ljNnRHKy9CSFBkWEpTMUlod3hxNzBz?= =?utf-8?B?WnUrbWVXNlpiK1U1U1gyZlBUUkhGSkl3YTRCU0RKNEw3dlZkTk5rZjBUVUds?= =?utf-8?B?WDMrR25pbUlsUmdUb00rNGtsSGRBZmZ2eGhVSHNMV0FrM3c5Z2ZTMWgwUCtT?= =?utf-8?B?akJ3OEJtaTRNZlR3anNRNDFZMG9nS1pBTm9tNzJ1Q3RJZGY0VVNDb0x6ckJi?= =?utf-8?B?Q1JuNVRBa0dGdDRxa0x2d0RTOXJEbThyTHhzVHh4cTVxeVhteCtuREc3QnR5?= =?utf-8?B?dEY0b2NDWGgrb3VjL0NMb3lzQlp6UFgrSHRiNDBhaXFsbU9WZ1IxaDhMd2pQ?= =?utf-8?B?d3NzUkpjVmV4WlR2VjUvQ241cjU2TmF1Q1dKSC9TdktGQjFPcGxwSy8veXJn?= =?utf-8?B?YnUrdnRpVW0rVU9lMDllU0R1eGY2TTJ1NWNqbU40VHErdU5IWWN3bW15SnFs?= =?utf-8?B?dmZsa3I2cmJ6Q2pBMEU0bTBlbDAxTkZqV2p0UFVtMnZyUWxlYnRsNHZRQ3hI?= =?utf-8?B?Tzc3SmRGNVZjdnFzdGlkRi9mMDM5OGdpcnlpMXlrZWowMkxoN1hyWWw3azAx?= =?utf-8?B?cUpMMldFN2RCeHpnVDB3d3hkaTMzTjBMMS9rTnNrckxBa2tPZ1g5cjJWSTE5?= =?utf-8?B?V09TbmhGblYxazNYZk5nejQyU2oyWnJFYkhKakd3YktJK0RZd1BqRVZES1JJ?= =?utf-8?Q?+0tGgN+jdBd/0yeQDUFjXbbR+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c97f1fb-df48-4142-b2a1-08dc284233e9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 01:06:38.4804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q99yqakl1qSPd3WWlkCRnRFxC5HPEgefJLDHAZm6MBo/p10FbMg0ibLl2VoKA9aW X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4309 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/8/2023 1:44 PM, Ferruh Yigit wrote: > On 12/8/2023 2:38 AM, Liangxing Wang wrote: >> The refcnt update of stored mbufs in memif driver is redundant since >> those mbufs are only freed in eth_memif_tx_zc(). No other place >> can free those stored mbufs quietly. So remove the redundant mbuf >> refcnt update in dpdk memif driver to avoid extra heavy cost. >> Performance of dpdk memif zero copy tx is improved with this change. >> > > As mentioned above, since free is called only from 'eth_memif_tx_zc()', > this change looks good to me. > Did you measure the performance improvement, if so can you please share it? > > > > And addition to this being an optimization, it may be a required fix, > can you please check following case: > > - When 'memif_tx_one_zc()' called, it has number of free slot > information as parameter > - If the mbuf is chained mbuf, only first mbuf reference is increased > - If number of segment in the mbuf chain is bigger than free slot, > function returns 0 > - in this error case 'eth_memif_tx_zc()' breaks the sending look and returns > - In this scenario application gives the decision to either free the > mbuf or re-send it. But for this case application can't free the mbuf > because of reference count which may cause memory leak > - If application decides to re-send, reference count increased again, I > guess eventually 'memif_free_stored_mbufs()' will decrease the refcount > to be able to free it > > Assuming above is not done intentionally to make sure all mbufs are sent. > > This refcount prevent application discretion to drop packets, so your > change is required to fix this. Can you please double check if I am > missing anything? > > Hi Liangxing, Let me summarize two points above, 1. Can you quantify performance improvement and document this commit log of next version? 2. For some cases this optimization can be required as fix, can you please make this a fix patch with fixes tag etc in next version?