From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADB0F43A39; Thu, 1 Feb 2024 12:20:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86C4040299; Thu, 1 Feb 2024 12:20:43 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2043.outbound.protection.outlook.com [40.107.243.43]) by mails.dpdk.org (Postfix) with ESMTP id 4B1744021D for ; Thu, 1 Feb 2024 12:20:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1/NKnlYSF9qFdrct7VMgQp5lYfNTY2h0i98GB+V3xONMUc1IzVO67c8LRCplcYatEjWL7/Np8PELc1WgIkbrBFW3En+9sTKslN4BeZ4Y9ufmNLXGTvePeNl6fvTrAweH9L0tzmg2kAw5fPypqOoZV1x+Eid0XyjKQ4sKU3KMVD7W1Oh0WdCqLAabyRVWoprHOmPRFYfJv/0paoy6LIRTjXYXWb5uvkZdN/JkJHfAW3pDKlLh4U4F+CqXrR9PINhYBZyeKPrUJqkupyWYBtXusNupLD0CNfSyJ4QvqWgOX6Skrmm6yORCQCXmWbOy6L5vjQH6pf5BdIHGpYNjvnUdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7WzHXtvqWhCo0qnOhL5O/wVXVU825Jzxb/6AelAlGTs=; b=MsAvaJTL3bWwI4SSjpD2EHlNKFRMn3MgtOpcmJYXJ3sZt7jB+1inTBAoEk+AcZvzmSqyIlmPQHeNPS+G/stoHepuWLW9KsZf2CqgaYdlwOq2xLYsu6F+q4qUg/BmefYjIqmXf8ADEJsvfGRvasTvCIWgwIMe1RJEH4JDa9jH0JCQQk3fM+Tq12px+RZqONqzC8LmQtgIr4sVcibMCNd7pr48HqUipviQFmXeuav0f66/zYcEp9o2KHvGo4fcSItzmC3bY+MqvjH5zLXVOfJjDa5/bUy0K/GCn/jlgXvVj4pNwAMQUYNksPH4NkQmEjXqf+/UDBI2Sc2zMNxxz8mhWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7WzHXtvqWhCo0qnOhL5O/wVXVU825Jzxb/6AelAlGTs=; b=d2c56H+BEP6vMUA+G5THuX9IsofKpx6H37lNxGz2fkUzcSmxPC5j0pe8N81/KEuNnuP3EM7Pkr5oilR1Bo6n3xNpVHsHKM2uPdpTtD6ovpWWVuoXEgth6hyjL9VOajkke001cm+6FBfdTVhY3RWQjXbHE1hdLHBAtr5bt2esT7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB7999.namprd12.prod.outlook.com (2603:10b6:806:312::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Thu, 1 Feb 2024 11:20:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.010; Thu, 1 Feb 2024 11:20:40 +0000 Message-ID: Date: Thu, 1 Feb 2024 11:20:33 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure Content-Language: en-US To: Suanming Mou , Ori Kam , Aman Singh , Yuying Zhang , Dariusz Sosnowski , Slava Ovsiienko , Matan Azrad , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko Cc: "dev@dpdk.org" References: <20231219013337.531548-1-suanmingm@nvidia.com> <20240115091318.1053433-1-suanmingm@nvidia.com> <20240115091318.1053433-2-suanmingm@nvidia.com> <9e38221e-285c-4cf6-a170-c3ee2f8b1786@amd.com> <9f2c9c9a-9a7f-404a-859e-ce68f2a56c15@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0666.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::17) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB7999:EE_ X-MS-Office365-Filtering-Correlation-Id: 27a3a95b-34fd-40aa-7526-08dc2317d1e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RppeDOJVxlZFU+3XRJxeYEE4BiCSHMKLyQIxcrMuDNLGM2fzp6m5MAXw94HxRXgy1Gnx5/eMqhjyaRunk/Q1Uv09+RZWjfIf72+XwRDuFAG8FqRzCaNACBAy54DjRhPo743hEXqexW64n6ROGo+v0fVkr/sF8W8oyUZB6ZWoQKCDAjf6+f8rOG4J9zp3qSuk+CKY7D7REYqCEkclKslzbbpnI9oeKAG8VKD6z7CPEYSu9GA4x8bIbTu4ctxhxDMN3IRYopfRApSWdXmlTbC8uesBQY2QiK2N2dBE+hrUhvfRaK0Tj4lyRTLGSrjh7lALBnuCuUnHctXSkIs+9nasUOKElT1WtP5uqvyzh26xVFl65tnV8ggIl823FHjNCgxDp5S+cxee0QhQ7P0uJv/CV0xpgTNGDNOKlBSGdmdqjobWPMyr06TAkaqeL352MhDaV7rPmlhC3qo6MIiTi08NYJScWPN2sv0TB3qI9V/LIoTdnbul6OGU68gCqrgYb/OvgSFuy6fxRXOFwnPNEQspGYDv1hYFUi6aJYgHzElW52m62BDb3iMJRUA9JARO+kk0dVi9konfQ2ObMfa7+xkVN+g5UvlCiSrxZgFB4sC/OxtypqtxKFC9j7M9zaaZYyuj7QQUpp05dd5gAsthR0i4fy2h5O3e19NwPQjuWuhQ5+NqEBVt8dgMcpuC82JBJmys X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(136003)(396003)(366004)(346002)(230273577357003)(230173577357003)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(83380400001)(2906002)(7416002)(2616005)(26005)(5660300002)(38100700002)(478600001)(66476007)(66946007)(66556008)(6486002)(31686004)(110136005)(8936002)(8676002)(53546011)(6506007)(4326008)(316002)(44832011)(6512007)(6666004)(86362001)(31696002)(41300700001)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGZnUUhlVDNybWFqWW03UUVUZDRBTjhjbXZCeC8xWWZTUWRZdGVjQlFwY1Zz?= =?utf-8?B?SXRrTDU2SHdVNW9uRWMvLzZxMmU1MGtUSDV6TjVPd0lxUHJsVlRtYWdkNmlq?= =?utf-8?B?bkR3UHVwQWhrVWd6RXpITkdkMHJtUUt6NmRESk1QYjFMSUt6NW85OU5Ob0di?= =?utf-8?B?cDRHM0FJMnJoa3VvR2xqTmVUMnlEVGZHcHZwVlQra2NGYUd6dVRBUTErSDlS?= =?utf-8?B?WlZHaGZacHU2Ym5PRmF1SWdENEMzWlUzYlQwQzIrQUtEb1lnMmpyTXY5Ulhv?= =?utf-8?B?NG5OeVo4NFVrL2tzMUwxbExHUUlTOFoydVZjUlNYUXBWalVQbUFLM0crK1JL?= =?utf-8?B?UlpFS1FGeENuc0RLYlV4SW5maWhrMm9FcXlXTk9ZZmJLRnJRSlNkdEFNSFg0?= =?utf-8?B?L2RZSlc0NDJVb1N4RE1JZW5OajlIWjBBWmVhTVZ2T1lEdU1uQ1BDSktVdGU2?= =?utf-8?B?ZjZPOU1Nb1RHSUQ0cnZwNis5NUJNOXowbTdRdDBsNFRvZld5MFM1aUtLVWdy?= =?utf-8?B?dkovejVPSXdZbWdnNjF2WVZQOEZBNGlITjY4U1lhRU9iTWx4V3ZiU2ViMDNM?= =?utf-8?B?YVE0bERQN25IRlZ1dk1lT1ZyTDN1RWdPSUpmZ1RXWGliRy80dFB3YkQzOEM5?= =?utf-8?B?Ky8rMlB2d1BaQ3JVSHg4b2RnejVOREVsQlQzbmhiZ0dGZzBvaG9teXJ6cHJ3?= =?utf-8?B?dXJVb2dXOUtWZWx4VGJRQVVXN3BpTDhiVGM1VVZ2aHc5U3JRRDdJWHY0QzV1?= =?utf-8?B?TU4waXA5QlAxUWhTc3IzeTk0emFXeEptRzFvVnJ4ZklBenZnWVFNSjc2WlJU?= =?utf-8?B?QmZ0Q0FLRkhNai9JL20vSnQ4R1pxY0prMjdvUDJtb1JxeHBrVGNDY1B6eHI1?= =?utf-8?B?amgyZG5rRmhoWCt3dStuYlIxLytCNHBjQkd4bTdOTFVjSEg3YmI2TVhSQzR2?= =?utf-8?B?QUxRdnoxZHFxdzZqVGQ2MzN5VUhSd0ZmaVlmVzZXTFpuSjkxYjI2M1BxdlZr?= =?utf-8?B?bG5DZ3BjWEJpRUVOeEdLaTFXNTdKT2JZY2hSQ1ZnTkVrV3piWnVEcGp3YWRI?= =?utf-8?B?S1BQL0FTdUxOVHgxbHpHNTNwR2ZvK1BpdDByLzh6UVNMZ2V5R0tPR3V4Mjkw?= =?utf-8?B?S1d1MnJlSHk4RWZ6QUh5eUVndmpJakY1NENOUUhYZ1pwSnpXZjlsdUZRSTNL?= =?utf-8?B?Rk10RTRaTmlyQTN4VXhiM3Y5ZVJFVnBnTmo2YXJVdTFQb3VaemFBZTBrOVhT?= =?utf-8?B?N2JzOUVNUE51bTBHM0ZNTUV6WHhHSzBxb3pvRk1xQkdxL0hGajM1alREelhn?= =?utf-8?B?U29TNEZSdGNMK1FVWDROZEJwTWxreUZJQTI0WW1MVlQwVWlneXdzQ0sveXVo?= =?utf-8?B?MlhMOTYvOXNzR3NycTNGRThReU13MVV2Yld2dzJCWUFuNjV5ZE9lVnMzb3dD?= =?utf-8?B?YXJGUEVtYTFLcUNRMTNtSTZJMmpnQzA1SS9rVW9FbVhYK0JScXRCR2Y4UktL?= =?utf-8?B?a2dEQXh2aWQ0M2FpTG8xakp4UlNjUFFuMy9hZDRlUHp0V25GcnVzWDhIVHJn?= =?utf-8?B?dXpENjdVU2Fib3dzRHZ3UFpydUw2SjFCVjlGNHRWcThTQzFZMU54ZDVROHBD?= =?utf-8?B?Vzg4VXZLWlZLTXgvekFZUHhFMVZjR0hCRTdiMDI4aXp0OUJ4M1Q5YlZiNFc0?= =?utf-8?B?ZVFlSUJjTFpsRzc4NjZNNjloaGFjVjhsSHFEMFdZVmpSaUxMNWIxQkNEaTZi?= =?utf-8?B?YkxMUkxpL3pxaUx3Rldma3pXc1FackFhRXFZSUJ3anA1bEVTckNsRUh3dEp0?= =?utf-8?B?WE1HMDByMmhybG50K1hMeVVYNlRyand2MldIZ25xOG8reENLczVQUmFpYlFo?= =?utf-8?B?WDlybmcvV05zTVhlMm81ZkpGMDEwdVVLRUtaRXdhN1QxdHRXNm1kYzdpbE8w?= =?utf-8?B?MXlBM1dyR0NOeXltRDAweDhiUkVEY2RUWS9Mc2lhVVRLek5lMlRpNVQ0dlpU?= =?utf-8?B?QTJMbzdsMGN3bHFqaGw4RW1qYUYyWEd4TEYxM21XZjBGOUVoOUZ2ZEFWOTlF?= =?utf-8?B?cWtIVm1jVEhRRDdUbVc3cG1Bc2tydmJ0UFNTRmVUbHhWZ3NyZE1oS2oyYlFq?= =?utf-8?Q?LFoxNTP0JvQQ84VwEXjZSaJxq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27a3a95b-34fd-40aa-7526-08dc2317d1e2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 11:20:39.9252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NiXdW7DkChP69d2Gw0jtgBSBlvydK9eLZ0A14jrwosEuevywEGePdpVW8TxcAOhg X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7999 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/1/2024 11:09 AM, Suanming Mou wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, February 1, 2024 6:56 PM >> To: Suanming Mou ; Ori Kam ; >> Aman Singh ; Yuying Zhang >> ; Dariusz Sosnowski ; Slava >> Ovsiienko ; Matan Azrad ; NBU- >> Contact-Thomas Monjalon (EXTERNAL) ; Andrew >> Rybchenko >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure >> >> On 1/31/2024 2:57 AM, Suanming Mou wrote: >>> Hi, >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Wednesday, January 31, 2024 1:19 AM >>>> To: Suanming Mou ; Ori Kam ; >>>> Aman Singh ; Yuying Zhang >>>> ; Dariusz Sosnowski ; >>>> Slava Ovsiienko ; Matan Azrad >>>> ; NBU- Contact-Thomas Monjalon (EXTERNAL) >>>> ; Andrew Rybchenko >>>> >>>> Cc: dev@dpdk.org >>>> Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data >>>> structure >>>> >>>> On 1/15/2024 9:13 AM, Suanming Mou wrote: >>>>> Current rte_flow_action_modify_data struct describes the pkt field >>>>> perfectly and is used only in action. >>>>> >>>>> It is planned to be used for item as well. This commit renames it to >>>>> "rte_flow_field_data" making it compatible to be used by item. >>>>> >>>> >>>> ack to rename struct to use in pattern. >>>> >>>>> Signed-off-by: Suanming Mou >>>>> Acked-by: Ori Kam >>>>> Acked-by: Andrew Rybchenko >>>>> --- >>>>> app/test-pmd/cmdline_flow.c | 2 +- >>>>> doc/guides/prog_guide/rte_flow.rst | 2 +- >>>>> doc/guides/rel_notes/release_24_03.rst | 1 + >>>>> drivers/net/mlx5/mlx5_flow.c | 4 ++-- >>>>> drivers/net/mlx5/mlx5_flow.h | 6 +++--- >>>>> drivers/net/mlx5/mlx5_flow_dv.c | 10 +++++----- >>>>> lib/ethdev/rte_flow.h | 8 ++++---- >>>>> 7 files changed, 17 insertions(+), 16 deletions(-) >>>>> >>>>> diff --git a/app/test-pmd/cmdline_flow.c >>>>> b/app/test-pmd/cmdline_flow.c index ce71818705..3725e955c7 100644 >>>>> --- a/app/test-pmd/cmdline_flow.c >>>>> +++ b/app/test-pmd/cmdline_flow.c >>>>> @@ -740,7 +740,7 @@ enum index { >>>>> #define ITEM_RAW_SIZE \ >>>>> (sizeof(struct rte_flow_item_raw) + ITEM_RAW_PATTERN_SIZE) >>>>> >>>>> -/** Maximum size for external pattern in struct >>>>> rte_flow_action_modify_data. */ >>>>> +/** Maximum size for external pattern in struct rte_flow_field_data. >>>>> +*/ >>>>> #define ACTION_MODIFY_PATTERN_SIZE 32 >>>>> >>>> >>>> What do you think to update 'ACTION_MODIFY_PATTERN_SIZE' here too, >>>> instead of next patch? >>> >>> Agree. >>> >>>> >>>> <...> >>>> >>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index >>>>> affdc8121b..40f6dcaacd 100644 >>>>> --- a/lib/ethdev/rte_flow.h >>>>> +++ b/lib/ethdev/rte_flow.h >>>>> @@ -3910,9 +3910,9 @@ enum rte_flow_field_id { >>>>> * @warning >>>>> * @b EXPERIMENTAL: this structure may change without prior notice >>>>> * >>>>> - * Field description for MODIFY_FIELD action. >>>>> + * Field description for packet field. >>>>> >>>> >>>> New note is not very helpful, how can we make it more useful? >>>> >>>> Does it make sense to keep 'MODIFY_FIELD' and add 'COMPARE ITEM' in >>>> next patch, to clarify the intended usage for the struct, otherwise it is too >> generic. >>> >>> OK, sorry, the purpose is to make it generic. So next time if other ITEM or >> ACTION need that field, it can be used directly. >>> Otherwise, it feels like it can only be used by 'MODIFY_FIELD' and >> 'COMPARE_ITEM', what do you think? >>> >> >> I don't have an intention to limit its usage, but to clarify usage for whoever checks >> the document. >> >> "Field description for packet field." doesn't say what exactly it is and cause >> confusion. >> >> Perhaps wording can be changed to say two possible usages are for >> 'MODIFY_FIELD' and 'COMPARE_ITEM'? > > Sounds good, OK, I will update. > > BTW, I saw the patch apply failed, seems it is due to Raslan's branch has some extra features than your branch. > So I just want to know is it OK? Or should I still base on your branch? When will the branches be synced. > Thanks. Can you please rebase next version on next-net, this way we can benefit from CI checks?