From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CFBCA0C46; Tue, 14 Sep 2021 12:50:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3E034068F; Tue, 14 Sep 2021 12:50:08 +0200 (CEST) Received: from mail-108-mta28.mxroute.com (mail-108-mta28.mxroute.com [136.175.108.28]) by mails.dpdk.org (Postfix) with ESMTP id 3AECB4003C for ; Tue, 14 Sep 2021 12:50:07 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta28.mxroute.com (ZoneMTA) with ESMTPSA id 17be3ed8d1f00074ba.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 14 Sep 2021 10:50:01 +0000 X-Zone-Loop: 69af7a3e5de805a53a31a6e86262685a6bb6d0423842 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bJmgsjulvDsuZoLPfW7ynVp1tkFJCPxyIGSY+YqAGjQ=; b=UPgaoyjvQyE/nQ8iBZCh7g7Tpz 81TvrDIWg3TmZ6Bh0lflqOMPxdYZtfa3qGAf32eIoh/c0U3SPISWx3qXjgBpW+TualBbnxRqQpXyI 67Ndy/N0AkQHty4K0GmmMx6n0ONGMhxeBf9zos5GUiRPKg5GjH49pjJPjH1bObvXNm+We5oCGhWVl +pYv5jnsLeJUweRUQwfCN3i1whu8QHxp9jssVwuUB2KxxFw/8szDIiTto4eIvUlLi0Fc51QgFv+QM 37LGLEVABzaiatKBJHtwbAAG4NzpxYx3eQeaTs4aXN0eBBaYeF1HZ7AVCGke5ldBZQWDP4Vhi4OdJ BFHEUeZg==; To: David Marchand , Pablo de Lara Cc: "Wang, Yipeng1" , Byron Marohn , dev , techboard@dpdk.org, David Christensen References: <20210910165346.807715-1-pablo.de.lara.guarch@intel.com> From: "Kinsella, Ray" Message-ID: Date: Tue, 14 Sep 2021 11:49:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] efd: change data type of parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/09/2021 08:10, David Marchand wrote: > On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara > wrote: >> >> rte_efd_create() function was using uint8_t for a socket bitmask, >> for one of its parameters. >> This limits the maximum of NUMA sockets to be 8. >> Changing to to uint64_t increases it to 64, which should be >> more future-proof. > > Cc: ppc maintainer, since I think powerX servers have non contiguous > NUMA sockets. > > >> >> Coverity issue: 366390 >> Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library") >> >> Signed-off-by: Pablo de Lara >> --- >> >> This fix requires an API breakage and therefore it is not >> a good candidate for backporting (besides, it is a very low impact bug). >> Hence, I am not CC'ing stable. > > This is an unannounced breakage for a stable API. > Cc: techboard + Ray for awareness. Understood. Its low impact, at a time we are changing the ABI in any case. > > >> >> --- >> >> lib/efd/rte_efd.c | 2 +- >> lib/efd/rte_efd.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c >> index 77f46809f8..68a2378e88 100644 >> --- a/lib/efd/rte_efd.c >> +++ b/lib/efd/rte_efd.c >> @@ -495,7 +495,7 @@ efd_search_hash(struct rte_efd_table * const table, >> >> struct rte_efd_table * >> rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, >> - uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket) >> + uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket) >> { >> struct rte_efd_table *table = NULL; >> uint8_t *key_array = NULL; >> diff --git a/lib/efd/rte_efd.h b/lib/efd/rte_efd.h >> index c2be4c09ae..d3d7befd0c 100644 >> --- a/lib/efd/rte_efd.h >> +++ b/lib/efd/rte_efd.h >> @@ -139,7 +139,7 @@ typedef uint16_t efd_hashfunc_t; >> */ >> struct rte_efd_table * >> rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, >> - uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket); >> + uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket); >> >> /** >> * Releases the resources from an EFD table >> -- >> 2.25.1 >> > >