From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9860BA0C40; Tue, 7 Sep 2021 17:56:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56478410ED; Tue, 7 Sep 2021 17:56:55 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B039F410EC; Tue, 7 Sep 2021 17:56:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10099"; a="242526424" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="242526424" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 08:56:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="478742873" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 07 Sep 2021 08:56:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 08:56:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 7 Sep 2021 08:56:51 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 7 Sep 2021 08:56:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=meSLJmduPCdnd1idKIT7PHP0me4M1sITB05Gf7/pBd09YC0x2uSSRRs4EfDtrgJo1GF6B8Mc3O8M7Vjuzy2uBmLuVEq5Ubt0op7NBMOpdLcLaTvezYhWVugZRrWjJjWLTwifXqhD54IbxxBPCBRj0gJmO+6tgU9TEMLbedRcsiF05bETWj2NVx6NeEnnkELX1d4HMUH/U/qoDzx4AlqyeXEm4uQ2f/5A2JFUTP/NsPGGpjN8bstPSdHlX1Ft4ovUsAzzFURXiiX0zjo2LcXZljXb6arEoQrj82Ezv6gxb4Ldb2bw31LKVsI8adBRXPjzxovXYdkz4IIVOnPrHRBJjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zbFWUAfCrTNEI5hXh02BVSBhKSqOVHHrDYdD534GiR4=; b=TR5E0qvzCD3R7bW+ZphjPAG9z3pDXuAp7s/SoiBZBZQ5S8B7Ty3T5TfZ3rWOTwY7UuLG3CcMK247uya8rYoLGHvrG9+G+VXtoX6/1xghMtOMmzWjqiDarjarYinbsx5gUDgLFk76+2bXz+8bPPWB3rMCPsWZxzsqGIVgd6HKzQPR+WBfs0tw2C9BvoicNdXJYDljsVEVTIlBzzimF84uuRu5VcZP1u3iO/F1dHyHL2wVAd+N/K2HveRSXJebYGyFTwtObyLT81KnpZf1brGqPoHZGQxpYQFvt2xRAo/nUPrfotgHQi+r8NnMKfTTIR/uSwTpMAbkd2lsvNWzCtqwOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zbFWUAfCrTNEI5hXh02BVSBhKSqOVHHrDYdD534GiR4=; b=ZkgmnzvtMgfzKF60fG/puizb/uHn7x+VYFe8lXpdLOqaKFr02JKFpmiqLDoEQFNer1/vPmyr8FEgocWPjFHkY2Bu4Pwf8Ro0pQgXBGoNlTXiEMJP75IrEVdqLPIPTUhWqq7Kovq89JuxYWYXDhkgsDiLagSGr9paHRb3DJlDRl0= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4807.namprd11.prod.outlook.com (2603:10b6:510:3a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20; Tue, 7 Sep 2021 15:56:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 15:56:45 +0000 To: "Loftus, Ciara" , Baruch Siach , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" References: <8a03128cb9edeeaa747f74aca60d6a8b9f5c4f8e.1629885944.git.baruch@tkos.co.il> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 7 Sep 2021 16:56:38 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR09CA0005.eurprd09.prod.outlook.com (2603:10a6:10:a0::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR09CA0005.eurprd09.prod.outlook.com (2603:10a6:10:a0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 15:56:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f7ce7a2-1b7a-47cd-1f28-08d972181765 X-MS-TrafficTypeDiagnostic: PH0PR11MB4807: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WPMIVAjTekdDzN4ftiiOtIANN0Pr85sI4HVwMk79kabo/LapNZLO54wnAYlTmTi4KndlAjksdpnZwfQLIm4OmYXsJiGX5v7ZKToteSxHcId6lzwSpF6uqcjKeq46uBh3+SgZ6S/4mU/vLojvVyRvYc9lmg559rGwkpFiDLsXMkkJ+wCOxHeVj+G1eTNV3nw814rF9AS2f8SUxUWo27yPR9sdPRAL1iE6NFYjXqjly7/c3Ea9SweZwyR38o3cv92TZmxbpnHrr8FLdj8jzGTT1CJlL+PaYoOq0wQFqA+Ihjhkq8od9oxX+GWYJ3ysr1yWQA+p8WVTm7w0Jwt7V7BAn+By33N1VW1+IWCvOzVMd6nCldisIJdeCF16H9z1FebK02l0hHfOLgaaAvOIBqbrYZECt98ETP9Nift+DuPIHD3+6o476ayrckX/ms3nkGrVxqaUoU2hBZ0FxdaNAP2Dr+2Qao7QZ2WLvsqa413xbEpN2U8RAHjsNrdhoDlz+YLnYPgaZU/sntrze6p397IR0yfdEOQUknDmvT+Nm3kFLco/G27io1QdTkjzgRNKNjtMFbezhudzMollyiY1prYc51ZnkJFNoKnvI0nD/2yq8BL4MXtS4TvCrLNmMbzjJmrdy8qejB97KIJlgxd5sSAvemQEakuuac6OT3wddo6pMUZ2qYAWy5X7Q4zmq4uUzdQdqmQX0Bkt0eADrl0+kxOuUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(83380400001)(36756003)(4326008)(6666004)(6636002)(8936002)(5660300002)(31686004)(956004)(2906002)(8676002)(66556008)(316002)(54906003)(66476007)(66946007)(110136005)(4744005)(26005)(478600001)(6486002)(31696002)(2616005)(38100700002)(186003)(86362001)(16576012)(53546011)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGtxWEN2NTFFWjVpZllROGUrazdKakVvNXYvbzg1dENzVVI2eTg5NG5pYWRM?= =?utf-8?B?M0Z3RGFKS1NGZG9sN0VGc2FXSmVSSUwzMzBDeFFCYS9Rdlc4RzVhbHlOdksw?= =?utf-8?B?cWUvR0VWVmJCQWdoaFJvbHZKR2gzbWZKRkVNbjJVaFBuZGFMenU4djk5R3Ay?= =?utf-8?B?aTk5WUhYOUtCeWpLUkhzY0kwSDhScUc0Y1N6bDJUQm0vZFBtMGtDbnVpRDFa?= =?utf-8?B?RUgxa0t5ZGZ6bG41dFRRQVRwNzJUNWgySDhIN1Y4YVYvMGNyRzhnQlJ4Q1Jn?= =?utf-8?B?RzVlZzAzTWt6MEt6bWI0WCtjdFBRejN0REFnVEp6QVFINlVuQlBwbVA1Y01W?= =?utf-8?B?WFBmQjZJM2xzOFdiRThMVHFINmpzTGdiUXQyZ3lsOEhwQ3V2ZkwyK1liWWxk?= =?utf-8?B?Ny9VL2JPOTM5UXdqVU5QYWNUZXpwM3BlenhwWFRvQWY0akc3SnR4THdXUFpU?= =?utf-8?B?Vzc1Qk1QNzNWQlY1eHhiQXdSL2JyYXFuZzRWTXVJWmtLY29abnFzOVRZazVn?= =?utf-8?B?Uk1uajNWb3VwT3ViZkpiM2Z0T20vU2V3dUFrUjJZdnZEbi9oR2RxSVZhSUZ3?= =?utf-8?B?U1FDQzdHMGRhU2Z2US9mZWk2TzNWNkVSK3V0NFVBZFN1MzIycUpLbnNKd0tL?= =?utf-8?B?TXlLY2NzNFpXblQrZm1QMDN4cTdGTUdnWGRnb2kxbC94N3pDNXRjWGNkUCtJ?= =?utf-8?B?VEtGdmhvQklFNW92emFJR1ZYMEZXQm1PTEF2V1VablNTZGRNaEsxZStzd3dU?= =?utf-8?B?UkFTUzEzaXpkOS9uMGFXU1F3NWtVMk5SaGdvTkxPTDlQOWdmWHRLaWUvdXo2?= =?utf-8?B?RUlKQlY0Wk5rV1V0WkhDSVlVcUQ3SXRiV3NmOXN4UER3Vmlmdkwvdm1YYUJo?= =?utf-8?B?NWZxeWVsVzExOXBHeUR4KzdKY2tEYTFWOERpK29YSWllUjB1K2RTRHRRS0Y2?= =?utf-8?B?NTVhWHpKVHBTTnJHUE1sRFhzbzIvWk81SG50eE5BRlFScUtkSy93NDVvY3VI?= =?utf-8?B?dEQxME5SakJRd3k0RUZjNnZ0VDIxTXJHWHBuSSsrT2NJY2QzWjRyRU04MzBx?= =?utf-8?B?Sjl0dXJnNUd0Qi8wdlNkRlN5Ny9xM2NaU0lOMEJETkVPNnZDczd6UmtqbWha?= =?utf-8?B?U01CQk13d2twaU5KbjdTN2Z6SERGYzJPN0xsNmhXdUp5OXh5aHlLajA2dUdu?= =?utf-8?B?ZVo3UGJUVFFzcWNNUWRpMUlsQTcxeEp1LzRGWGx4Y0Q2clloclFpQitYeUhV?= =?utf-8?B?bUErYUxYTDdQVXYwYmpFcm16eVVDKzVOVzZzV0N3bTJLS3RPd3E5cUsyMDI5?= =?utf-8?B?UHhaK2lzNmNyZWEzdEpzMGFENTFqcXhIL3p2T0VsdHAvMTJVMldrdFZFdml1?= =?utf-8?B?akRENm4yQzAwbkpTL3R4TnErUmNjdXcwMHVCV3NaQlYrb0pSQ2Rvb1dneGgz?= =?utf-8?B?R2dhV1c3QXNvQmJReDZ5YjZ0ME1TQ2lKN1FRSXRzSGxUZUlYa2c5dmN3REpo?= =?utf-8?B?cElidzUyV3FRRjFDQlVXSUZzQThtTGFmeURDeVN2TlYxYjN5b0tDcUxXS0hI?= =?utf-8?B?dmRBQjJhT1BRNThMTzV0L29WamY3N1FOTE83ZU5kNTNrbDJSWHRiUklpelZP?= =?utf-8?B?amd1eXQ1L1l2UVo5V0hZdDR6aDhhdGNTdVBRdFBreW1NNGVobzR5cUVGK01h?= =?utf-8?B?dHZpYlJoNXJWVVplYS8wdDFpc3pYNXA2NTRDOGI5VnBleXVaWXU1bVJjKzhZ?= =?utf-8?Q?596zQKI7lfIhYdkvIvxjPu5dqZFqkgPz2We+2TF?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4f7ce7a2-1b7a-47cd-1f28-08d972181765 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 15:56:44.9957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pJu4gUDe4JQXM03QmtlHMr2aTqEWWwJ36Jqo2VH5J5G0Vteo+okrGP39xm9wUdGDFv6QyBw6ZinnReo4BfS0+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4807 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/af_xdp: fix zero copy Tx queue drain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/25/2021 11:48 AM, Loftus, Ciara wrote: >> >> Call xsk_ring_prod__submit() before kick_tx() so that the kernel >> consumer sees the updated state of Tx ring. Otherwise, Tx packets are >> stuck in the ring until the next call to af_xdp_tx_zc(). >> >> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") >> Cc: stable@dpdk.org >> >> Signed-off-by: Baruch Siach > > Thanks for respinning. I tested it out and it looks good to me. > > Acked-by: Ciara Loftus > Applied to dpdk-next-net/main, thanks.