From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CF20A0561; Mon, 20 Apr 2020 15:29:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A53991D549; Mon, 20 Apr 2020 15:29:14 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 445AF1D544 for ; Mon, 20 Apr 2020 15:29:13 +0200 (CEST) IronPort-SDR: vwkmSRi+4A+3yG1x5SFDNHuveLudk38M4jdxk3lPTYAyWRRPPBCPp/WaE78rOZdeYm/klGVrwX vN3ErR2bqQLw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 06:29:12 -0700 IronPort-SDR: WGFJUhyQQoCpm34fTZeZtadi0L1V9ySm6julkChSrY34/cV/1L27G1nwpT+9J7ZqbsfyU0TSty 6gZNEVPCBv5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,406,1580803200"; d="scan'208";a="289780341" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.19.141]) ([10.252.19.141]) by orsmga008.jf.intel.com with ESMTP; 20 Apr 2020 06:29:10 -0700 To: oulijun , xiaolong.ye@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, linuxarm@huawei.com References: <1587121194-9098-1-git-send-email-oulijun@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Mon, 20 Apr 2020 14:29:10 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: configure rxd and txd number correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/18/2020 3:30 AM, oulijun wrote: > > > 在 2020/4/18 8:42, Ferruh Yigit 写道: >> On 4/17/2020 11:59 AM, Lijun Ou wrote: >>> When users configure rxds and txds by used port config cmd based >>> on testpmd application, it will not be able to configure rxd and >>> txd according to the max capability range supported by the actual >>> NIC hardware. Due testpmd defects, it can only configure a fixed >>> range to 0 to 2048. >>> The final result is that an incorrect printing prompt appears and >>> cannot be applied using rxd && txd according to the actual >>> capabilities supported by the device. >>> In order to solve the above problems, we modify the testpmd. First >>> by calling the rte_eth_dev_info_get api to obtain the max and min >>> rx/tx capability supported by the hns3, and then use this range >>> to compare with the actual value by users configured and make >>> reasonable limitation. >>> >>> Signed-off-by: Lijun Ou >>> Signed-off-by: Huisong Li >>> Signed-off-by: Wei Hu (Xavier) >> >> <...> >> >>> @@ -1212,6 +1383,8 @@ init_config(void) >>> lcoreid_t lc_id; >>> uint8_t port_per_socket[RTE_MAX_NUMA_NODES]; >>> struct rte_gro_param gro_param; >>> + uint16_t allowed_max_rxd; >>> + uint16_t allowed_max_txd; >>> uint32_t gso_types; >>> uint16_t data_size; >>> bool warning = 0; >>> @@ -1239,6 +1412,9 @@ init_config(void) >>> fwd_lcores[lc_id]->cpuid_idx = lc_id; >>> } >>> >>> + allowed_max_rxd = RTE_TEST_RX_DESC_MAX; >>> + allowed_max_txd = RTE_TEST_RX_DESC_MAX; >>> + >>> RTE_ETH_FOREACH_DEV(pid) { >>> port = &ports[pid]; >>> /* Apply default TxRx configuration for all ports */ >>> @@ -1299,6 +1475,13 @@ init_config(void) >>> warning = 1; >>> } >>> } >>> + >>> + /* Get the maximum number of txd and rxd per queue. */ >>> + if (port->dev_info.tx_desc_lim.nb_max > allowed_max_rxd) >>> + allowed_max_txd = port->dev_info.tx_desc_lim.nb_max; >>> + >>> + if (port->dev_info.rx_desc_lim.nb_max > allowed_max_txd) >>> + allowed_max_rxd = port->dev_info.rx_desc_lim.nb_max; >>> } >>> >>> if (warning) >>> @@ -1317,9 +1500,9 @@ init_config(void) >>> if (param_total_num_mbufs) >>> nb_mbuf_per_pool = param_total_num_mbufs; >>> else { >>> - nb_mbuf_per_pool = RTE_TEST_RX_DESC_MAX + >>> + nb_mbuf_per_pool = allowed_max_rxd + >>> (nb_lcores * mb_mempool_cache) + >>> - RTE_TEST_TX_DESC_MAX + MAX_PKT_BURST; >>> + allowed_max_txd + MAX_PKT_BURST; >> >> Overall patch looks good, but with above change, for the PMDs that doesn't >> explicitly set 'dev_info.tx_desc_lim.nb_max' gets the default value >> 'UINT16_MAX', like virtual PMDs, and this increases the memmory requirement a lot. >> > Hi，Ferruh > Thanks. if some PMDs are not configured according to the > specifications that are actually supported, does the PMDs driver require > such a large mbuf by default. >> What do you think to keep "port config all rxd|txd " the fix, but remove >> above nb_mbuf change? > Actually, I agree with your suggestion. But at the same time worry about > whether mbuf is not enough, when rxd/txd is greater that > RTE_TEST_TX_DESC_MAX That is valid concern I think, but user can override the number of mbufs with "--total-num-mbufs" parameter, and if device has more than 2048 descriptor the user can provide bigger numbers with this param.