From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2FE7A00C4; Thu, 5 May 2022 10:37:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B33EB40C35; Thu, 5 May 2022 10:37:14 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9FCD140042 for ; Thu, 5 May 2022 10:37:13 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id DFA5582; Thu, 5 May 2022 11:37:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru DFA5582 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1651739833; bh=j56/gGpGjoh/cAcLJP4GRK82YfVCuaClZIvSg4m9JNY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rHIJeIHSSXpkhAONtDFrhMjME9/Wbig+m583SqHa6GQdEIDxDvMSRJ+5+c9X4kU4e vQGBMJ78UundpO/W1FLN7tv0K0/XIGRpKJNIuPz8amh37OH3IYhoPIkfIU2sK4vp76 YcHomadKZU+fTQVbCObjmsDrrbMSNFuuDgO6xN/g= Message-ID: Date: Thu, 5 May 2022 11:37:12 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature Content-Language: en-US To: Pankaj Gupta , Jochen Behrens , Yong Wang Cc: "dev@dpdk.org" References: <20220503042257.15626-1-pagupta@vmware.com> <20220503042257.15626-9-pagupta@vmware.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pakai, On 5/4/22 23:37, Pankaj Gupta wrote: > Hi Andrew, > > Changes done in this patch was accidentally removed in commit > 046f1161956777e3afb13504acbe8df2ec3a383c. > > This was noticed later and we are trying to address this here. If so, you should add: Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Cc: stable@dpdk.org > > Thanks, > > Pankaj > > *From: *Andrew Rybchenko > *Date: *Wednesday, May 4, 2022 at 8:09 AM > *To: *Pankaj Gupta , Jochen Behrens > , Yong Wang > *Cc: *dev@dpdk.org > *Subject: *Re: [PATCH 8/8] vmxnet3: Fix merge error in initialization > for rxDataRing feature > > ⚠External Email > > On 5/3/22 07:22, Pankaj Gupta wrote: >> Fix merge error in initialization for rxDataRing feature. > > Is it a bug fix? If so, it requires corresponding "Fixes:" tag and Cc to > stable@dpdk.org in order to be backported to stable releases. > >> >> Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. >> >> Signed-off-by: Pankaj Gupta >> --- >>   drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++++ >>   1 file changed, 5 insertions(+) >> >> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c >> index 9955f121f6..6ced76ae2a 100644 >> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c >> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c >> @@ -876,6 +876,11 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev) >>               rqd->conf.rxRingSize[1]   = rxq->cmd_ring[1].size; >>               rqd->conf.compRingSize    = rxq->comp_ring.size; >> >> +             if (VMXNET3_VERSION_GE_3(hw)) { >> +                     rqd->conf.rxDataRingBasePA = rxq->data_ring.basePA; >> +                     rqd->conf.rxDataRingDescSize = rxq->data_desc_size; >> +             } >> + >>               if (hw->intr.lsc_only) >>                       rqd->conf.intrIdx = 1; >>               else > > > ________________________________ > > ⚠External Email: This email originated from outside of the organization. > Do not click links or open attachments unless you recognize the sender. >