From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67E9C41C3F; Wed, 8 Feb 2023 12:01:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 514634014F; Wed, 8 Feb 2023 12:01:07 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 76B1540141 for ; Wed, 8 Feb 2023 12:01:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bYUdgp98M7NEK9amWddmZNVeBqP6/yHPPLo2muNf9yReVaQbrxyY04n+wx30itNU+wBJ8ChH1iq7I7++CSLO89xuK+uvrAFYw/cU67cq6lPK2EMBf/ArEKSJ+9+DEnio5DZ61JYf/ZgG2WxotgflJr2+/5Ywr7fGDkKmJiVa/pYd8mag9vYHexvxmHxrPyz/3KaUvvW+j4Odk4t3HXr7Hq6Mta3oqphZVxAgC39BQ4P1oOd586cp4FGnpaw6zJfVVNQFUC3OxLeThfT+4v7u/35b1T2lllQC27ZVTvfVwIZyH3XzRBe1JebrRcf3XhfGEpLBC/ftaGCKgPv8lniA8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yoKsOTwnciqv2HzeHytRWEujSzq2Z8QaTlCQqY2qIaY=; b=OU+2Ui7HgfBslxUr5gIt+il8kTtC+/zAvcmFHUUbvVWJac9XVeAdiSwDoLOuIw9mxnxuflASkPOxFpCQRTnUtN3G51DHSmegGXQX80q5r3/O1Kyo+exXBx3KE/2j7B7KdVpXbi+1zjqyQGqpzfwv2j/5waWJCsu7e3h+/gVU9agLr7xkgVKuOjvkKbQl7Kv64hxRwTZLR2RmuRDBPHeG6T5fHYts2nZwl/5YIgtp2mXeZC23bv7/UeLsVlnKt6b0bplDymAqU5+vjusDgYIjU0NaNV+OZwfxoWQYhddlr4RoJWOhPoLfeTnPoLwc/rJUkpuNHGUy4Lcd/jbWgzAGZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yoKsOTwnciqv2HzeHytRWEujSzq2Z8QaTlCQqY2qIaY=; b=AOMowvlgo6medydjchY+WAkHzQTy21nRi/OAlY6kKSiFh7aZyTONP0gMwYAw/6qBAeFvS8SQ3BvHhxCT4B2rkr6VK3DZqcEGoBBOY5uobVwIwQkLpyWgn/p//K+BVpJZp+AOqa/XS1ylWb3s/ZZa1mwIBldchEX2C93z5OxLVKM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB4575.namprd12.prod.outlook.com (2603:10b6:806:73::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 11:01:00 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%6]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 11:01:00 +0000 Message-ID: Date: Wed, 8 Feb 2023 11:00:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Ankur Dwivedi , "dev@dpdk.org" Cc: "thomas@monjalon.net" , "david.marchand@redhat.com" , "mdr@ashroe.eu" , "orika@nvidia.com" , "chas3@att.com" , "humin29@huawei.com" , "linville@tuxdriver.com" , "ciara.loftus@intel.com" , "qi.z.zhang@intel.com" , "mw@semihalf.com" , "mk@semihalf.com" , "shaibran@amazon.com" , "evgenys@amazon.com" , "igorch@amazon.com" , "chandu@amd.com" , Igor Russkikh , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , Jerin Jacob Kollanukkaran , "Maciej Czekaj [C]" , Shijith Thotton , Srisivasubramanian Srinivasan , Harman Kalra , "rahul.lakkireddy@chelsio.com" , "johndale@cisco.com" , "hyonkim@cisco.com" , "liudongdong3@huawei.com" , "yisen.zhuang@huawei.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "simei.su@intel.com" , "wenjun1.wu@intel.com" , "qiming.yang@intel.com" , "Yuying.Zhang@intel.com" , "beilei.xing@intel.com" , "xiao.w.wang@intel.com" , "jingjing.wu@intel.com" , "junfeng.guo@intel.com" , "rosen.xu@intel.com" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Liron Himi , "zr@semihalf.com" , Radha Chintakuntla , Veerasenareddy Burru , Sathesh B Edara , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "longli@microsoft.com" , "spinler@cesnet.cz" , "chaoyong.he@corigine.com" , "niklas.soderlund@corigine.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "g.singh@nxp.com" , "apeksha.gupta@nxp.com" , "sachin.saxena@nxp.com" , "aboyer@pensando.io" , Rasesh Mody , Shahed Shaikh , Devendra Singh Rawat , "andrew.rybchenko@oktetlabs.ru" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "jbehrens@vmware.com" , "maxime.coquelin@redhat.com" , "chenbo.xia@intel.com" , "steven.webster@windriver.com" , "matt.peters@windriver.com" , "bruce.richardson@intel.com" , "mtetsuyah@gmail.com" , "grive@u256.net" , "jasvinder.singh@intel.com" , "cristian.dumitrescu@intel.com" , "jgrajcia@cisco.com" , "mb@smartsharesystems.com" References: <20230206115810.308574-1-adwivedi@marvell.com> <20230207063254.401538-1-adwivedi@marvell.com> <20230207063254.401538-4-adwivedi@marvell.com> From: Ferruh Yigit Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two) In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0146.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB4575:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c930602-90dc-4ba7-14c0-08db09c3c2d4 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ar3JGMz+vwqByRBxuO9ThLuDEzqtn1v5wzrr5NFsyf6ux2B5o5cINmNFQhxxhh8VYstyerppP5KHHrLOK6yz8onmhVyjF78hCOEY9mEZonalXET0Ixus5JtB+/zFxZIIPP9YPpad4S2CKjAunR3N6picEmjNHray/kDv3tQGcUjEcm4xPTA/KS7L0KG8aYUmQF4gWGwSOYIddPp5hQKzYcJBvndcYxqRT5T1wBsFPyypADC8aEriZgRZyWfQMCJvvqt3c/DQGQuRzH3j8ld25P36OvWqGg0STo9sa0OeIpAuAoGIAby7Dq/8yvYwBik5QHZshJXm27nKv8q7eb4TZ6oXNEKVZbuu4zGH20s9FCPdPdZPqO8j4Rj9U5YVoPP+jbTfS4MExXoymCrx1+pTvjTDaPCbwvq/efJJ5lDSOvj4B6yT4DQIeX4RXyaGwveIZScpfSqfg4+u7q3okBlh+bCj3N1VGlFcuRWjawHtSBqcKmYUdOTtX0SmiXYLWXmrGy+mtO4uXx2ywGyi9G2cau3O7kyeSePoHSglZGMntzYby9TGJhD/n34CMbG6e1XInYEcRgD1y1Lc9OipbARuDPmpWoOeZbn7CQmxH3wj+YqKUaXWpALeqy91M2Q7zr6BjC52nTOjXmbYM1BSOiHcndhZTN2RoJOuOvAsD8ywm/MgXaAlTItjCugJNqQ4PEEhWEr2jcqavv0ZuhVnse/iU5/tnVaoXw+uWWe8IIYYAMk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199018)(54906003)(66476007)(8676002)(316002)(7366002)(7406005)(5660300002)(7416002)(8936002)(41300700001)(4326008)(478600001)(110136005)(66556008)(66946007)(6666004)(186003)(6512007)(26005)(6506007)(53546011)(7336002)(2616005)(6486002)(31696002)(36756003)(86362001)(2906002)(4744005)(44832011)(38100700002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clhFWm15TTVzRXM1dkh2UEd5dkNKMEs1Vyt1NURRUXgrOUUyV0w5QWEvMEJz?= =?utf-8?B?WWUrQ3pSSWJrbURnY05pcmVLWmJHS2dibi9sRlNEVU1uVEkvT3d5ajdEODlw?= =?utf-8?B?RVJpZWMyNDhDU3lOWDg0RWNXeWhVOGpMa2dzNlFvVTEzV3o3SHJ3Y09ZT0ty?= =?utf-8?B?by9VNWg5bFBTRzhqNGJOT3J4T3MvWjl3VFJnWDZyS3lycHhLY01jYWY0QjlN?= =?utf-8?B?dFZlMGloYmRkcmQ5SkZtdlJJRmI1VEsxQzZ0SHUzQk9TM2RyQkJwbHJTRW9B?= =?utf-8?B?NkFpWmpFNmxPbHpxVFE2dktLSFltOWE2UCtMZDZ3WjE3b3BZajM5cC9VdzZj?= =?utf-8?B?M1NpVXA3STR3bnRZU2hjR1A4YnVDMitldTNuUHp5YkpvZzgzTms1RWdiU2dD?= =?utf-8?B?bUdaTU5mWXNUbWU2dTRrcU01b1pyYXVTeHJPd0huRFFFalFYOTh2NjBMS2gw?= =?utf-8?B?RGxMaTdoQ0ZYYWIrN0sxcmVBWVJBbE5PQ3VCTFQwMUVzYmc3QVk0YWtyNkhI?= =?utf-8?B?VSsxeExWaWwranFmQzlERE9tYnZISVlmSTVlRkt5c09sMDhoTGpNSitreWY3?= =?utf-8?B?ZGlkMEdEdTRuN3BYWnI5ZXVOMTNCdXBabTVoL2cxM3pEa21VTmtnYWxqL0RD?= =?utf-8?B?d1E5R1BsTEtVcVpWOVBuZmdSbW91czMyc3lIZGZadWlDeXNHclBIOVBTVW1C?= =?utf-8?B?Mk9QTlNVMm8veFNHM2svZkx2dG5obSt4RUFzVDcwdDFKVFdWUnk2anVQQXBO?= =?utf-8?B?Yk1xYWhTUmw4RXV4VW9TMFFvYndLdW1hYjhZUWd6Smh3Z2tJaW5kMUdhTk5Z?= =?utf-8?B?MTZJbmVEekhEN2FoakllYUZWa3pCbEFzaXBSWUhIMEMxY0V0OXBqeXlvMFBy?= =?utf-8?B?MEJSYXFiZU1lTDFBMWN4L1FuMFJVMHFWRFRFYTMzNDlzcWdpZVJTZVJYZE9Y?= =?utf-8?B?VXhLVDhZNlg5TVFLTy9UL1IxNmxMUDZpMmF4UXp6c2hGR01oRVI4WDZGYmlu?= =?utf-8?B?MXMzU0RXSzdzWFI4eFlNOEllSUFERERyRlREeWdPdFBaMlVGTGZXVGVnd2lk?= =?utf-8?B?ai9oNVREV0FXZ3VvbXhaWW1DQXlWS1dvcnZFS3NWS0xsQzB0MldtaTFMYUMz?= =?utf-8?B?K3RQT1VDV1ZzcUp0bUJ1WmZNaFBKQXdYMEFrVllmajFUL1NlTHpSRzNLOUg1?= =?utf-8?B?eUdKdFdvNGhoK05xcCtuZmdiT0s5MVVMTU9hTzdyZU5aWC85Vnd3KzFqcm1Y?= =?utf-8?B?ZnQ4Qm9PcjBlQ2p0cUxkWngxT0RvSlVuUjF0dTZiREFuUEVLZEZjbkF1Vm1Q?= =?utf-8?B?RXp2OURaNnpTT3c3NzBneTR6L29yeVRmMVZScFFhbGJyMitlOW1yL1dqdVQz?= =?utf-8?B?RG9RcHg4TXp1NnVtdVUxRjYxY1FhRWJSVFFmWTMxRXd4NCsyTVNQVTgxWURj?= =?utf-8?B?WXUxdExXVVpJRXNPTkpFZThrTjcxMmlJa2IwL0EwQXVSK3ZkK1hocWErMUpO?= =?utf-8?B?eVRuRy9lL2E0c0s2bkVlMEJWekwvdWhGNjg2UlE2bHZqOFN6NWVVbWxPTmti?= =?utf-8?B?Vk5hRVBDOTUwcGc1MnNTOGd6TEZQUE5lUVNNSEJGVy9mYWpUSUZPcXVNNEVG?= =?utf-8?B?RUJwL1RaMnNLK2syK3h3dWY0eEZrUC9iRGJ3T2RWajRwT0pzV3FoVzFDQWh2?= =?utf-8?B?ZTJkMm84d2JWSHZoWjlaQ1lDNlQ4b0VocnV5QW8rNWc0ckxhR1BsellrQS9t?= =?utf-8?B?ZmJscmRJUnhyZ0FUbktRRXlaclFtaTRoNkJJUmZiMVVrd2RrdjcyakVXOGVr?= =?utf-8?B?UnVxdDRlVGFYd09TajJiM3BqZXB1dkdQM3RVMlA1MWNmcUNJSG5DdWFWb3ZD?= =?utf-8?B?RS9QenJDM2p3eHEyTHVvZlpQTDlkL2N2TWo3YzRjcVByVEg1RnpxWFI1Q1ln?= =?utf-8?B?MlY2L25SM21YdStFd1ZHdUZtRkRJNlVqL2JobmlzWUxna29DcEFOZ1JNdStI?= =?utf-8?B?ZW1yWXRyM3F3Y1JtWEwzc1plVVg0UjZXZzlDWlYyS1I3NWF5N0RZZndKQXNS?= =?utf-8?B?bENndkxPY0s5cjFjWFlaOElvcFV6QVZiM0VmZjAyd0ttOURNK1VqQ2doRW9Z?= =?utf-8?Q?m8jIzGzdXGdlo6c11gBeXT8rH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c930602-90dc-4ba7-14c0-08db09c3c2d4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 11:00:59.8289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fytaz6aIoweMGKVJKtEvjC1DYFu0EYY6dQlV5wWUjb8sW97uLXoJ6WEih2yttYzQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4575 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: >>> +RTE_TRACE_POINT( >>> + rte_ethdev_trace_set_mc_addr_list, >>> + RTE_TRACE_POINT_ARGS(uint16_t port_id, >>> + const struct rte_ether_addr *mc_addr_set, uint32_t >> nb_mc_addr, >>> + int ret), >>> + rte_trace_point_emit_u16(port_id); >>> + rte_trace_point_emit_ptr(mc_addr_set); >> What about recording this as blob? >> But 'mc_addr_set' is array of addresses, so length needs to be >> 'RTE_ETHER_ADDR_LEN * nb_mc_addr'. > The mc_addr_set pointer can be NULL in rte_eth_dev_set_mc_addr_list. In that case the > blob function will give seg fault. Hence I think blob cannot be used here. Does it make sense to make 'rte_trace_point_emit_blob()' accept NULL and fill all array with 0 in that case to cover this kind of cases?