From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58E78A0543; Wed, 14 Dec 2022 12:04:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E904A400D6; Wed, 14 Dec 2022 12:04:45 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2056.outbound.protection.outlook.com [40.107.244.56]) by mails.dpdk.org (Postfix) with ESMTP id A7C284003F for ; Wed, 14 Dec 2022 12:04:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a0uPEfbWiiovsP3EQpUqfDZLlie6FrSNjtFd5KBxyeyNFZUVPNzUfjKLtYTBgrJUj6g2Rv8guUec+wJW24BeHnFw5jULyY7g35she3En7dlIScpLtUU4hG0pO1Sjw6zntXd2m/FDkDvj9c74nHT1/G0efhF57QobSi1FoGOQ9mz2m+5126MT/YWMwsQzjLbPS5mBBrR1Zc6siCXm/GM20HWm4zhnh3pzamftvD2H2BpzO+OroYFXZcsIdM6LXxS3lLrduvhbqOA54hf2jDaElIjTFDKoV5L7hZHrDt37C+XOkLNnxXGm4K40Uw297fu1hGwF00RNhrExCuGbfXrmgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9Uagig0PnRCtHY9PKvwDdhfcqhqwXNZTApewDeYBkc=; b=jjeT/dC2avswpQPNzuk9o06VAakgyPm7rurRzpps3KsmDIjB2KT6/SeSjmjUL3lp8dIPYNz3GPAj0usbFKXWBFBxyq62Kjpibxlbi9oFSXkDtCpyaHi0UuyTP94J3ni1fLvuwAxEM1VfeiWjThmwFRt39piAWjrSyUUKdDlxgeBbyYlKBi2d16brpAwKeSP5Ko/sSFDcDTFtflabxlUtPVIu65LBWxC9VtXYun6gjmyi/Af3rKLl0LhTjMP4Ze40Ta7vOZvrQEb5/NMh8pF5pVWXpT5gdJAxic49KctEPYSRlQ7Op/FEC1Zg5cRhcVWojNzho+Sr11rYyC5KuBVSnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9Uagig0PnRCtHY9PKvwDdhfcqhqwXNZTApewDeYBkc=; b=jkeP2zZNk+1ofBAGqNoOj5w/npMnJTMivW8UEXnVVUFJ9NxWOOeDoTAeCiltXe4PzANqCMcCFLgHt0dwW+86LHJ/3Yt25r9dEfTD9/Vaas+CM4vDaBufE9tBz+4VzXt8tFSIrB5sk493sAmwf1R+mAUcrE6lxYbyu2GzzHFo/Rs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7661.namprd12.prod.outlook.com (2603:10b6:208:426::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 11:04:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 11:04:39 +0000 Message-ID: Date: Wed, 14 Dec 2022 11:04:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 1/4] ethdev: add trace points Content-Language: en-US To: David Marchand Cc: Ankur Dwivedi , dev@dpdk.org, thomas@monjalon.net, mdr@ashroe.eu, orika@nvidia.com, ferruh.yigit@xilinx.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com References: <20220929102936.5490-1-adwivedi@marvell.com> <20221006151844.23483-1-adwivedi@marvell.com> <20221006151844.23483-2-adwivedi@marvell.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0132.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7661:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b4b3182-394f-4549-c4d0-08daddc2fe87 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l+zi6dveJOg6/Bq7kZPZz8PGRmIkS+Guz6wEGktc1j6pXRCvgatD2HxKzZtGldBnVck5I5jJzkn/J/VhuWZnutpXlb8ra8YI1IYWw04/dqGilWcz35j+J6tZcH1R8SMZi49AgVviyebRUp6nH8exlCLxBc6aBV5o3FxVf8TyyFMrntAcMwsuVPI9HSUfrRjClaBnl3In3JqNh83zgaZIWKb54hu7HkoBIGP1TpbwP82UbDOQCxY06q/ETq13G2TNUh8ULTi2FsTwifnOE9C9Xtn3Bw4Frxab6lx6ANqChgZMM9vb77jkrNewhpF8Cqpqy0u93jcc4elMK9/Lih6T5LHeyYbLkEFWobDW8S34w6oGKupgmIAshlzJ98XuZkvK2FgKijt/wVwiiQQOxOSqJcg6MsjrjLv57XpsT+gsdZ8GW0qXmc+0g1gWYUUbZpd3FoPQhfxrhls1qbAitG5EGGCCpGRZT+eppSvdZVMRScok0Jv2A51+h6zY1psZlnY/kYKMoI+0vmkg/lp76dRxbnPqrec9jvULK/VvCQAFrBC8NQtv7zuyvxVnLE7AN71q9p5mJhVsvvLowr+hi7UW9PhoiVfh5r7kajg0vsnK7fB3ReuZUf+YqxRgnxgIxZJ4DduIfItE3xqaY9yK8y4XNN7r8c26LjWhhaDhEqd9UeaPFcoW9npC/ryok/dfe1ZAdSVXHpxjmnrwvSh529hjb1xi+ncNmArLE+tMK8KGF58= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(451199015)(6486002)(478600001)(66556008)(83380400001)(6666004)(31686004)(6506007)(53546011)(6512007)(186003)(26005)(66476007)(7366002)(2906002)(7336002)(5660300002)(7406005)(316002)(7416002)(36756003)(66946007)(2616005)(8676002)(4326008)(8936002)(6916009)(31696002)(44832011)(86362001)(41300700001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clBISVZrRzFHOTdEK3VxUE93bU1VTVh1eGpBL2xLd3k5ZXZUS2xvZ0xUMzNs?= =?utf-8?B?ZEhLT1RtUjNoMFdZVWpBeWJtZ0kzWTQvOWlyRWR1V0ROKzNqWEN5bW9lRlc3?= =?utf-8?B?QzJiMkZMZHhONkpBWmVPbmovbFJIYS9DbGtUOUg5ZWozYXk0bGtwS0xXTVN0?= =?utf-8?B?OXZwdVppZjNiL0Y5MWxlcld1VEJFSTJ5bjJLQ3JYRjVDd2dLdENaVTlFR0N4?= =?utf-8?B?R1BMRGpTMDVaRi82L2hiYmI2aFZObHVRNzRIYXk1eFNBOWtQTmdzZXo2UElj?= =?utf-8?B?dzh6ejhid0g0MURaK0dPZjZyQ01iSFNBTG15bnZJalVsMHAwWVVNdStjMURv?= =?utf-8?B?MzBFVlpjempwOXRIY0d6UmxKZ25lYWxQZ1RyOWxLWWdCUDU5aExFYXZHTCt4?= =?utf-8?B?NzZLYU43cHFzRTlhM2Z2aVY0RmU4WTNhdlQ3UDR6VmFxTjFyeEZXbTZUekNC?= =?utf-8?B?ak5Xb1g4Wk1wZXQ2dFkwdjBlUnZHTHBRWXBQcXJLdklvL0p2TzVvaytZcnJG?= =?utf-8?B?V3U0YlRET1E4Vmk3V0ZsQ1NTV1F0bW5qZ2tsWmErR1d2aFFVY2ZIY1hwc2NM?= =?utf-8?B?YXQyL3AycmMzS25ZNEl3TTBQaG9GSGNiVmxySUMyRGRKUnJOeHp0cmlJdmo3?= =?utf-8?B?cUFaUlh5VjRCQ0pybHJiazdRby9neVJmSGZBWmxxc3VIUzU1alByN3ZqV1dt?= =?utf-8?B?Mkg3UHJnaUVTL0lNM1NBbW9VaGp5QndHRmNqMng4cFFSc0R5OUZHalhSK3Rz?= =?utf-8?B?OVd2WXM0RHVpbWpmNm5XOXpWd3VHM2kyc1RtUW9yVVlXZ2ZnS01WZkFSS1Y0?= =?utf-8?B?aXdtQ0drTXVocUpib0FVVkRUVE9BNHFtVjY0UjRVZGY4TlhFNUVZR1RsaUFY?= =?utf-8?B?ME5JRHBEemJ6Y0h2akVDeVhXYzZQRnpKeUFTRVZ6b3prS3FyNk5XYWtiUW1s?= =?utf-8?B?QlhjZFovWitucjVMNENpRisxL0o1TzJDZDVCV282amtOUkxNYVVOS2hrSndw?= =?utf-8?B?dDIvQlo2TEk3MGRJTW5NRjlGSEdWZzg4alJ5ZW93VW4zVS81Nnc5WXNlMVJl?= =?utf-8?B?VGYrbzU4MFhrRUpoQkg3TlQ3L0pCYzlyMS93T2xnYmtUYm9ZL2UzbWs4OXY5?= =?utf-8?B?VGcrTFQwNk4xLy9POS82eDQzcTFpb3FuSFprZlZRV2RlWS9LQWtwOGNSYjg4?= =?utf-8?B?QWZRSnVpODJMTUdBeXZmenFtdFZFaTRqT1hMSnZUeGVLb3pKVjlXRzJnSkhV?= =?utf-8?B?M1JwWUtobTYvOXZNSEFTQjBJL1NTTVZCRGt1MHlJRG9SNUlRMHE3cG9SbkFF?= =?utf-8?B?TXpUTGFBcnhxUVpYYjhuZ2pvTmcvT3dUekpKWTVKMTNlWDdyQXN6WG16ZnJB?= =?utf-8?B?NkxWWURJSlZCRzhRSjhRUVBHMXltUHJybjUrQ0lUa1NOWEdFbVcrcnZWRlJy?= =?utf-8?B?QVNYaXliV2xnclVkQTVRQWlpNk9PaFVoYjBHa01NTWtNbVZqZjJHN3hLaFhB?= =?utf-8?B?OGVEYWRLNkc3UkZjZjlPUWwyQTd2NGVCbkJmdExQSnFRVEQ2M1UzZlN3NFJm?= =?utf-8?B?cmw4Nnd5dUJCS05WNlBmSytFSkJJTmE0TXdwd1AwekxSZ2xJVGpxRC9vVC9F?= =?utf-8?B?U0piZHlyWnlVSEFDWk91WXpDcmlmSTBmSkhMcnE1YytLanc5TmxUKzlVR0dh?= =?utf-8?B?aVBHTVJwWkdnRUxrZDUrM3hIUHp1VWMrVExYdnltbzlYT3JvZCtIa3dHQlhy?= =?utf-8?B?VWQ2cFdIOUdWbVFzTU15Z2hMaFR5bVlUaG5kV2lrbDlueFBIMXN4dXdMcTU1?= =?utf-8?B?ZWdLQkk4bUQvZVFOd2Z6TVFEWC9FU0RBY2hzcEZ2ME04U2xhWE9xbExWTzJT?= =?utf-8?B?VHk0WjdCbmlqVnZsZ2lWSWtWbFM0TnkrRk0rRXBIYW1hSDVVeVM0UmVKR3Fv?= =?utf-8?B?NTVPQWZybEhNTEtPZ3VDZnZNNzN4Z0pwV1R6ZHNRRFFrNkFQMWNVSSt0U2lq?= =?utf-8?B?ZWZtMnBiMmVJczlFME04OWFJU1ZTOFRkOEF1U0UzT3hyd2ErN1ZjYmdoYjFr?= =?utf-8?B?KzBvK3YxYkFYbDJ2UFJoamNTUlJVaGIzL1JrK1F0QlVCaitvY2k5SnVWZHN4?= =?utf-8?Q?uDveWuaqlplZ97F0akYrpoFz7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b4b3182-394f-4549-c4d0-08daddc2fe87 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 11:04:39.3332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sIphEMpJuaiYhk3/hmc1DP85v2m48z4+3WLLGW5+RdB41bBeXAg8PrIaSThIHpH9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7661 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/14/2022 10:34 AM, David Marchand wrote: > On Mon, Dec 12, 2022 at 7:38 PM Ferruh Yigit wrote: >> >> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: >>> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map >>> index 3651ceb234..79d0b2ee1f 100644 >>> --- a/lib/ethdev/version.map >>> +++ b/lib/ethdev/version.map >>> @@ -319,4 +319,148 @@ INTERNAL { >>> rte_eth_representor_id_get; >>> rte_eth_switch_domain_alloc; >>> rte_eth_switch_domain_free; >>> + __rte_eth_trace_add_first_rx_callback; >>> + __rte_eth_trace_add_rx_callback; >>> + __rte_eth_trace_add_tx_callback; >>> + __rte_eth_trace_allmulticast_disable; >> >> >> These are not trace functions, but trace point objects, I see this is >> common usage in other libraries too, but can you please explain why we >> need to export the trace point objects from the .so file? >> >> For some datapath functions, which are static inline functions, trace >> point objects are need to be accessible by application, it is OK to >> export them, but they are very limited, but I am not clear why exporting >> all of them is required. > > There should be no need to export them. > The only usage I can think of is when calling a tracepoint from a > public inline helper. > Like '__rte_ethdev_trace_rx_burst' & '__rte_ethdev_trace_tx_burst', which are used by 'rte_eth_rx_burst()' & 'rte_eth_tx_burst()' static inline functions.