Re: [dpdk-dev] [PATCH v3 1/4] vhost: inroduce operation to get vDPA queue stats

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 6/4/20 12:36 PM, Wang, Xiao W wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Wednesday, June 3, 2020 4:58 PM
>> To: Matan Azrad <matan@mellanox.com>; Viacheslav Ovsiienko
>> <viacheslavo@mellanox.com>
>> Cc: dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>; Wang, Xiao W
>> <xiao.w.wang@intel.com>
>> Subject: Re: [PATCH v3 1/4] vhost: inroduce operation to get vDPA queue stats
>>
>> Hi Matan,
>>
>> On 6/2/20 5:47 PM, Matan Azrad wrote:
>>> The vDPA device offloads all the datapath of the vhost device to the HW
>>> device.
>>>
>>> In order to expose to the user traffic information this patch
>>> introduces new 3 APIs to get traffic statistics, the device statistics
>>> name and to reset the statistics per virtio queue.
>>>
>>> The statistics are taken directly from the vDPA driver managing the HW
>>> device and can be different for each vendor driver.
>>>
>>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>>> ---
>>>  doc/guides/rel_notes/release_20_08.rst    |   5 ++
>>>  doc/guides/vdpadevs/features/default.ini  |   1 +
>>>  doc/guides/vdpadevs/features_overview.rst |   3 +
>>>  lib/librte_vhost/rte_vdpa.h               | 115 +++++++++++++++++++++++++++++-
>>>  lib/librte_vhost/rte_vhost_version.map    |   3 +
>>>  lib/librte_vhost/vdpa.c                   |  47 ++++++++++++
>>>  6 files changed, 173 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/doc/guides/rel_notes/release_20_08.rst
>> b/doc/guides/rel_notes/release_20_08.rst
>>> index 39064af..d6f09bd 100644
>>> --- a/doc/guides/rel_notes/release_20_08.rst
>>> +++ b/doc/guides/rel_notes/release_20_08.rst
>>> @@ -56,6 +56,11 @@ New Features
>>>       Also, make sure to start the actual text at the margin.
>>>       =========================================================
>>>
>>> +   * **Added vDPA device APIs to query virtio queue statistics.**
>>> +
>>> +     A new 3 APIs has been added to query virtio queue statistics, to get their
>>
>> s/A new 3 APIs/3 new APIs/
>>
>> Other than this minor typo, it looks all good to me.
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> I would like Intel feedback on this new API. If no feedback by June
>> 12th, I'll merge it as-is (no need to resend for the typo, I'll fixup
>> while applying).
>>
>>
>> Xiao, does the API sound right to you?
>> Do you have Virtio counters in your IFC device that you could expose?
>>
>> Thanks in advance,
>> Maxime
> 
> This stats API looks flexible. IFC virtio stats is not queried from virtio VF, so I think for now
> IFC won't expose stats via this API.
> 
> Acked-by: Xiao Wang <xiao.w.wang@intel.com>


Thanks Xiao for the feedback, so it's all good to me.

Maxime
> BRs,
> Xiao
>