From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDBC6A034E; Fri, 21 Jan 2022 11:05:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE4FC4273F; Fri, 21 Jan 2022 11:05:40 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C7E264273E for ; Fri, 21 Jan 2022 11:05:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642759539; x=1674295539; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=dO5NkWOXIjSu+5XExqE1EtpIiQtjEfj9P8wByF1j1IA=; b=P6TJPQ3lE+AnVNUtfg+0WwuVwutadXnl0hapkzjFEXvxgc9YacKUcdyk oXmflv0vBmJmsFhKYzfeCp8ejX0ZzChOn4ftCsYeyC6s6jGUXk3f2SeDX ZMUeJZcOqcHbAfaJQ3x+qC3q+LOU1HLArAYKZ1t7lUURQyERUnddAlNmx eYpxE2+N4q/cqsogldDnNVpV+XxMRZtqviWP3EGqSqn8vyo4Co/7CXv6/ kBlTetFOvYF6UYziEVBD6PQN8fd51kdCknfTvJLNMEohavade70oX7khA nq6IC5XwHnyUuhkJXBpG0HC6dt+wIQA7+l5t4mBfOlLTr4iAjuLRFT9Qf A==; X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="245403976" X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="245403976" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2022 02:05:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="765660209" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 21 Jan 2022 02:05:37 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 21 Jan 2022 02:05:36 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 21 Jan 2022 02:05:36 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 21 Jan 2022 02:05:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b4c8E87NqiDbXE6Gu+fEMB0yEYXphsXrKu34AkK9G3aUkCN4pEy2w3f+SKF+q4h9Vsk5mQ4d+7q5U9V5ZcM7TLFu5m9PYvHSywkcLBhr/osyUgKgmDkLRyTXaoOAjTPB7IVwQg9mXXujUKnW4Zlndko2VVY0V5++DcdlpipQEVi2Co4Fv2ydKZFde+wTc82NYMd7v4Yrm3FrVoufQkbWg95wQ9F8zH6adDXBVQJ+4PxkHgUOUeZaT7vvTM1fk5MuFJmjwRGe625K2zcCNrZBnGC7IkwWF36tA9iyUG7tqfgUbV+ZRhcPI4OYdkcUbolwEwZ3UWCiWecj9/vcsGLbRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lEgg/ASHrfAXNFJ8dryzAVq7RPiVjAONGDh2AitmAKs=; b=b2RcSoKcIY6syEcwcMEa8LLAw2jJkjurriK+evlKrtnZKZ1uzuWj9XdL/wy3ajgO04WssXm2UFlN23GcCzK800x8s/fBa8cxB+6qeZV1pz602FcMubIli++vKtsVK6dKnh0auknVFk6kJ44kpveN9tkgFVjVurh3A4ZJsJ+uZ2sm1+fnfcgXKH4dhdIXnfm9OZPwhyTFAhJ9ljxkfFkjKWMeWS8fN23j1e5mts2g71K7jX77q8ZLuZs0tcvJgbW3BxNR/b2l4EdEcCQ47X3p11V9YnbKi9qPRpozm/Ggsuchse8/XiTJQu9DOeTYq+6HnjH2r2J1cpB7ZEXMrPoOFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Fri, 21 Jan 2022 10:05:35 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.010; Fri, 21 Jan 2022 10:05:35 +0000 Message-ID: Date: Fri, 21 Jan 2022 10:05:29 +0000 Content-Language: en-US To: Nithin Dabilpuram , , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao CC: , Gowrishankar Muthukrishnan References: <20211209091342.27017-1-ndabilpuram@marvell.com> <20211209091342.27017-6-ndabilpuram@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH 6/8] common/cnxk: handle issues from static analysis X-User: ferruhy In-Reply-To: <20211209091342.27017-6-ndabilpuram@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0104.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a4fc637-48f1-41aa-c7cb-08d9dcc590f5 X-MS-TrafficTypeDiagnostic: MN2PR11MB4448:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6I4Ls6zcv1w25mH4CbvscTbYHr50bfetRfSR4h/qP4i95rjmjy6dKZdMgnRNQHD1Rw/pJS9oGdfus4eznaAtV/XpfdWVvwlEtRdpWbUEVqx+Kbneze0blhWBBeLSc7XGPewk9RwpahXvMCMYpkrMaRzZ/UP7/p8QbMtOnpfxsxmjtFpVa2B3FAzlubpPbIxjmhqtTzNeIjeWlcZy1XxPidKofrp0eTAbdv/UmrhxqyKmPaaQG7hCfPOlHzThzCUvBuOPLDN/CJqhq4Bi6x+MI0SDhYdMwEgiruT/Dx072EAgYJWNghs5nIa6/dXrK1/H3ycN7Wxl6DOu7wqv/d7C2NSD/ib5Xbjqt6xvbKpIoZ7f+3aBj7YZeT/5jj7BRkJW104CKYX3plg/jy4CpOP+GyFlZCh8IXGJLpcWymrSBQKYW69rrvLJjWOnJ/N5CXeiUax1WB6LhzHaGushGZ3AN6fHc/n5L/+iWewlLsR+pPMc/UuaOJfi+8UUnoUwvzI+l4IIvuRk18ao8dxTSB2RYEnlgiUucQ7kN4r4f1rhojumF6n5hXDAbmljGaPASnvzZ7TWr9yJdePXIf5gaxavsw5tW9zuywRoIYNr6CPpVOIbvwIdsBp7ORWiplEGPrKZDNeCYm+jN/WdUuwMCeKF7UcrZ3lpePuMZYXLzARqI747jYMtyCYGQuOjhA7Hhn39UHuO0qohbfelIUvb7fJN2g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(6486002)(186003)(6666004)(26005)(44832011)(8936002)(4744005)(6512007)(6506007)(2906002)(8676002)(53546011)(508600001)(31696002)(86362001)(4326008)(31686004)(5660300002)(82960400001)(316002)(66556008)(66476007)(110136005)(38100700002)(66946007)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkZIRWhFVFVVUmsySGtqTlZOSy9xMStBb2tkczFiMUh5Q3JCV2NGdUk5VWhJ?= =?utf-8?B?YlQ2TWs5TlIveEs0akZtYVhRUXhhZVBuYndQbjduOEU5cGZMMmRTY3RUbnp6?= =?utf-8?B?SStkczZZb0RJUEtFdVEyUkdNSHJFQjRUaWZ3QXZ0MkFyb0NBUkRhWlZ4Q2N3?= =?utf-8?B?L3JqZG5ycGkvZG1ubnhqTnRtZWo1MGlZd0dqQ1dSdDlWaEp3VUNlc080blE3?= =?utf-8?B?bEh2cVZKaDFMUnA2bDhzU2xuWnc2UmNyRlNaN0VIaTZNc0xzNHpCZDhnTFc5?= =?utf-8?B?YzMvYis3Z2xtaFhuYm5zQlVkdTBkYit3ZldFcDdXRjJ1ZTZJb1dJbDFtdFgv?= =?utf-8?B?NC9OS01QR01IMmZ5VERGT2Y2a0xXenJRS0ZoNmY4ejJTcXFiTGdWY20zZEQr?= =?utf-8?B?bmtXWXZ1czNSc2tnQXdaYzF0cDNGVWtZSEgrWll5aW5paFRBK0dQeVRiT2J2?= =?utf-8?B?STNaRXNOeTI4Tk1hd1pZVnk5bnlZcm95UWxCa1dFbmhMVTU4TkN6YU5OVEQx?= =?utf-8?B?YXU1d2V1ODVqeElUVzRRSy9UVm91ZHhVcG9hQ3gvdnRUanA5djk1SU00RWdx?= =?utf-8?B?YnFhbmROWWd2ODJhK0diNmNPNUdjYm9MVW5OWElLYmozNFZNYXVTaXNtNGk3?= =?utf-8?B?ZjhZaEJmcTZhYk4xSDRiSXVyd0xNSFNoNU9UVlBFWnhBeFQxeWVxS1FjTDlm?= =?utf-8?B?TnBtOG9EY0dNd1JaOTNCZ3d0Rjd2L0VDYmx5UUFpYzhkRXEzK05heDB5Q0hm?= =?utf-8?B?YXNPdDRQajUrTU9odlh4YzFnWlA5aFFKVGhVVk1RZEp4TTVhK0tFa0JFWjlt?= =?utf-8?B?SkVyR0F5SXRhZUx5RmREUzhFYlJBZEUycHVjTVNNdG1TTTlQWjJCdjNpdU9s?= =?utf-8?B?NlZPdFp1RTdpdmEzYzRKRE5qMm41c3BEclRuZnUwTE1ORDR0K21vNVpLWnRM?= =?utf-8?B?eVhKS1VsNHVJamlNbk55UEh3aFJDeG5wT2JqMlJFbm5UM3g3S1ltdXhYWFcv?= =?utf-8?B?WjRzWndTQ0ZzbFJSOHF6RUxINTRmNnMzNDByeFRNem1uWjc5THUvYStiN3lD?= =?utf-8?B?RXM3elJ2SHc3VWgvUHIyVzNLcDU1YnpHZ292WkxvY0JPbk1OZVpTdVJXaVdN?= =?utf-8?B?OWdPc05lalhHdlJPV0tZZEFCc3JYZVIrdGM1VndpNkxDNk93R3ZGWHZlcHVn?= =?utf-8?B?MEJhNG81RDh1Ym8vaU1WUSsrNnV2L1NjY080VkVUTExpMVAzZmxMMnB4UEVh?= =?utf-8?B?MTQvejh2U01MdHZ4cllWVnhhZlFkbHRBcllOVXUyYWhxL0ZMMk5IY3RwampO?= =?utf-8?B?dWtxY2lNc0tFWGxJejFJd1EvOGR0WG53UVUzTTQrWlRKUjFjVEgxSjJ6aGZL?= =?utf-8?B?emJyS3BwaWNReGdSWXN5SjJDdFVFT1lsQnlOM1lOc2o0emlsVlovR1pTbjBG?= =?utf-8?B?b1ZWRFNlZ3plU0tXaXQwOFZuZzZyMHF1WTVJTDBGYkxRWGdUY0RkUjRZUmpn?= =?utf-8?B?bWJoUHo4OVB2UTcxbVFRVGNKRlNSTVBrOXNlanlYTW1SMWxPS2tuRDdHc1F1?= =?utf-8?B?cDNrSVZxOEZQNVFDZ0pxc2RBVHlLRUhqVDhidGVXQXFqUXVZNEZpeGtkMjJn?= =?utf-8?B?ajNpVmpSZW1td1F3dHRKZlpJaUk1OFlTK3VLaFZCSllXV1FWWUdENWlUT3JX?= =?utf-8?B?Zkp1SjVWbWwxbitlZ0J4MnFvcWZrN3luQ0V4eXJKY1BTQXdMWU5GRGQ5cGFz?= =?utf-8?B?ekl5QkU5UmtDNGlXa2VFNWJhbTBYdXMvRDlhOFBGOVFWQlgrQlV1L1BCbTJC?= =?utf-8?B?eGxscmFpZHM5dk9jOFlxaThBbGFVcUV6VllWRGhCeVZFRDg1NVNsWDlIUS8z?= =?utf-8?B?Nm4vRmNZV08wZXg0MUIxWlgzK29lMTJYeWxKUDd3Y2RheEh6R0E5Y04yWG5S?= =?utf-8?B?MjVsaTJyZDJkSGZ3MlBjNVBGMjkyVU9hd2h5WklsbjBHN3NzMUVCeE9TZDly?= =?utf-8?B?VHQ4L3QxcXZUTVBWUUNYbEwxcmQxekM1eURGNTliSHY4b09aVzFuQlpkdWV4?= =?utf-8?B?K1duaTNxQnJMZXA1OEl5T2lmRzlYRHFaLzltZUhEUEt6MVFnVTB5T1V1bkpR?= =?utf-8?B?M1pTNVdiYkdweTMzbDBtSHBqTlF6QXlieElkY2FvcGh6Q09WZS8zQkM2MmlW?= =?utf-8?Q?92sDOOpErYaUA1e1oWjUS/Q=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1a4fc637-48f1-41aa-c7cb-08d9dcc590f5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 10:05:35.1141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: upH7PZLOxuIkJ5J+pe13a64zYWtkqSdXvJPZ2VfsZqowwILHuHjLaL3UIV0TmY82lL1DRC8r+dQQhJ35q7IR6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4448 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/9/2021 9:13 AM, Nithin Dabilpuram wrote: > From: Gowrishankar Muthukrishnan > > Handle issues reported by static analysis tool such as > null pointer dereferences, variable initialization, etc. > > Signed-off-by: Gowrishankar Muthukrishnan > Signed-off-by: Nithin Dabilpuram Hi Gowrishankar, Nithin, On its own static analysis issues fixed is not very descriptive, can you please split the patch to the fix types, like: - fix null pointer derefences - fix variable initialization ...