From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EFCB4233B; Mon, 9 Oct 2023 13:05:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CF94402E9; Mon, 9 Oct 2023 13:05:17 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 9487D4026B for ; Mon, 9 Oct 2023 13:05:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696849515; x=1728385515; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=kxkjlpk7GDBbP53+mxtuZ67NS6RA/nlQkdkcfnU7zdc=; b=h3PXrIRxOIIb1Qry3ej2aQIq+9s80rVmLjv31HHvGgDfHRkHNtM+pQ0e g+vu4aK8TZ6bsHPLs/pV6f3Ekmcq9tuCLl35RLE7iX+C1x0cYHuXTAQ/g 5yxkrUpwG94etNiSDWtBlAsJLDb3QlhoLqnistfk6Vbu8jhSiRUA+gk7O 3urTogKvBybnbWNS7B1aJwuWlGFl2Pnj0BIgbdtYjaAq/Xm3fzzZAMk9n W2vW/HaOs3Sc2oHvmm4x8GN7QwpYgtfy30w10OoLQKLtwdY1PshSLcFu3 f333fqxU2eh39FaP1i3O5lSoJMP4dIc7T1/z4/dtAIF/PMw3eHQOBoEpc A==; X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="415107182" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="415107182" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 04:05:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="782456679" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="782456679" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Oct 2023 04:05:14 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 9 Oct 2023 04:05:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 9 Oct 2023 04:05:13 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 9 Oct 2023 04:05:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fw3Embkad3/nv4fofZXPT3K2CPDzSvzDEqCF3P1/mQMKNkADIDg/tb4AR1ERF9ze3QVC+/siQnbsvdyAJgPUyI2fV1MFnRmKW8zrlOIHR1kP9Qg8qwT2j0eC4Ushd5eajA3RhE8YYBy6QDJim6jzRHCkNAkg3qPEpXOr+frzIrSkgFUYx5SiEwjithri+LB/s6lejKn1T4qUTv4H7ThRMGSyJyCVAQr0T072+qJr4pHG+UO8xSGlbckKErs6K+9QtEZfjRPVLAtjbxAxkvJwamIHjROHLgN5nAF4LdgWUHIeH2r44iD8UIIcAaV+N/jX8lGQXUnap2INkkXfOVLBig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kxkjlpk7GDBbP53+mxtuZ67NS6RA/nlQkdkcfnU7zdc=; b=E3g/38M56VtqYmYt82mfz19gjo0Ik+44ZNWiO+iWtmTYTluSPsTWtQrJRV/u+lU0MJghcjT5scaHDkr2NdGVRSDLiY4Xr/+r1pl+GpfMWMjjWijV7khNSI2qkGqxzovK0xkuwZ5Pm514CQwxQ+EkybhmqyZJsd/MjUJJFmzq1q5Yg29D1eiSiOYIntOP0pON91GBcN1c4wODCM7C8EXFsgBi9pPxfb/r2OHXafL36egrstzFPmdBU57k5TQ3uE3uAYsQIJ3Bp4pjSQVZ8wMqSPq76yMTriORUHGmj6QKBuNG4q08N89Fb5gNArDxDIM47WAquvq1JG3oF17kW/eAMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BL0PR11MB3108.namprd11.prod.outlook.com (2603:10b6:208:7e::14) by CH0PR11MB5249.namprd11.prod.outlook.com (2603:10b6:610:e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Mon, 9 Oct 2023 11:05:11 +0000 Received: from BL0PR11MB3108.namprd11.prod.outlook.com ([fe80::c2f3:5b14:a96c:20ea]) by BL0PR11MB3108.namprd11.prod.outlook.com ([fe80::c2f3:5b14:a96c:20ea%4]) with mapi id 15.20.6863.032; Mon, 9 Oct 2023 11:05:11 +0000 Message-ID: Date: Mon, 9 Oct 2023 13:05:06 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mem: allow using ASan in multi-process mode Content-Language: en-US To: David Marchand , CC: References: <20231004142308.15395-1-artur.paszkiewicz@intel.com> From: Artur Paszkiewicz In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0193.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::19) To BL0PR11MB3108.namprd11.prod.outlook.com (2603:10b6:208:7e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR11MB3108:EE_|CH0PR11MB5249:EE_ X-MS-Office365-Filtering-Correlation-Id: 13d70a5a-e39a-4ad4-838e-08dbc8b79afe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XsEUdk2nWxzmu1+gnkVpl893tCSBSMIWLrE6/pdy3I+gTmv99Dihq8iYb0n9Kke4e/gf3ZJeUxOcCNQLirIx/VRrSqUOuigq2kD8agHRJFERJS1bw5OUjLagL+Te7Fk4L4RvSA+fkhj/jsbjofL8bhTIX9ZLVcXTEpfab9XCFvlkMIpEqwMwQbtDtjYjt5y/Ik1ml1aZlxd9eJgZ3Az3memx8AfssmEsu8Y/epd0HERn9fnUaYI6OV6dWi3d5J35f8yqwVhT4zuYPpYQ2UlMBfdpxTmXldjVSYLokhmkbDIlbknjNuyJnxOusKRAg7lkGjpYsuA6u8t6yiz0g5LtY60AHXAMhcXBuHoFPXTXZsBdo+rs2FZnJEnRc6m97ECoxgcHpoQKAm8DHRbJPqaoE3FOYJstpGKL9sJgkUk5bmFVQedPeZKdOxPI6s0MrlZhz2Wh4xkPiZLw5GNjQUnen59N2BzVR49tQ0hSDpsqnt88YacTi71iAPbLkUZyBtbjaVXOORrC90SdydPICxUv2GT73FCVe7potG92/GPhafGiBS4EZ8yVE5ORQ5RUWUWyurG02ANihNeW1fRCEVOUiDcZETR8nBAIXw24wtq+skvntA4S2k+WvK6856cLEh23c8KFYAPlOPug8QvWnKeXCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3108.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(376002)(366004)(39860400002)(136003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(53546011)(2616005)(26005)(478600001)(6506007)(6512007)(6666004)(8676002)(83380400001)(2906002)(4326008)(8936002)(66556008)(66476007)(66946007)(6486002)(41300700001)(44832011)(316002)(6636002)(5660300002)(38100700002)(36756003)(31696002)(86362001)(82960400001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anNWeUxxaTNMN3IwZURwOGE3NloxRlJyU3YzUStpZEZzQUNqU3l6WExrUnZS?= =?utf-8?B?bkliaTJrY1Q5bFhodzRtOTFBWVIyRjRBL2I5a2Y1ZExoa3k5S1poWUhGSnpZ?= =?utf-8?B?Qnk5VXN6RnFpRnhrR1lvVk1obTNmK21qWFRJY2MvdWlLbmxkK3JrVVVXNjBr?= =?utf-8?B?S1hwcW5XYTVpR2dRRXN0RnUyMDlGdlhGVG1OOTlvN0FrOWVnZFhuenlvVGlT?= =?utf-8?B?c0lhVFdZUU9jS2Y4NlhuU2xnYTB3MUNBQlhuVTZPMUJhc2tENWtRNExXZmxB?= =?utf-8?B?dTZFMVRSLzZBbzV2M0lXT21ETi9yMm5YNTFRN1FhUS9xWVZaZEZyazhPQ0gx?= =?utf-8?B?VFpOQnN6ZFNiOFNhd2hSZ1ZuR3QvRGhXSHFHeWlZZlZFc2t1Y053bWd2ZHFn?= =?utf-8?B?aUp4VTNZZGJXNE5DaDJ6Rm9hWVh3UFBYUHZzNjZWQ3drMHUxeFFvN1NQRWNM?= =?utf-8?B?aEV5WVRZQjVuZ2FYZ1IvWFRVRzk3L2R1aHE1S0hTdTFKS1czTDQyL0RkMThH?= =?utf-8?B?eUVpTTloTnRHYlRyMWJDc2FndWJ2MVBFTjU4bEltY1JOSWNXc2dBZ2Z1d1E0?= =?utf-8?B?dGVXZlVUR1l1Tk51RitNbjlJUEVQQWIxMjZKaHRRWVNXK0pFK2JVcHFmRXNE?= =?utf-8?B?VUhRTkdYdmsrMlJpa2xsdmVUWVFpdm1PamtERzNkdmdSVjdHOWZuVVg0K1d3?= =?utf-8?B?aS9RTm8vaFFQa0RqRkxkSFd1SXNhclJDUlFZTXRqbWxZd00zbFB5VDg3by96?= =?utf-8?B?V3I4VFBmd1NERGJad2M2bXNwY2ZtTkpXejR5THZWRDh1OWhmMHdGc0ZtcGx2?= =?utf-8?B?T2hWZVI4L01iTVRsZ1AxLzJBN3kzRzFESUJDWEsrWUw5ZkhJK1k0TEJFbHBT?= =?utf-8?B?YllCWFV1NFpPbloxYUQ0cmVFUjBoQzd4ZVN5TW12NlNSV2VTZUVMQzQrV0Z4?= =?utf-8?B?UE1wc3RCdTJXbHlQbzlQTU9zdC8zQ28veWxmVkhZbXN4MEp0TWV5d2NIQW1s?= =?utf-8?B?MkVWVWtNTGNJNktxSG9pTzI5N0FtNWVlOGtObHVSTCswelVYQ2ppRWVlSDlJ?= =?utf-8?B?WUlGTGNqRmJLdUhCMVh3OStTejRSYU1rUUloNUgrYjQrZjBjaE8xb2s4Wk50?= =?utf-8?B?aThJb0l4QllkaUY0Si8yT210K05PcUJxVzBESUtVWTFwL0xZV2xGTTJMYWJH?= =?utf-8?B?VUJ3TmhsTzlrdDdpK2gvVkhFY0xEN2U5aCsya1NIK2tuMko1ejU2WWdjdU9W?= =?utf-8?B?K1NLR25iU1JsaG9aSXl0MWE2UXpBMHJ0MnEvcEoxcms0d3JTSG9OMzQ5RTAr?= =?utf-8?B?VFI0ZHN2dEpKcUJvTEM1bmR3TkVpY1FoUXFKbGpXQ204Y1hqbjhJaFVjbkhu?= =?utf-8?B?dEZMc2lsbDNvMUN3dE85QVhxazhpa0JzaUFDcnZrSStZcmQ4azFFWlI1NTZQ?= =?utf-8?B?aFlPMFlVSzl3K09VSE8xTG9LeTJibmRoRG9nSy9GTWp5S0IvT2xBNjhrWmxm?= =?utf-8?B?VHJjVHJxZmg4bEx2VW95UGNBcnkwWE9VU1d2eGxJcXNkcldNQkhBOTlHTjM3?= =?utf-8?B?TW93aEhQSHllTXVsanRiK3NRRjBkVmEvd1ZhNFJRSG9CMjROblpadEU2NU5J?= =?utf-8?B?emlSZVBtaG9yd21yVCtVR256cEU5KzNaOE0zOW51c1lXalVVV0NXaS9CbGUx?= =?utf-8?B?VjdXZWcwdEtCSzZtL2k3WDdvWVYrbzV0bUdUTks0NnNTM05kbXJ1a2I3Ymp0?= =?utf-8?B?SlJUdjdPMnFDbFlmeUNBeHh0aVV4Q1dPU2V3MGlPdE5Sa1ZpdEpvektQMDdQ?= =?utf-8?B?d0tmYWRpcVJ2UVdlS1pxWE1SQ2ZBSi8xSlF6TzE1ZTJna1R0c3VnUHFOd004?= =?utf-8?B?eG8zUVM1WFNTQjJPSEsrUVNtek9FM2pSUVgwQ3pFajZ5eU9CRTUvRkNpOXZ5?= =?utf-8?B?RGlHVzBvbmlvaWlMVytYeXFzd3JlV3gzQ1JCYWFJU0hTWHpDV2RJWEcyQStH?= =?utf-8?B?TXErNEc4aDFMSGU5MVlQb29zOXZLaitORUZzNFhlaGRQZTFSdlNEM2RrTnFU?= =?utf-8?B?Mkt3MzJtRTFLWitwcGQ5cjZQNWdzUVpsTGE4OFNZMzFVMk9ZT3VHc0NTTVd4?= =?utf-8?B?Yk9IWVdiT2x5RFgxK1QyWHh3UXQ3dTJmWTFTK2liVEc2aW9HcTRSTmpBOFkz?= =?utf-8?B?eWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 13d70a5a-e39a-4ad4-838e-08dbc8b79afe X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3108.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 11:05:11.0298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ETPYgDAXlJ8cZUEILP8Sir9zoWeNqvekxOAfFOe2dL9J+8fEo1So0tXcisXPpwL8eQ42N4BEgxRvLXy1/eTTXFFge5yd4hIRFoGHhMuVmtw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5249 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/4/23 16:51, David Marchand wrote: > - did you test with --in-memory mode? with --no-huge? Please see v2 of the patch. I added checks for these options. They imply no multi-process support so mapping is skipped for those cases. > - I did not look at the patch, but I wonder if there is a risk some > "local" ASan region (for the process heap, for example) can overlap > with some "shared" ASan region (for shared DPDK hugepages). I don't think it's possible unless the actual memory regions overlap. The ASan shadow region is always at a fixed offset from the memory it shadows. Also, this patch only makes the shadow regions shared, ASan instrumentation already uses these regions. > - with this work, would unit tests (that were marked failing with > ASan) be ok now? See REGISTER_FAST_TEST macro in app/test. I tried enabling these tests and some of them started passing with this patch, namely: - multiprocess_autotest - eal_flags_c_opt_autotest - eal_flags_main_opt_autotest - eal_flags_a_opt_autotest eal_flags_file_prefix_autotest still fails. The rest seem to be passing even without the patch. Regards, Artur