From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1DBAA052A; Tue, 2 Feb 2021 13:57:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDDC92402D8; Tue, 2 Feb 2021 13:57:20 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id ADF022402DA; Tue, 2 Feb 2021 13:57:19 +0100 (CET) IronPort-SDR: rJS4huM2KdmPX+cw+boeER+XwMby21NGICedATJSMRAl87eeDiY8lfVS7qNvERbfgadFgN0pL+ 0uv0ZKNKqOQw== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180923524" X-IronPort-AV: E=Sophos;i="5.79,395,1602572400"; d="scan'208";a="180923524" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:57:17 -0800 IronPort-SDR: uMEysldsekO7FC49ecT7BnJdMg1Y++eKEHTq600xGXqmWpWxPmsa2OuQurjdcVDRmYym6+At0S FHe68Bl1Vfvw== X-IronPort-AV: E=Sophos;i="5.79,395,1602572400"; d="scan'208";a="391453326" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:57:16 -0800 To: Hyong Youb Kim Cc: dev@dpdk.org, stable@dpdk.org, John Daley References: <20210202002423.954-1-hyonkim@cisco.com> From: Ferruh Yigit Message-ID: Date: Tue, 2 Feb 2021 12:57:12 +0000 MIME-Version: 1.0 In-Reply-To: <20210202002423.954-1-hyonkim@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: fix the filter type used for flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/2/2021 12:24 AM, Hyong Youb Kim wrote: > The filter type (struct filter_v2.type) should always be set to > FILTER_DPDK_1, when advanced filtering is enabled in > firmware. Otherwise, for some old firmware versions, the driver sets > it to FILTER_USNIC_IP, and attempts to install filters fail. This > behavior matches that of the now-removed flow director implementation > (enic_clsf.c). > > Fixes: 26faa126d87e ("net/enic: flow API for NICs with advanced filters disabled") > Cc: stable@dpdk.org > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Applied to dpdk-next-net/main, thanks.