From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0D8BA0C47; Tue, 26 Oct 2021 02:57:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A21DD40A4B; Tue, 26 Oct 2021 02:57:00 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 511954003E for ; Tue, 26 Oct 2021 02:56:58 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HdYJQ0ywSz1DHtG for ; Tue, 26 Oct 2021 08:55:02 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 08:56:40 +0800 Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 08:56:40 +0800 To: Kevin Laatz , CC: , References: <20210910172737.2561156-1-kevin.laatz@intel.com> <20211014095311.1311617-1-kevin.laatz@intel.com> From: fengchengwen Message-ID: Date: Tue, 26 Oct 2021 08:56:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20211014095311.1311617-1-kevin.laatz@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v4 0/8] port ioatfwd app to dmadev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kevin, We test whole patch set and found it should add one judgement: the ring_size should be less than or equal to MBUF_RING_SIZE. If ring_size greater than MBUF_RING_SIZE, the tracking DMA bufs may be overwrited when the DMA copy is not in time. Thanks. On 2021/10/14 17:53, Kevin Laatz wrote: > This patchset first adds some additional command line options to the > existing ioatfwd application to enhance usability. > > The last 3 patches of this set then port the ioatfwd application to use the > dmadev library APIs instead of the IOAT rawdev APIs. Following the port, > all variables etc are renamed to be more appropriate for using with the > DMAdev library. Lastly, the application itself is renamed to "dmafwd". > > Depends-on: series-19594 ("support dmadev") > > --- > v4: > - rebase on dmadev lib v26 patchset > v3: > - add signal-triggered device dump > - add cmd line option to control stats print frequency > - documentation updates > - small miscellaneous changes from review feedback > > Kevin Laatz (5): > examples/ioat: add cmd line option to control stats print interval > examples/ioat: add signal-triggered device dumps > examples/ioat: port application to dmadev APIs > examples/ioat: update naming to match change to dmadev > examples/ioat: rename application to dmafwd > > Konstantin Ananyev (3): > examples/ioat: always use same lcore for both DMA requests enqueue and > dequeue > examples/ioat: add cmd line option to control DMA batch size > examples/ioat: add cmd line option to control max frame size > > .../sample_app_ug/{ioat.rst => dma.rst} | 149 ++--- > doc/guides/sample_app_ug/index.rst | 2 +- > doc/guides/sample_app_ug/intro.rst | 4 +- > examples/{ioat => dma}/Makefile | 4 +- > examples/{ioat/ioatfwd.c => dma/dmafwd.c} | 632 ++++++++++-------- > examples/{ioat => dma}/meson.build | 10 +- > examples/meson.build | 2 +- > 7 files changed, 427 insertions(+), 376 deletions(-) > rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (64%) > rename examples/{ioat => dma}/Makefile (97%) > rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (60%) > rename examples/{ioat => dma}/meson.build (63%) >