From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65CEEA0503; Thu, 19 May 2022 10:07:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5878540222; Thu, 19 May 2022 10:07:15 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id BBEDD40150 for ; Thu, 19 May 2022 10:07:14 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 604948A; Thu, 19 May 2022 11:07:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 604948A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1652947634; bh=a6Wir56CGSS6aS80PkWLAOuOpLlXmf0QtavcpS9AGAY=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=DWIWKe5RG3DxPVqhlywRRP2pMC7jZa0X2LFwlFHr5zrNDdYQHy5QLwJxoDMvmi8DC NFJTe/U3kF4zKFNErwFlI9n0L0yMOCiUW64LrSjSKalIPAT3jVRxnAUk5l95TVns5n zjOUIDjo+p963/7mSl2M2NYOSNzhY7woCCgvTiNI= Message-ID: Date: Thu, 19 May 2022 11:07:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Content-Language: en-US From: Andrew Rybchenko To: Pankaj Gupta , Jochen Behrens Cc: dev@dpdk.org References: <20220503042257.15626-1-pagupta@vmware.com> <20220519080415.1577680-1-andrew.rybchenko@oktetlabs.ru> Organization: OKTET Labs In-Reply-To: <20220519080415.1577680-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pankaj, I did final cleanup before applying the patch series, but realized that release notes update is missing. Please, pick up my changes and amend patches which support new features with release notes update in the documentation. Everything else LGTM now. Thanks, Andrew. On 5/19/22 11:04, Andrew Rybchenko wrote: > v6 (Andrew Rybchenko): > Minor style changes in patches description > Split FW version get patch to have callbacks reorder seperately > Minor fix in FW version get patch to put callback definition, > assignment and implementation just after device info get > > v5: > Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c > User RETA instead of reta in commit message > Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c > > v4: > Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error > in initialization for rxDataRing feature" to > "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" > > v3: > adding Reviewed-by info in all the patches > > v2: > address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru > > Pankaj Gupta (9): > net/vmxnet3: add version 5 support > net/vmxnet3: implement RETA query and RETA update > net/vmxnet3: add Rx queue usage count utility > net/vmxnet3: fix ethdev callbacks init order > net/vmxnet3: report HW version on FW version get > net/vmxnet3: add version 6 support > net/vmxnet3: advertise RETA size in device info > net/vmxnet3: set packet type for fragmented packet > net/vmxnet3: fix merge error in Rx data ring initialization > > drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- > 4 files changed, 388 insertions(+), 88 deletions(-) >