* [dpdk-dev] Questions about rte_eth_link_speed_to_str API @ 2021-09-13 8:45 Min Hu (Connor) 2021-09-13 10:26 ` Thomas Monjalon 2021-09-16 2:56 ` [dpdk-dev] [RFC] ethdev: improve link speed to string Min Hu (Connor) 0 siblings, 2 replies; 16+ messages in thread From: Min Hu (Connor) @ 2021-09-13 8:45 UTC (permalink / raw) To: dev; +Cc: Ferruh Yigit, Thomas Monjalon, Declan Doherty, Keith Wiles Hi all, I have questions about rte_eth_link_speed_to_str API. The API converts link speed to string for display, But it only supports the following speeds, like that: case ETH_SPEED_NUM_NONE: return "None"; case ETH_SPEED_NUM_10M: return "10 Mbps"; case ETH_SPEED_NUM_100M: return "100 Mbps"; case ETH_SPEED_NUM_1G: return "1 Gbps"; case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; case ETH_SPEED_NUM_5G: return "5 Gbps"; case ETH_SPEED_NUM_10G: return "10 Gbps"; case ETH_SPEED_NUM_20G: return "20 Gbps"; case ETH_SPEED_NUM_25G: return "25 Gbps"; case ETH_SPEED_NUM_40G: return "40 Gbps"; case ETH_SPEED_NUM_50G: return "50 Gbps"; case ETH_SPEED_NUM_56G: return "56 Gbps"; case ETH_SPEED_NUM_100G: return "100 Gbps"; case ETH_SPEED_NUM_200G: return "200 Gbps"; case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; default: return "Invalid"; In some cases, like bonding, for example, three slaves which link speed are 10Gbps, so link speed of bonding port will be 30Gbps, but it shows "Invalid". Is this reasonable？ any comments will be welcome. Best wishes ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API 2021-09-13 8:45 [dpdk-dev] Questions about rte_eth_link_speed_to_str API Min Hu (Connor) @ 2021-09-13 10:26 ` Thomas Monjalon 2021-09-14 3:25 ` Min Hu (Connor) 2021-09-16 2:56 ` [dpdk-dev] [RFC] ethdev: improve link speed to string Min Hu (Connor) 1 sibling, 1 reply; 16+ messages in thread From: Thomas Monjalon @ 2021-09-13 10:26 UTC (permalink / raw) To: Min Hu (Connor); +Cc: dev, Ferruh Yigit, Declan Doherty, Keith Wiles 13/09/2021 10:45, Min Hu (Connor): > Hi all, > I have questions about rte_eth_link_speed_to_str API. > The API converts link speed to string for display, But it only > supports the following speeds, like that: > case ETH_SPEED_NUM_NONE: return "None"; > case ETH_SPEED_NUM_10M: return "10 Mbps"; > case ETH_SPEED_NUM_100M: return "100 Mbps"; > case ETH_SPEED_NUM_1G: return "1 Gbps"; > case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; > case ETH_SPEED_NUM_5G: return "5 Gbps"; > case ETH_SPEED_NUM_10G: return "10 Gbps"; > case ETH_SPEED_NUM_20G: return "20 Gbps"; > case ETH_SPEED_NUM_25G: return "25 Gbps"; > case ETH_SPEED_NUM_40G: return "40 Gbps"; > case ETH_SPEED_NUM_50G: return "50 Gbps"; > case ETH_SPEED_NUM_56G: return "56 Gbps"; > case ETH_SPEED_NUM_100G: return "100 Gbps"; > case ETH_SPEED_NUM_200G: return "200 Gbps"; > case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; > default: return "Invalid"; > > In some cases, like bonding, for example, three slaves which > link speed are 10Gbps, so link speed of bonding port will be > 30Gbps, but it shows "Invalid". > > Is this reasonable？ any comments will be welcome. Is it meaningful to print combined slaves speed? If yes, we can do better then this fixed switch/case logic, it shouldn't be too hard given it is a standard uint32_t value. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API 2021-09-13 10:26 ` Thomas Monjalon @ 2021-09-14 3:25 ` Min Hu (Connor) 2021-09-14 6:59 ` Stephen Hemminger 0 siblings, 1 reply; 16+ messages in thread From: Min Hu (Connor) @ 2021-09-14 3:25 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Ferruh Yigit, Declan Doherty, Keith Wiles Thanks Thomas, I am not sure if we need to print combined slaves speed. How about others' opinion ? @all BTW, If yes, one possible option may be like that: +const char * +rte_eth_link_speed_to_str(uint32_t link_speed) +{ + char name[16]; + + if (link_speed == ETH_SPEED_NUM_NONE) + return "None"; + if (link_speed == ETH_SPEED_NUM_NONE) + return "Unknown"; + if (link_speed < ETH_SPEED_NUM_1G) { + snprintf(name, sizeof(name), "%u Mbps", link_speed); + } else { + snprintf(name, sizeof(name), "%u Mbps", + link_speed / ETH_SPEED_NUM_1G); + } + + return name; +} But the float value is difficult to handle, like 2.5 Gbps for show. Any advices? 在 2021/9/13 18:26, Thomas Monjalon 写道: > 13/09/2021 10:45, Min Hu (Connor): >> Hi all, >> I have questions about rte_eth_link_speed_to_str API. >> The API converts link speed to string for display, But it only >> supports the following speeds, like that: >> case ETH_SPEED_NUM_NONE: return "None"; >> case ETH_SPEED_NUM_10M: return "10 Mbps"; >> case ETH_SPEED_NUM_100M: return "100 Mbps"; >> case ETH_SPEED_NUM_1G: return "1 Gbps"; >> case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >> case ETH_SPEED_NUM_5G: return "5 Gbps"; >> case ETH_SPEED_NUM_10G: return "10 Gbps"; >> case ETH_SPEED_NUM_20G: return "20 Gbps"; >> case ETH_SPEED_NUM_25G: return "25 Gbps"; >> case ETH_SPEED_NUM_40G: return "40 Gbps"; >> case ETH_SPEED_NUM_50G: return "50 Gbps"; >> case ETH_SPEED_NUM_56G: return "56 Gbps"; >> case ETH_SPEED_NUM_100G: return "100 Gbps"; >> case ETH_SPEED_NUM_200G: return "200 Gbps"; >> case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >> default: return "Invalid"; >> >> In some cases, like bonding, for example, three slaves which >> link speed are 10Gbps, so link speed of bonding port will be >> 30Gbps, but it shows "Invalid". >> >> Is this reasonable？ any comments will be welcome. > > Is it meaningful to print combined slaves speed? > If yes, we can do better then this fixed switch/case logic, > it shouldn't be too hard given it is a standard uint32_t value. > > > . > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API 2021-09-14 3:25 ` Min Hu (Connor) @ 2021-09-14 6:59 ` Stephen Hemminger 2021-09-14 13:04 ` Min Hu (Connor) 0 siblings, 1 reply; 16+ messages in thread From: Stephen Hemminger @ 2021-09-14 6:59 UTC (permalink / raw) To: Min Hu (Connor) Cc: Thomas Monjalon, dev, Ferruh Yigit, Declan Doherty, Keith Wiles On Tue, 14 Sep 2021 11:25:44 +0800 "Min Hu (Connor)" <humin29@huawei.com> wrote: > Thanks Thomas, > I am not sure if we need to print combined slaves speed. > How about others' opinion ? @all > > BTW, If yes, one possible option may be like that: > +const char * > +rte_eth_link_speed_to_str(uint32_t link_speed) > +{ > + char name[16]; > + > + if (link_speed == ETH_SPEED_NUM_NONE) > + return "None"; > + if (link_speed == ETH_SPEED_NUM_NONE) > + return "Unknown"; > + if (link_speed < ETH_SPEED_NUM_1G) { > + snprintf(name, sizeof(name), "%u Mbps", link_speed); > + } else { > + snprintf(name, sizeof(name), "%u Mbps", > + link_speed / ETH_SPEED_NUM_1G); > + } > + > + return name; > +} > > But the float value is difficult to handle, like 2.5 Gbps for show. Any > advices? > > 在 2021/9/13 18:26, Thomas Monjalon 写道: > > 13/09/2021 10:45, Min Hu (Connor): > >> Hi all, > >> I have questions about rte_eth_link_speed_to_str API. > >> The API converts link speed to string for display, But it only > >> supports the following speeds, like that: > >> case ETH_SPEED_NUM_NONE: return "None"; > >> case ETH_SPEED_NUM_10M: return "10 Mbps"; > >> case ETH_SPEED_NUM_100M: return "100 Mbps"; > >> case ETH_SPEED_NUM_1G: return "1 Gbps"; > >> case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; > >> case ETH_SPEED_NUM_5G: return "5 Gbps"; > >> case ETH_SPEED_NUM_10G: return "10 Gbps"; > >> case ETH_SPEED_NUM_20G: return "20 Gbps"; > >> case ETH_SPEED_NUM_25G: return "25 Gbps"; > >> case ETH_SPEED_NUM_40G: return "40 Gbps"; > >> case ETH_SPEED_NUM_50G: return "50 Gbps"; > >> case ETH_SPEED_NUM_56G: return "56 Gbps"; > >> case ETH_SPEED_NUM_100G: return "100 Gbps"; > >> case ETH_SPEED_NUM_200G: return "200 Gbps"; > >> case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; > >> default: return "Invalid"; > >> > >> In some cases, like bonding, for example, three slaves which > >> link speed are 10Gbps, so link speed of bonding port will be > >> 30Gbps, but it shows "Invalid". > >> > >> Is this reasonable？ any comments will be welcome. > > > > Is it meaningful to print combined slaves speed? > > If yes, we can do better then this fixed switch/case logic, > > it shouldn't be too hard given it is a standard uint32_t value. > > > > > > . > > Since all the values are encoded numerically do some math. This is what iproute2 has evolved to doing.. int print_color_rate(bool use_iec, enum output_type type, enum color_attr color, const char *key, const char *fmt, unsigned long long rate) { unsigned long kilo = use_iec ? 1024 : 1000; const char *str = use_iec ? "i" : ""; static char *units[5] = {"", "K", "M", "G", "T"}; char *buf; int rc; int i; if (_IS_JSON_CONTEXT(type)) return print_color_lluint(type, color, key, "%llu", rate); rate <<= 3; /* bytes/sec -> bits/sec */ for (i = 0; i < ARRAY_SIZE(units) - 1; i++) { if (rate < kilo) break; if (((rate % kilo) != 0) && rate < 1000*kilo) break; rate /= kilo; } rc = asprintf(&buf, "%.0f%s%sbit", (double)rate, units[i], i > 0 ? str : ""); if (rc < 0) return -1; rc = print_color_string(type, color, key, fmt, buf); free(buf); } ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API 2021-09-14 6:59 ` Stephen Hemminger @ 2021-09-14 13:04 ` Min Hu (Connor) 0 siblings, 0 replies; 16+ messages in thread From: Min Hu (Connor) @ 2021-09-14 13:04 UTC (permalink / raw) To: Stephen Hemminger Cc: Thomas Monjalon, dev, Ferruh Yigit, Declan Doherty, Keith Wiles Thanks Stephen, While I think this option is more clear and simple: +const char * +rte_eth_link_speed_to_str(uint32_t link_speed) +{ +#define SPEED_STRING_LEN 16 + static char name[SPEED_STRING_LEN]; + + if (link_speed == ETH_SPEED_NUM_NONE) + return "None"; + if (link_speed == ETH_SPEED_NUM_UNKNOWN) + return "Unknown"; + if (link_speed < ETH_SPEED_NUM_1G) { + snprintf(name, sizeof(name), "%u Mbps", link_speed); + } else if (link_speed % ETH_SPEED_NUM_1G != 0){ + snprintf(name, sizeof(name), "%.1f Gbps", + (double)link_speed / ETH_SPEED_NUM_1G); + } else { + snprintf(name, sizeof(name), "%u Gbps", + link_speed / ETH_SPEED_NUM_1G); + } + + return (const char *)name; +} How about any others' opinions, thanks. 在 2021/9/14 14:59, Stephen Hemminger 写道: > On Tue, 14 Sep 2021 11:25:44 +0800 > "Min Hu (Connor)" <humin29@huawei.com> wrote: > >> Thanks Thomas, >> I am not sure if we need to print combined slaves speed. >> How about others' opinion ? @all >> >> BTW, If yes, one possible option may be like that: >> +const char * >> +rte_eth_link_speed_to_str(uint32_t link_speed) >> +{ >> + char name[16]; >> + >> + if (link_speed == ETH_SPEED_NUM_NONE) >> + return "None"; >> + if (link_speed == ETH_SPEED_NUM_NONE) >> + return "Unknown"; >> + if (link_speed < ETH_SPEED_NUM_1G) { >> + snprintf(name, sizeof(name), "%u Mbps", link_speed); >> + } else { >> + snprintf(name, sizeof(name), "%u Mbps", >> + link_speed / ETH_SPEED_NUM_1G); >> + } >> + >> + return name; >> +} >> >> But the float value is difficult to handle, like 2.5 Gbps for show. Any >> advices? >> >> 在 2021/9/13 18:26, Thomas Monjalon 写道: >>> 13/09/2021 10:45, Min Hu (Connor): >>>> Hi all, >>>> I have questions about rte_eth_link_speed_to_str API. >>>> The API converts link speed to string for display, But it only >>>> supports the following speeds, like that: >>>> case ETH_SPEED_NUM_NONE: return "None"; >>>> case ETH_SPEED_NUM_10M: return "10 Mbps"; >>>> case ETH_SPEED_NUM_100M: return "100 Mbps"; >>>> case ETH_SPEED_NUM_1G: return "1 Gbps"; >>>> case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >>>> case ETH_SPEED_NUM_5G: return "5 Gbps"; >>>> case ETH_SPEED_NUM_10G: return "10 Gbps"; >>>> case ETH_SPEED_NUM_20G: return "20 Gbps"; >>>> case ETH_SPEED_NUM_25G: return "25 Gbps"; >>>> case ETH_SPEED_NUM_40G: return "40 Gbps"; >>>> case ETH_SPEED_NUM_50G: return "50 Gbps"; >>>> case ETH_SPEED_NUM_56G: return "56 Gbps"; >>>> case ETH_SPEED_NUM_100G: return "100 Gbps"; >>>> case ETH_SPEED_NUM_200G: return "200 Gbps"; >>>> case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >>>> default: return "Invalid"; >>>> >>>> In some cases, like bonding, for example, three slaves which >>>> link speed are 10Gbps, so link speed of bonding port will be >>>> 30Gbps, but it shows "Invalid". >>>> >>>> Is this reasonable？ any comments will be welcome. >>> >>> Is it meaningful to print combined slaves speed? >>> If yes, we can do better then this fixed switch/case logic, >>> it shouldn't be too hard given it is a standard uint32_t value. >>> >>> >>> . >>> > > Since all the values are encoded numerically do some math. > This is what iproute2 has evolved to doing.. > > > int print_color_rate(bool use_iec, enum output_type type, enum color_attr color, > const char *key, const char *fmt, unsigned long long rate) > { > unsigned long kilo = use_iec ? 1024 : 1000; > const char *str = use_iec ? "i" : ""; > static char *units[5] = {"", "K", "M", "G", "T"}; > char *buf; > int rc; > int i; > > if (_IS_JSON_CONTEXT(type)) > return print_color_lluint(type, color, key, "%llu", rate); > > rate <<= 3; /* bytes/sec -> bits/sec */ > > for (i = 0; i < ARRAY_SIZE(units) - 1; i++) { > if (rate < kilo) > break; > if (((rate % kilo) != 0) && rate < 1000*kilo) > break; > rate /= kilo; > } > > rc = asprintf(&buf, "%.0f%s%sbit", (double)rate, units[i], > i > 0 ? str : ""); > if (rc < 0) > return -1; > > rc = print_color_string(type, color, key, fmt, buf); > free(buf); > } > > > . > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-13 8:45 [dpdk-dev] Questions about rte_eth_link_speed_to_str API Min Hu (Connor) 2021-09-13 10:26 ` Thomas Monjalon @ 2021-09-16 2:56 ` Min Hu (Connor) 2021-09-16 6:22 ` Andrew Rybchenko 1 sibling, 1 reply; 16+ messages in thread From: Min Hu (Connor) @ 2021-09-16 2:56 UTC (permalink / raw) To: dev; +Cc: ferruh.yigit, thomas Currently, link speed to string only supports specific speeds, like 10M, 100M, 1G etc. This patch expands support for any link speed which is over 1M and one decimal place will kept for display at most. Signed-off-by: Min Hu (Connor) <humin29@huawei.com> --- lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index daf5ca9242..1d3b960305 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) const char * rte_eth_link_speed_to_str(uint32_t link_speed) { - switch (link_speed) { - case ETH_SPEED_NUM_NONE: return "None"; - case ETH_SPEED_NUM_10M: return "10 Mbps"; - case ETH_SPEED_NUM_100M: return "100 Mbps"; - case ETH_SPEED_NUM_1G: return "1 Gbps"; - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; - case ETH_SPEED_NUM_5G: return "5 Gbps"; - case ETH_SPEED_NUM_10G: return "10 Gbps"; - case ETH_SPEED_NUM_20G: return "20 Gbps"; - case ETH_SPEED_NUM_25G: return "25 Gbps"; - case ETH_SPEED_NUM_40G: return "40 Gbps"; - case ETH_SPEED_NUM_50G: return "50 Gbps"; - case ETH_SPEED_NUM_56G: return "56 Gbps"; - case ETH_SPEED_NUM_100G: return "100 Gbps"; - case ETH_SPEED_NUM_200G: return "200 Gbps"; - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; - default: return "Invalid"; +#define SPEED_STRING_LEN 16 + static char name[SPEED_STRING_LEN]; + + if (link_speed == ETH_SPEED_NUM_NONE) + return "None"; + if (link_speed == ETH_SPEED_NUM_UNKNOWN) + return "Unknown"; + if (link_speed < ETH_SPEED_NUM_1G) { + snprintf(name, sizeof(name), "%u Mbps", link_speed); + } else if (link_speed % ETH_SPEED_NUM_1G != 0) { + snprintf(name, sizeof(name), "%.1f Gbps", + (double)link_speed / ETH_SPEED_NUM_1G); + } else { + snprintf(name, sizeof(name), "%u Gbps", + link_speed / ETH_SPEED_NUM_1G); } + + return (const char *)name; } int -- 2.33.0 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-16 2:56 ` [dpdk-dev] [RFC] ethdev: improve link speed to string Min Hu (Connor) @ 2021-09-16 6:22 ` Andrew Rybchenko 2021-09-16 8:16 ` Min Hu (Connor) 0 siblings, 1 reply; 16+ messages in thread From: Andrew Rybchenko @ 2021-09-16 6:22 UTC (permalink / raw) To: Min Hu (Connor), dev; +Cc: ferruh.yigit, thomas On 9/16/21 5:56 AM, Min Hu (Connor) wrote: > Currently, link speed to string only supports specific speeds, like 10M, > 100M, 1G etc. > > This patch expands support for any link speed which is over 1M and one > decimal place will kept for display at most. > > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > --- > lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index daf5ca9242..1d3b960305 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) > const char * > rte_eth_link_speed_to_str(uint32_t link_speed) > { > - switch (link_speed) { > - case ETH_SPEED_NUM_NONE: return "None"; > - case ETH_SPEED_NUM_10M: return "10 Mbps"; > - case ETH_SPEED_NUM_100M: return "100 Mbps"; > - case ETH_SPEED_NUM_1G: return "1 Gbps"; > - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; > - case ETH_SPEED_NUM_5G: return "5 Gbps"; > - case ETH_SPEED_NUM_10G: return "10 Gbps"; > - case ETH_SPEED_NUM_20G: return "20 Gbps"; > - case ETH_SPEED_NUM_25G: return "25 Gbps"; > - case ETH_SPEED_NUM_40G: return "40 Gbps"; > - case ETH_SPEED_NUM_50G: return "50 Gbps"; > - case ETH_SPEED_NUM_56G: return "56 Gbps"; > - case ETH_SPEED_NUM_100G: return "100 Gbps"; > - case ETH_SPEED_NUM_200G: return "200 Gbps"; > - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; > - default: return "Invalid"; > +#define SPEED_STRING_LEN 16 > + static char name[SPEED_STRING_LEN]; NACK Nothing good will happen if you try to use the function to print two different link speeds in one log message. > + > + if (link_speed == ETH_SPEED_NUM_NONE) > + return "None"; > + if (link_speed == ETH_SPEED_NUM_UNKNOWN) > + return "Unknown"; > + if (link_speed < ETH_SPEED_NUM_1G) { > + snprintf(name, sizeof(name), "%u Mbps", link_speed); > + } else if (link_speed % ETH_SPEED_NUM_1G != 0) { > + snprintf(name, sizeof(name), "%.1f Gbps", > + (double)link_speed / ETH_SPEED_NUM_1G); > + } else { > + snprintf(name, sizeof(name), "%u Gbps", > + link_speed / ETH_SPEED_NUM_1G); > } > + > + return (const char *)name; > } > > int > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-16 6:22 ` Andrew Rybchenko @ 2021-09-16 8:16 ` Min Hu (Connor) 2021-09-16 8:21 ` Andrew Rybchenko 0 siblings, 1 reply; 16+ messages in thread From: Min Hu (Connor) @ 2021-09-16 8:16 UTC (permalink / raw) To: Andrew Rybchenko, dev; +Cc: ferruh.yigit, thomas Hi, Andrew, 在 2021/9/16 14:22, Andrew Rybchenko 写道: > On 9/16/21 5:56 AM, Min Hu (Connor) wrote: >> Currently, link speed to string only supports specific speeds, like 10M, >> 100M, 1G etc. >> >> This patch expands support for any link speed which is over 1M and one >> decimal place will kept for display at most. >> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >> --- >> lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- >> 1 file changed, 17 insertions(+), 17 deletions(-) >> >> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >> index daf5ca9242..1d3b960305 100644 >> --- a/lib/ethdev/rte_ethdev.c >> +++ b/lib/ethdev/rte_ethdev.c >> @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) >> const char * >> rte_eth_link_speed_to_str(uint32_t link_speed) >> { >> - switch (link_speed) { >> - case ETH_SPEED_NUM_NONE: return "None"; >> - case ETH_SPEED_NUM_10M: return "10 Mbps"; >> - case ETH_SPEED_NUM_100M: return "100 Mbps"; >> - case ETH_SPEED_NUM_1G: return "1 Gbps"; >> - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >> - case ETH_SPEED_NUM_5G: return "5 Gbps"; >> - case ETH_SPEED_NUM_10G: return "10 Gbps"; >> - case ETH_SPEED_NUM_20G: return "20 Gbps"; >> - case ETH_SPEED_NUM_25G: return "25 Gbps"; >> - case ETH_SPEED_NUM_40G: return "40 Gbps"; >> - case ETH_SPEED_NUM_50G: return "50 Gbps"; >> - case ETH_SPEED_NUM_56G: return "56 Gbps"; >> - case ETH_SPEED_NUM_100G: return "100 Gbps"; >> - case ETH_SPEED_NUM_200G: return "200 Gbps"; >> - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >> - default: return "Invalid"; >> +#define SPEED_STRING_LEN 16 >> + static char name[SPEED_STRING_LEN]; > > NACK > > Nothing good will happen if you try to use the function to > print two different link speeds in one log message. You are right. And use malloc for "name" will result in memory leakage, which is also not a good option. BTW, do you think if we need to modify the function "rte_eth_link_speed_to_str"? > >> + >> + if (link_speed == ETH_SPEED_NUM_NONE) >> + return "None"; >> + if (link_speed == ETH_SPEED_NUM_UNKNOWN) >> + return "Unknown"; >> + if (link_speed < ETH_SPEED_NUM_1G) { >> + snprintf(name, sizeof(name), "%u Mbps", link_speed); >> + } else if (link_speed % ETH_SPEED_NUM_1G != 0) { >> + snprintf(name, sizeof(name), "%.1f Gbps", >> + (double)link_speed / ETH_SPEED_NUM_1G); >> + } else { >> + snprintf(name, sizeof(name), "%u Gbps", >> + link_speed / ETH_SPEED_NUM_1G); >> } >> + >> + return (const char *)name; >> } >> >> int >> > > . > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-16 8:16 ` Min Hu (Connor) @ 2021-09-16 8:21 ` Andrew Rybchenko 2021-09-17 0:43 ` Min Hu (Connor) 0 siblings, 1 reply; 16+ messages in thread From: Andrew Rybchenko @ 2021-09-16 8:21 UTC (permalink / raw) To: Min Hu (Connor), dev; +Cc: ferruh.yigit, thomas On 9/16/21 11:16 AM, Min Hu (Connor) wrote: > Hi, Andrew, > > 在 2021/9/16 14:22, Andrew Rybchenko 写道: >> On 9/16/21 5:56 AM, Min Hu (Connor) wrote: >>> Currently, link speed to string only supports specific speeds, like 10M, >>> 100M, 1G etc. >>> >>> This patch expands support for any link speed which is over 1M and one >>> decimal place will kept for display at most. >>> >>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >>> --- >>> lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- >>> 1 file changed, 17 insertions(+), 17 deletions(-) >>> >>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >>> index daf5ca9242..1d3b960305 100644 >>> --- a/lib/ethdev/rte_ethdev.c >>> +++ b/lib/ethdev/rte_ethdev.c >>> @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, >>> struct rte_eth_link *eth_link) >>> const char * >>> rte_eth_link_speed_to_str(uint32_t link_speed) >>> { >>> - switch (link_speed) { >>> - case ETH_SPEED_NUM_NONE: return "None"; >>> - case ETH_SPEED_NUM_10M: return "10 Mbps"; >>> - case ETH_SPEED_NUM_100M: return "100 Mbps"; >>> - case ETH_SPEED_NUM_1G: return "1 Gbps"; >>> - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >>> - case ETH_SPEED_NUM_5G: return "5 Gbps"; >>> - case ETH_SPEED_NUM_10G: return "10 Gbps"; >>> - case ETH_SPEED_NUM_20G: return "20 Gbps"; >>> - case ETH_SPEED_NUM_25G: return "25 Gbps"; >>> - case ETH_SPEED_NUM_40G: return "40 Gbps"; >>> - case ETH_SPEED_NUM_50G: return "50 Gbps"; >>> - case ETH_SPEED_NUM_56G: return "56 Gbps"; >>> - case ETH_SPEED_NUM_100G: return "100 Gbps"; >>> - case ETH_SPEED_NUM_200G: return "200 Gbps"; >>> - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >>> - default: return "Invalid"; >>> +#define SPEED_STRING_LEN 16 >>> + static char name[SPEED_STRING_LEN]; >> >> NACK >> >> Nothing good will happen if you try to use the function to >> print two different link speeds in one log message. > You are right. > And use malloc for "name" will result in memory leakage, which is also > not a good option. > > BTW, do you think if we need to modify the function > "rte_eth_link_speed_to_str"? IMHO it would be more pain than gain in this case. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-16 8:21 ` Andrew Rybchenko @ 2021-09-17 0:43 ` Min Hu (Connor) 2021-10-30 9:59 ` Morten Brørup 2023-01-19 11:41 ` Ferruh Yigit 0 siblings, 2 replies; 16+ messages in thread From: Min Hu (Connor) @ 2021-09-17 0:43 UTC (permalink / raw) To: Andrew Rybchenko, dev; +Cc: ferruh.yigit, thomas Agree with you. Thanks Andrew 在 2021/9/16 16:21, Andrew Rybchenko 写道: > On 9/16/21 11:16 AM, Min Hu (Connor) wrote: >> Hi, Andrew, >> >> 在 2021/9/16 14:22, Andrew Rybchenko 写道: >>> On 9/16/21 5:56 AM, Min Hu (Connor) wrote: >>>> Currently, link speed to string only supports specific speeds, like 10M, >>>> 100M, 1G etc. >>>> >>>> This patch expands support for any link speed which is over 1M and one >>>> decimal place will kept for display at most. >>>> >>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >>>> --- >>>> lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- >>>> 1 file changed, 17 insertions(+), 17 deletions(-) >>>> >>>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >>>> index daf5ca9242..1d3b960305 100644 >>>> --- a/lib/ethdev/rte_ethdev.c >>>> +++ b/lib/ethdev/rte_ethdev.c >>>> @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, >>>> struct rte_eth_link *eth_link) >>>> const char * >>>> rte_eth_link_speed_to_str(uint32_t link_speed) >>>> { >>>> - switch (link_speed) { >>>> - case ETH_SPEED_NUM_NONE: return "None"; >>>> - case ETH_SPEED_NUM_10M: return "10 Mbps"; >>>> - case ETH_SPEED_NUM_100M: return "100 Mbps"; >>>> - case ETH_SPEED_NUM_1G: return "1 Gbps"; >>>> - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >>>> - case ETH_SPEED_NUM_5G: return "5 Gbps"; >>>> - case ETH_SPEED_NUM_10G: return "10 Gbps"; >>>> - case ETH_SPEED_NUM_20G: return "20 Gbps"; >>>> - case ETH_SPEED_NUM_25G: return "25 Gbps"; >>>> - case ETH_SPEED_NUM_40G: return "40 Gbps"; >>>> - case ETH_SPEED_NUM_50G: return "50 Gbps"; >>>> - case ETH_SPEED_NUM_56G: return "56 Gbps"; >>>> - case ETH_SPEED_NUM_100G: return "100 Gbps"; >>>> - case ETH_SPEED_NUM_200G: return "200 Gbps"; >>>> - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >>>> - default: return "Invalid"; >>>> +#define SPEED_STRING_LEN 16 >>>> + static char name[SPEED_STRING_LEN]; >>> >>> NACK >>> >>> Nothing good will happen if you try to use the function to >>> print two different link speeds in one log message. >> You are right. >> And use malloc for "name" will result in memory leakage, which is also >> not a good option. >> >> BTW, do you think if we need to modify the function >> "rte_eth_link_speed_to_str"? > > IMHO it would be more pain than gain in this case. > > . > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-17 0:43 ` Min Hu (Connor) @ 2021-10-30 9:59 ` Morten Brørup 2021-11-01 0:23 ` Min Hu (Connor) 2023-01-19 11:41 ` Ferruh Yigit 1 sibling, 1 reply; 16+ messages in thread From: Morten Brørup @ 2021-10-30 9:59 UTC (permalink / raw) To: Min Hu (Connor), Andrew Rybchenko, dev; +Cc: ferruh.yigit, thomas > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Min Hu (Connor) > Sent: Friday, 17 September 2021 02.44 > > Agree with you. Thanks Andrew > > 在 2021/9/16 16:21, Andrew Rybchenko 写道: > > On 9/16/21 11:16 AM, Min Hu (Connor) wrote: > >> Hi, Andrew, > >> > >> 在 2021/9/16 14:22, Andrew Rybchenko 写道: > >>> On 9/16/21 5:56 AM, Min Hu (Connor) wrote: > >>>> Currently, link speed to string only supports specific speeds, > like 10M, > >>>> 100M, 1G etc. > >>>> > >>>> This patch expands support for any link speed which is over 1M and > one > >>>> decimal place will kept for display at most. > >>>> > >>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > >>>> --- > >>>> lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- > >>>> 1 file changed, 17 insertions(+), 17 deletions(-) > >>>> > >>>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > >>>> index daf5ca9242..1d3b960305 100644 > >>>> --- a/lib/ethdev/rte_ethdev.c > >>>> +++ b/lib/ethdev/rte_ethdev.c > >>>> @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, > >>>> struct rte_eth_link *eth_link) > >>>> const char * > >>>> rte_eth_link_speed_to_str(uint32_t link_speed) > >>>> { > >>>> - switch (link_speed) { > >>>> - case ETH_SPEED_NUM_NONE: return "None"; > >>>> - case ETH_SPEED_NUM_10M: return "10 Mbps"; > >>>> - case ETH_SPEED_NUM_100M: return "100 Mbps"; > >>>> - case ETH_SPEED_NUM_1G: return "1 Gbps"; > >>>> - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; > >>>> - case ETH_SPEED_NUM_5G: return "5 Gbps"; > >>>> - case ETH_SPEED_NUM_10G: return "10 Gbps"; > >>>> - case ETH_SPEED_NUM_20G: return "20 Gbps"; > >>>> - case ETH_SPEED_NUM_25G: return "25 Gbps"; > >>>> - case ETH_SPEED_NUM_40G: return "40 Gbps"; > >>>> - case ETH_SPEED_NUM_50G: return "50 Gbps"; > >>>> - case ETH_SPEED_NUM_56G: return "56 Gbps"; > >>>> - case ETH_SPEED_NUM_100G: return "100 Gbps"; > >>>> - case ETH_SPEED_NUM_200G: return "200 Gbps"; > >>>> - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; > >>>> - default: return "Invalid"; > >>>> +#define SPEED_STRING_LEN 16 > >>>> + static char name[SPEED_STRING_LEN]; > >>> > >>> NACK > >>> > >>> Nothing good will happen if you try to use the function to > >>> print two different link speeds in one log message. > >> You are right. > >> And use malloc for "name" will result in memory leakage, which is > also > >> not a good option. > >> > >> BTW, do you think if we need to modify the function > >> "rte_eth_link_speed_to_str"? > > > > IMHO it would be more pain than gain in this case. If ETH_SPEED_NUM_xyz values was an enum instead of #define, the default case could be removed from this switch, and the compiler would emit a warning if a new ETH_SPEED_NUM_xyz was introduced without adding a case for it in this function. -Morten ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-10-30 9:59 ` Morten Brørup @ 2021-11-01 0:23 ` Min Hu (Connor) 0 siblings, 0 replies; 16+ messages in thread From: Min Hu (Connor) @ 2021-11-01 0:23 UTC (permalink / raw) To: Morten Brørup, Andrew Rybchenko, dev; +Cc: ferruh.yigit, thomas 在 2021/10/30 17:59, Morten Brørup 写道: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Min Hu (Connor) >> Sent: Friday, 17 September 2021 02.44 >> >> Agree with you. Thanks Andrew >> >> 在 2021/9/16 16:21, Andrew Rybchenko 写道: >>> On 9/16/21 11:16 AM, Min Hu (Connor) wrote: >>>> Hi, Andrew, >>>> >>>> 在 2021/9/16 14:22, Andrew Rybchenko 写道: >>>>> On 9/16/21 5:56 AM, Min Hu (Connor) wrote: >>>>>> Currently, link speed to string only supports specific speeds, >> like 10M, >>>>>> 100M, 1G etc. >>>>>> >>>>>> This patch expands support for any link speed which is over 1M and >> one >>>>>> decimal place will kept for display at most. >>>>>> >>>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >>>>>> --- >>>>>> lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- >>>>>> 1 file changed, 17 insertions(+), 17 deletions(-) >>>>>> >>>>>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >>>>>> index daf5ca9242..1d3b960305 100644 >>>>>> --- a/lib/ethdev/rte_ethdev.c >>>>>> +++ b/lib/ethdev/rte_ethdev.c >>>>>> @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, >>>>>> struct rte_eth_link *eth_link) >>>>>> const char * >>>>>> rte_eth_link_speed_to_str(uint32_t link_speed) >>>>>> { >>>>>> - switch (link_speed) { >>>>>> - case ETH_SPEED_NUM_NONE: return "None"; >>>>>> - case ETH_SPEED_NUM_10M: return "10 Mbps"; >>>>>> - case ETH_SPEED_NUM_100M: return "100 Mbps"; >>>>>> - case ETH_SPEED_NUM_1G: return "1 Gbps"; >>>>>> - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >>>>>> - case ETH_SPEED_NUM_5G: return "5 Gbps"; >>>>>> - case ETH_SPEED_NUM_10G: return "10 Gbps"; >>>>>> - case ETH_SPEED_NUM_20G: return "20 Gbps"; >>>>>> - case ETH_SPEED_NUM_25G: return "25 Gbps"; >>>>>> - case ETH_SPEED_NUM_40G: return "40 Gbps"; >>>>>> - case ETH_SPEED_NUM_50G: return "50 Gbps"; >>>>>> - case ETH_SPEED_NUM_56G: return "56 Gbps"; >>>>>> - case ETH_SPEED_NUM_100G: return "100 Gbps"; >>>>>> - case ETH_SPEED_NUM_200G: return "200 Gbps"; >>>>>> - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >>>>>> - default: return "Invalid"; >>>>>> +#define SPEED_STRING_LEN 16 >>>>>> + static char name[SPEED_STRING_LEN]; >>>>> >>>>> NACK >>>>> >>>>> Nothing good will happen if you try to use the function to >>>>> print two different link speeds in one log message. >>>> You are right. >>>> And use malloc for "name" will result in memory leakage, which is >> also >>>> not a good option. >>>> >>>> BTW, do you think if we need to modify the function >>>> "rte_eth_link_speed_to_str"? >>> >>> IMHO it would be more pain than gain in this case. > > If ETH_SPEED_NUM_xyz values was an enum instead of #define, the default case could be removed from this switch, and the compiler would emit a warning if a new ETH_SPEED_NUM_xyz was introduced without adding a case for it in this function. But, according to some coding standard, default case should be added in "switch case" syntax. > > -Morten > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2021-09-17 0:43 ` Min Hu (Connor) 2021-10-30 9:59 ` Morten Brørup @ 2023-01-19 11:41 ` Ferruh Yigit 2023-01-19 16:45 ` Stephen Hemminger 1 sibling, 1 reply; 16+ messages in thread From: Ferruh Yigit @ 2023-01-19 11:41 UTC (permalink / raw) To: Min Hu (Connor), Andrew Rybchenko; +Cc: thomas, dev On 9/17/2021 1:43 AM, Min Hu (Connor) wrote: > 在 2021/9/16 16:21, Andrew Rybchenko 写道: >> On 9/16/21 11:16 AM, Min Hu (Connor) wrote: >>> Hi, Andrew, >>> >>> 在 2021/9/16 14:22, Andrew Rybchenko 写道: >>>> On 9/16/21 5:56 AM, Min Hu (Connor) wrote: >>>>> Currently, link speed to string only supports specific speeds, like >>>>> 10M, >>>>> 100M, 1G etc. >>>>> >>>>> This patch expands support for any link speed which is over 1M and one >>>>> decimal place will kept for display at most. >>>>> >>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >>>>> --- >>>>> lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++----------------- >>>>> 1 file changed, 17 insertions(+), 17 deletions(-) >>>>> >>>>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >>>>> index daf5ca9242..1d3b960305 100644 >>>>> --- a/lib/ethdev/rte_ethdev.c >>>>> +++ b/lib/ethdev/rte_ethdev.c >>>>> @@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, >>>>> struct rte_eth_link *eth_link) >>>>> const char * >>>>> rte_eth_link_speed_to_str(uint32_t link_speed) >>>>> { >>>>> - switch (link_speed) { >>>>> - case ETH_SPEED_NUM_NONE: return "None"; >>>>> - case ETH_SPEED_NUM_10M: return "10 Mbps"; >>>>> - case ETH_SPEED_NUM_100M: return "100 Mbps"; >>>>> - case ETH_SPEED_NUM_1G: return "1 Gbps"; >>>>> - case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; >>>>> - case ETH_SPEED_NUM_5G: return "5 Gbps"; >>>>> - case ETH_SPEED_NUM_10G: return "10 Gbps"; >>>>> - case ETH_SPEED_NUM_20G: return "20 Gbps"; >>>>> - case ETH_SPEED_NUM_25G: return "25 Gbps"; >>>>> - case ETH_SPEED_NUM_40G: return "40 Gbps"; >>>>> - case ETH_SPEED_NUM_50G: return "50 Gbps"; >>>>> - case ETH_SPEED_NUM_56G: return "56 Gbps"; >>>>> - case ETH_SPEED_NUM_100G: return "100 Gbps"; >>>>> - case ETH_SPEED_NUM_200G: return "200 Gbps"; >>>>> - case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; >>>>> - default: return "Invalid"; >>>>> +#define SPEED_STRING_LEN 16 >>>>> + static char name[SPEED_STRING_LEN]; >>>> >>>> NACK >>>> >>>> Nothing good will happen if you try to use the function to >>>> print two different link speeds in one log message. >>> You are right. >>> And use malloc for "name" will result in memory leakage, which is also >>> not a good option. >>> >>> BTW, do you think if we need to modify the function >>> "rte_eth_link_speed_to_str"? >> >> IMHO it would be more pain than gain in this case. >> >> . >> > Agree with you. Thanks Andrew > It can be option to update the API as following in next ABI break release: const char * rte_eth_link_speed_to_str(uint32_t link_speed, char *buf, size_t buf_size); For this a deprecation notice needs to be sent and approved, not sure though if it worth. Meanwhile, what do you think to update string 'Invalid' to something like 'Irregular' or 'Erratic', does this help to convey the right message? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2023-01-19 11:41 ` Ferruh Yigit @ 2023-01-19 16:45 ` Stephen Hemminger 2023-02-10 14:41 ` Ferruh Yigit 0 siblings, 1 reply; 16+ messages in thread From: Stephen Hemminger @ 2023-01-19 16:45 UTC (permalink / raw) To: Ferruh Yigit; +Cc: Min Hu (Connor), Andrew Rybchenko, thomas, dev On Thu, 19 Jan 2023 11:41:12 +0000 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >>>> Nothing good will happen if you try to use the function to > >>>> print two different link speeds in one log message. > >>> You are right. > >>> And use malloc for "name" will result in memory leakage, which is also > >>> not a good option. > >>> > >>> BTW, do you think if we need to modify the function > >>> "rte_eth_link_speed_to_str"? > >> > >> IMHO it would be more pain than gain in this case. > >> > >> . > >> > > Agree with you. Thanks Andrew > > > > It can be option to update the API as following in next ABI break release: > > const char * > rte_eth_link_speed_to_str(uint32_t link_speed, char *buf, size_t buf_size); > > For this a deprecation notice needs to be sent and approved, not sure > though if it worth. > > > Meanwhile, what do you think to update string 'Invalid' to something > like 'Irregular' or 'Erratic', does this help to convey the right message? API versioning is possible here. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2023-01-19 16:45 ` Stephen Hemminger @ 2023-02-10 14:41 ` Ferruh Yigit 2023-03-23 14:40 ` Ferruh Yigit 0 siblings, 1 reply; 16+ messages in thread From: Ferruh Yigit @ 2023-02-10 14:41 UTC (permalink / raw) To: Stephen Hemminger; +Cc: Min Hu (Connor), Andrew Rybchenko, thomas, dev On 1/19/2023 4:45 PM, Stephen Hemminger wrote: > On Thu, 19 Jan 2023 11:41:12 +0000 > Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >>>>>> Nothing good will happen if you try to use the function to >>>>>> print two different link speeds in one log message. >>>>> You are right. >>>>> And use malloc for "name" will result in memory leakage, which is also >>>>> not a good option. >>>>> >>>>> BTW, do you think if we need to modify the function >>>>> "rte_eth_link_speed_to_str"? >>>> >>>> IMHO it would be more pain than gain in this case. >>>> >>>> . >>>> >>> Agree with you. Thanks Andrew >>> >> >> It can be option to update the API as following in next ABI break release: >> >> const char * >> rte_eth_link_speed_to_str(uint32_t link_speed, char *buf, size_t buf_size); >> >> For this a deprecation notice needs to be sent and approved, not sure >> though if it worth. >> >> >> Meanwhile, what do you think to update string 'Invalid' to something >> like 'Irregular' or 'Erratic', does this help to convey the right message? > > > API versioning is possible here. Agree, ABI versioning can be used here. @Connor, what do you think? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [RFC] ethdev: improve link speed to string 2023-02-10 14:41 ` Ferruh Yigit @ 2023-03-23 14:40 ` Ferruh Yigit 0 siblings, 0 replies; 16+ messages in thread From: Ferruh Yigit @ 2023-03-23 14:40 UTC (permalink / raw) To: Stephen Hemminger; +Cc: Min Hu (Connor), Andrew Rybchenko, thomas, dev On 2/10/2023 2:41 PM, Ferruh Yigit wrote: > On 1/19/2023 4:45 PM, Stephen Hemminger wrote: >> On Thu, 19 Jan 2023 11:41:12 +0000 >> Ferruh Yigit <ferruh.yigit@amd.com> wrote: >> >>>>>>> Nothing good will happen if you try to use the function to >>>>>>> print two different link speeds in one log message. >>>>>> You are right. >>>>>> And use malloc for "name" will result in memory leakage, which is also >>>>>> not a good option. >>>>>> >>>>>> BTW, do you think if we need to modify the function >>>>>> "rte_eth_link_speed_to_str"? >>>>> >>>>> IMHO it would be more pain than gain in this case. >>>>> >>>>> . >>>>> >>>> Agree with you. Thanks Andrew >>>> >>> >>> It can be option to update the API as following in next ABI break release: >>> >>> const char * >>> rte_eth_link_speed_to_str(uint32_t link_speed, char *buf, size_t buf_size); >>> >>> For this a deprecation notice needs to be sent and approved, not sure >>> though if it worth. >>> >>> >>> Meanwhile, what do you think to update string 'Invalid' to something >>> like 'Irregular' or 'Erratic', does this help to convey the right message? >> >> >> API versioning is possible here. > > > Agree, ABI versioning can be used here. > > @Connor, what do you think? Updating patch status as rejected, if you still pursue the feature please send a separate patch that updates the API via ABI versioning. Thanks, ferruh ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2023-03-23 14:40 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-13 8:45 [dpdk-dev] Questions about rte_eth_link_speed_to_str API Min Hu (Connor) 2021-09-13 10:26 ` Thomas Monjalon 2021-09-14 3:25 ` Min Hu (Connor) 2021-09-14 6:59 ` Stephen Hemminger 2021-09-14 13:04 ` Min Hu (Connor) 2021-09-16 2:56 ` [dpdk-dev] [RFC] ethdev: improve link speed to string Min Hu (Connor) 2021-09-16 6:22 ` Andrew Rybchenko 2021-09-16 8:16 ` Min Hu (Connor) 2021-09-16 8:21 ` Andrew Rybchenko 2021-09-17 0:43 ` Min Hu (Connor) 2021-10-30 9:59 ` Morten Brørup 2021-11-01 0:23 ` Min Hu (Connor) 2023-01-19 11:41 ` Ferruh Yigit 2023-01-19 16:45 ` Stephen Hemminger 2023-02-10 14:41 ` Ferruh Yigit 2023-03-23 14:40 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).