From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Renata Saiakhova <Renata.Saiakhova@ekinops.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation
Date: Tue, 23 Jun 2020 14:53:13 +0100 [thread overview]
Message-ID: <df303762-e89a-390e-d001-e465f5f38937@intel.com> (raw)
In-Reply-To: <20200623134215.31092-1-Renata.Saiakhova@ekinops.com>
On 6/23/2020 2:42 PM, Renata Saiakhova wrote:
> igb and ixgbe and some other drivers allocate HW rings using
> rte_eth_dma_zone_reserve(),
> which checks first if the memzone exists for a given name, consisting of port
> id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id.
> If the memzone with a given name exists it is returned, otherwise it is
> allocated.
> Disconnecting dpdk port from one type of interface (igb) and connecting it
> to another type of interface (ixgbe) for the same port id, potentially creates
> memory overlap and corruption, because it may require memzone of bigger size.
> That's what is happening from switching from igb to ixgbe having the same port
> id.
>
> v4->v5: rte_eth_dma_zone_free() marked as __rte_internal instead of
> __rte_experimental
> v3->v4: Improve return code in rte_eth_dma_zone_free() in case mz is not found;
> Release explicitly i40e Flow Director rx/tx rings by calling
> rte_eth_dma_zone_free().
> v2->v3: Remove #undef ETH_DMA_MZONE_NAME and minor changes in code standard.
> v1->v2: Minor changes on code standard and additional fixes in i40e em and ice
> drivers.
>
> Renata Saiakhova (4):
> ethdev: add function to release HW rings
> drivers/net: fix in igb and ixgbe HW rings memory
> drivers/net: fix in i40e HW rings memory overlap
> drivers/net: fix in em and ice HW rings memory overlap
I think good to keep driver patches separate to help the review and acks, but we
can squash them into single patch while merging.
next prev parent reply other threads:[~2020-06-23 13:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:42 Renata Saiakhova
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings Renata Saiakhova
2020-06-23 13:52 ` Ferruh Yigit
2020-06-23 15:49 ` Andrew Rybchenko
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 2/4] drivers/net: fix in igb and ixgbe HW rings memory Renata Saiakhova
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 3/4] drivers/net: fix in i40e HW rings memory overlap Renata Saiakhova
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 4/4] drivers/net: fix in em and ice " Renata Saiakhova
2020-06-23 13:53 ` Ferruh Yigit [this message]
2020-07-10 14:42 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add function to release HW rings Ferruh Yigit
2020-07-10 14:42 ` [dpdk-dev] [PATCH v6 2/2] drivers/net: delete HW rings while freeing queues Ferruh Yigit
2020-07-10 21:43 ` [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage Ferruh Yigit
2020-07-10 21:43 ` [dpdk-dev] [PATCH v7 2/3] ethdev: add function to release HW rings Ferruh Yigit
2020-07-10 21:43 ` [dpdk-dev] [PATCH v7 3/3] drivers/net: delete HW rings while freeing queues Ferruh Yigit
2020-07-10 22:07 ` [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage Thomas Monjalon
2020-07-10 23:17 ` Ferruh Yigit
2020-07-11 0:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df303762-e89a-390e-d001-e465f5f38937@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Renata.Saiakhova@ekinops.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).