From: Kevin Traynor <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, mdr@ashroe.eu
Subject: Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description
Date: Thu, 22 Jul 2021 21:24:13 +0100 [thread overview]
Message-ID: <df52310e-add0-4d15-1703-9ebce21eca9a@redhat.com> (raw)
In-Reply-To: <2185865.z788A1Ek0O@thomas>
On 22/07/2021 20:46, Thomas Monjalon wrote:
> 09/07/2021 17:19, Kevin Traynor:
>> rte_stats_bitrate_reg() API states it returns 'Zero on success'.
>>
>> However, the implementation directly returns the return of
>> rte_metrics_reg_names() which may be zero or positive on success,
>> with a positive value also indicating the index.
>>
>> The user of rte_stats_bitrate_reg() should not care about the
>> index as it is stored in the opaque rte_stats_bitrates struct.
>>
>> Change the implementation of rte_stats_bitrate_reg() to match
>> the API description by always returning zero on success.
>>
>> Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Does it require a deprecation notice?
I'm not certain, but I don't think it does. It is fixing the
implementation so it behaves as the API is documented to.
> At least I suggest a release note in API section.
>
> What is the target for this series? 21.11?
>
No urgency, 21.11 is fine for this set.
>
>
next prev parent reply other threads:[~2021-07-22 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 15:19 Kevin Traynor
2021-07-09 15:19 ` [dpdk-dev] [PATCH 2/3] bitrate: change calc " Kevin Traynor
2021-07-09 15:19 ` [dpdk-dev] [PATCH 3/3] bitrate: promote rte_stats_bitrate_free() to stable Kevin Traynor
2021-07-22 19:46 ` [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description Thomas Monjalon
2021-07-22 20:24 ` Kevin Traynor [this message]
2021-10-01 13:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df52310e-add0-4d15-1703-9ebce21eca9a@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).