From: Kevin Traynor <ktraynor@redhat.com>
To: "Min, JiaqiX" <jiaqix.min@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size
Date: Fri, 25 Oct 2019 10:43:44 +0100 [thread overview]
Message-ID: <df60355d-b81f-5fc0-766b-5d9c0394b93f@redhat.com> (raw)
In-Reply-To: <88691F3C94B94D4584B3478B96DE5B740B05B293@SHSMSX101.ccr.corp.intel.com>
On 25/10/2019 04:39, Min, JiaqiX wrote:
> Hi Xiaolong,
>
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, October 25, 2019 11:06 AM
>> To: Min, JiaqiX <jiaqix.min@intel.com>
>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size
>>
>> Hi,
>>
>> Could you provide the Fixes tag and cc stable?
>>
>
> It's a persistent issue, maybe it is an implementation miss.
> So Fixes tag can't be provided. Like this, need cc stable?
>
If it is an implementation miss since the driver was written then please
set the Fixes tag to the commit where the driver was introduced.
>> Thanks,
>>
>>
>> On 10/24, Min JiaqiX wrote:
>>> Max frame size is not set to HW, so packets above the MTU do not get
>>> dropped by HW. The patch fixed the issue.
>>>
>>> Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>>> ---
>>> drivers/net/ice/ice_ethdev.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/net/ice/ice_ethdev.c
>>> b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
>>> --- a/drivers/net/ice/ice_ethdev.c
>>> +++ b/drivers/net/ice/ice_ethdev.c
>>> @@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
>>>
>>> pf->adapter_stopped = false;
>>>
>>> + /* Set the max frame size */
>>> + ice_aq_set_mac_cfg(hw,
>>> + pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>>> +
>>> return 0;
>>>
>>> /* stop the started queues if failed to start all queues */
>>> --
>>> 2.17.1
>>>
next prev parent reply other threads:[~2019-10-25 9:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:08 Min JiaqiX
2019-10-25 3:06 ` Ye Xiaolong
2019-10-25 3:39 ` Min, JiaqiX
2019-10-25 9:43 ` Kevin Traynor [this message]
2019-10-28 5:29 ` Ye Xiaolong
2019-10-28 15:54 ` [dpdk-dev] [PATCH v2] net/ice: fix setting " Min JiaqiX
2019-10-28 8:46 ` Ye Xiaolong
2019-10-29 2:05 ` Ye Xiaolong
2019-10-29 3:12 ` Min, JiaqiX
2019-10-29 5:07 ` Ye Xiaolong
2019-10-30 6:34 ` Min, JiaqiX
2019-10-29 12:54 ` [dpdk-dev] [PATCH v3] " Min JiaqiX
2019-10-30 5:21 ` Ye Xiaolong
2019-10-30 6:40 ` Min, JiaqiX
2019-10-30 10:04 ` [dpdk-dev] [PATCH v4] " Min JiaqiX
2019-11-04 2:56 ` Ye Xiaolong
2019-11-04 7:05 ` Min, JiaqiX
2019-11-04 15:33 ` [dpdk-dev] [PATCH v5] " Min JiaqiX
2019-11-05 2:22 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df60355d-b81f-5fc0-766b-5d9c0394b93f@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=jiaqix.min@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).