From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F4CFA32A2 for ; Fri, 25 Oct 2019 11:44:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5ECB1BF25; Fri, 25 Oct 2019 11:43:58 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 051F41BF13 for ; Fri, 25 Oct 2019 11:43:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571996636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JZqUiPQNRXAYbR34w4cueC389cWNVXVvTBP70v/cfr0=; b=Yw6ADettMDb8woO2XT0A03TmWfurlSmLvoiCPwL1dQ1YDvJIqV2yih+HInvGWf6VWRV+32 Wz5TYhO4vbXNVNN6xRn59y8fqMS3lLqQEP3XUaL+o6acioN8saIgB6Z68I0G4tt7Nvfu8l 8X0zGrtvLueGdjX2+vcM+d2Q5Vboe38= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-s6tezg0rPPqqJ5lS2fIpQQ-1; Fri, 25 Oct 2019 05:43:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4494880183D; Fri, 25 Oct 2019 09:43:52 +0000 (UTC) Received: from [10.36.118.52] (unknown [10.36.118.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8AD97600D1; Fri, 25 Oct 2019 09:43:45 +0000 (UTC) To: "Min, JiaqiX" , "Ye, Xiaolong" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "Yang, Qiming" References: <20191024190818.36524-1-jiaqix.min@intel.com> <20191025030619.GE2504@intel.com> <88691F3C94B94D4584B3478B96DE5B740B05B293@SHSMSX101.ccr.corp.intel.com> From: Kevin Traynor Message-ID: Date: Fri, 25 Oct 2019 10:43:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <88691F3C94B94D4584B3478B96DE5B740B05B293@SHSMSX101.ccr.corp.intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: s6tezg0rPPqqJ5lS2fIpQQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25/10/2019 04:39, Min, JiaqiX wrote: > Hi Xiaolong,=20 >=20 >> -----Original Message----- >> From: Ye, Xiaolong >> Sent: Friday, October 25, 2019 11:06 AM >> To: Min, JiaqiX >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming >> >> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size >> >> Hi, >> >> Could you provide the Fixes tag and cc stable? >> > =20 > It's a persistent issue, maybe it is an implementation miss. > So Fixes tag can't be provided. Like this, need cc stable? >=20 If it is an implementation miss since the driver was written then please set the Fixes tag to the commit where the driver was introduced. >> Thanks, >> >> >> On 10/24, Min JiaqiX wrote: >>> Max frame size is not set to HW, so packets above the MTU do not get >>> dropped by HW. The patch fixed the issue. >>> >>> Signed-off-by: Min JiaqiX >>> --- >>> drivers/net/ice/ice_ethdev.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/net/ice/ice_ethdev.c >>> b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644 >>> --- a/drivers/net/ice/ice_ethdev.c >>> +++ b/drivers/net/ice/ice_ethdev.c >>> @@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev) >>> >>> =09pf->adapter_stopped =3D false; >>> >>> +=09/* Set the max frame size */ >>> +=09ice_aq_set_mac_cfg(hw, >>> +=09=09pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL); >>> + >>> =09return 0; >>> >>> =09/* stop the started queues if failed to start all queues */ >>> -- >>> 2.17.1 >>>