Re: [dpdk-dev] [PATCH v1 3/5] eal: modify device event callback process func

[Jeff Guo <jia.guo@intel.com>]

On 9/26/2018 8:20 PM, Burakov, Anatoly wrote:
> On 17-Aug-18 11:51 AM, Jeff Guo wrote:
>> This patch modify the device event callback process function name to be
>> more explicit, and exposure the API from private to public. The drivers
>> and apps would directly use this API to process device event callback.
>>
>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>> ---
>
> <snip>
>
>> -typedef void (*rte_dev_event_cb_fn)(char *device_name,
>> +typedef void (*rte_dev_event_cb_fn)(const char *device_name,
>>                       enum rte_dev_event_type event,
>>                       void *cb_arg);
>>   @@ -439,6 +439,23 @@ rte_dev_event_callback_unregister(const char 
>> *device_name,
>>    * @warning
>>    * @b EXPERIMENTAL: this API may change without prior notice
>>    *
>> + * Internal Executes all the user application registered callbacks for
>
> it probably should say @internal instead of "Internal", with comment 
> starting on a new line.
>

yes, you are here, and what i want is make it internal.