From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3688A0C5C; Wed, 8 Sep 2021 18:48:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32DE040E25; Wed, 8 Sep 2021 18:48:08 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5816D4003E for ; Wed, 8 Sep 2021 18:48:06 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="242835181" X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="242835181" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 09:47:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="606315487" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 08 Sep 2021 09:47:54 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 09:47:53 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 09:47:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 8 Sep 2021 09:47:53 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 8 Sep 2021 09:47:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jei6PDzH6KWfqp61q/WpP/q6m5khlvznOBgo2wzTrNfzN16qjvtxa7ucKzf4p8P7bBwihH8AwBvAaDENJE+hZ4PtbJxyYCLKDfjRPsCMA119y0ew9AaOlwiI8EOHEeC538t7pmjEd6iIuGgEbN6rkeaDRg0HGVO562OaMuFjiVppyThmrsEMY9Ya9qoadFosUTLfOUGY0jXreptFEh2SNDhVvTC2gnIrSsDwD+9/EkOpJKSqEe1cX9Ubcx4IvL+gHg4ckgKpUG8nNDDpD62Fg98V9vAPFin7qrhvx1bzcMvDNfErw7vCivNa5drxn9Hs+jrry8GeTXIduvAOH2N4qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rXXQR1aHgrPxYW4b3j3XLAmF+6Oj/XJh8WOyb6yhoX8=; b=Cr5UwwvDoqXjFgxrQNhRi7+JwZH00++qc5TXr4DMoOd/t8WxCpx7e8mqOC7p7PADlQyArFBmt5emtY6CzCi/h6+RAyz4I3DAQo2ekcsex5d0xyzPuvSTa6+MtX/YXY0sKZqMHwPnGN6cM5pEIUfKAca4eEaSNsIILsghktuukypJois78nWpJcmtSKcKJqK1M/actNXy7GMW7VvCVB187m8y7l8ECyIDrkfh4LvFLSCrNKttI+vp3NUMZkL74NfqpNH93+5Hkx0YiwLaqVudGR3Haedj6WAkEuVq488FVhLIUZx/XWmkdvg35QlHrkssUZaccekxYDSCHZrA/SORiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXXQR1aHgrPxYW4b3j3XLAmF+6Oj/XJh8WOyb6yhoX8=; b=J8Rpc6qpypF8zKnWZDU/vf+9Mch+7SojwzSWNnO+JiUagzQq/fXluxj99Li/bsCj0uAhSKeAXal3hnM8ZIbKE5xHlK+y9NH9HludOkrmOyv0Ig1z72JlI64x8eBEe1xk4J8bU891g6hMTi+2Q7UdPNoF9oKxH3Yfjzr/c7i3rx4= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 16:47:51 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a%6]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 16:47:51 +0000 To: Kevin Laatz , CC: , , References: <20210903105001.1179328-1-kevin.laatz@intel.com> <20210908103016.1661914-1-kevin.laatz@intel.com> <20210908103016.1661914-5-kevin.laatz@intel.com> From: Conor Walsh Message-ID: Date: Wed, 8 Sep 2021 17:47:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210908103016.1661914-5-kevin.laatz@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: DB6PR0202CA0041.eurprd02.prod.outlook.com (2603:10a6:4:a5::27) To PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) MIME-Version: 1.0 Received: from [192.168.1.181] (86.40.71.8) by DB6PR0202CA0041.eurprd02.prod.outlook.com (2603:10a6:4:a5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 16:47:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 799f77dc-6c0f-4dcf-4431-08d972e86534 X-MS-TrafficTypeDiagnostic: PH0PR11MB5176: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:813; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3dCXtUxJ6SirPWnF0SHjw9SkC49zGvCen9PT04A69dqpl99LMAC0OEgCdMTZnrgI+KsgMfYHcqKTUtjtoJy35Fr9DioYcyE7Vka3NOHSzKBagm2fNG4ZRs8fn36SKVGTtQKQU1v/CeSYM20AcQZUQi0mW9N7HsZ8qxkiU3NvPtW2yjFJuknUOgvNcddLRPAHNIaJ0qkykaHkTrcFvVAZzNOLdLRx1Me/eeu5sUskAxKVo19JrlA2UzlK5sGjcJDPd33kQHOep2lNa0iA7wXszP3FYOfGAGIu+V5kTQKqKw1LBgzka9mlg7SpY+0Y2QzhcS17K7kQwaNffkl7e2sB6igQdc1QwcOtDf2aX51HsGGsvzVcAttE2MVrOwrVSb9kGcDbSFbnTUBEp9AzDsnm6SmLpTf7LmPl97z3B0Jwd8CLJ0EEb3WzxBAk4TUJNeHOVF9+Bw7B+5a1pugLPHAL2K1WK33tM1E6ah4iZp1i2wP13KMinoi7WG9wTkRCc5Pz2xH6Iz0sFfRrCjUcxx6mCrJWnbqySLylh7jC4QuVoS1uJIj62uCPfEz6+F1sjhasedbjcgygUG5oQBdfUhvpVDyAkQodZidDVRmr8Ayt9bucfs/WBed1SAEHH8//AF/U4/TRv6TBdE5wovnfUPCp9ik9sdyNA7DNjsH06RPf8fLv97G/l5b4X07Sf3/LU4/tServo6kM5rmkO9WOvuTd+ceX5CN7qQor2AV8kO/9o0A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(6666004)(66946007)(66556008)(2616005)(31686004)(36756003)(6486002)(66476007)(478600001)(86362001)(38100700002)(186003)(4326008)(26005)(4744005)(8676002)(31696002)(83380400001)(8936002)(5660300002)(2906002)(44832011)(16576012)(316002)(956004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkdpcHZraTYyMEM4YXBSalpPeUxBOHdqcTNTV3F0V3JoVHExb1UrMVgraVFF?= =?utf-8?B?dVdLWmFpZzdtUEo4RlR2c3pCbGdZRmZUV0ZDWXhKOVlReU15N3pXUitEaGlk?= =?utf-8?B?dU1MdGdzTnN6ZW5CaGhvZGdGbjlLWXdyQ3hJVVplRExzOUxmcGtONGZ6V0NW?= =?utf-8?B?VU1QSFU3NHM1OXJYczl4cHQ5TjVsYVBBbTFZczBiZDZnWk1Ca0FQK1ZOcGxq?= =?utf-8?B?MnhQZXU2cmh1U2kzRGpNSDJOSk41LzlxUk5WZS90M3V0N29Panh3NG1GY1V0?= =?utf-8?B?Wnc2ck5aV3pHbElQd1V4WkQzc1dpNllvSEdkVWFRdGZucDBRUW93Y1ZvRU1s?= =?utf-8?B?bFAvdjYvMGU1cnhGVThNVG1hd0xZUWU1VnFwUEI5UkpxOFVRRVM5dklrK2hO?= =?utf-8?B?MXNvdU9ub0xKaHhIcGYyekFPV1V1MDBVNmZXOUZadVg5MlRkeFZweTVJOUsz?= =?utf-8?B?UmIvb3FteEhhcUZBbC9jSWVaUWdQT21CdjBnczg1amo3YytFTXI3SGpzNklw?= =?utf-8?B?dUlia3A3Nk5NOFUyaTNMT3RvQUFjWlR3d1ZXM0FXUnFHRmsvTndGcVcvdER6?= =?utf-8?B?T3MwakNMRDFZUUdOOTMzTjZzUkRRYzJOSWpWNVFUOElyTHpGMVBBMWNSd3RP?= =?utf-8?B?d2ZMUzBJdTRMclhMaW9HNEY1ZmJHRjFZNTRCU3o2cS82ci9ZL0drUTBoUDVt?= =?utf-8?B?YS9wd09oOHJBd2haZGFXNUFoY3hpYXZXZWpDVFN5UWtHd0hCSFNGM0Y0em5S?= =?utf-8?B?MHFIOU1xMFFxdXpMNE9YNHd6Q3ZmUEZkRjFsQ01UR2wzVENXMWprdDQ0SmZ6?= =?utf-8?B?VDMyaXg0RUtIM01QelJSampmTytTcm9FT3EwMUZDTVpwU2hpSXA1N3V0OTFl?= =?utf-8?B?MnZORDAvNklEMGxOaTJleC9uMWpJWGN2M25xaDFnTHlRWElxVHlSMldBRngy?= =?utf-8?B?Q0VQK2VOWkRyTDZsbTVmTG5UVk1GbHM2NzJvbjdaNUJoRjVFZ3AxdHdONXp3?= =?utf-8?B?YTZzUllwbVJSNVoySW9FQ2RhR3Zsa1VqTERDNXdTdFZqQzdHbUlRM3E4Wi9r?= =?utf-8?B?RUowYlV6Q2pCQklXRk1sN082T2hISTRwTjlaSnRVdDRzRG5jWTBCU0pBSDNv?= =?utf-8?B?NlNXaG9zQVJlT1FUSmZWRnB6ejUwMXZFd24yR3BsSnk5VnpJb2lxUHJsVlZU?= =?utf-8?B?TjFmM1FUQXhyMlFTay9Ub093cVNQWkV3dTdBWkM5TXNEd0RFdjhYUDhKRFpP?= =?utf-8?B?N1YyS2F2SmZzZEMvbEswcUxnUzFpWEluZzQ4dmJ0RjNRSWpRcnF4Nk12UGdh?= =?utf-8?B?SjNpenJEVzBkMlRjQktYYkZpa3VlY2ZZRmFKbUFna1BEaHdkQTdyV3FkMVVL?= =?utf-8?B?NE5neUQrVVFGZjlnd1FYbkNvYjNYRFBzd0xKckYxMlpVM2U2Ty8yaGRXS0No?= =?utf-8?B?VytuOXBFcTJCci85K014cTlaanpnQlNUMlRTNW1xM2pHc3A5akxhRklucUNO?= =?utf-8?B?dGExVW9CKyt0b3lHR2FadmNxNkJvWDU0M1JObGp5MVpnK0lzbVhOUkt2Q2dw?= =?utf-8?B?eCtKRzRQZm16MDV4ZzZrN1dVZTR2R2ZpM1pKQzlRWnBMSHRFYnFaT21tY2s5?= =?utf-8?B?RlJkM2publZXQStwUk14V2t6S1JJRE1RcUtDeHUxMmlzT21ENU1YWUhMRUY2?= =?utf-8?B?c1BxRlp2UnR4c255TDdCbFZxOUVFbEdmOC9pd3d3THQ1QmtFamVnaW5CRWVh?= =?utf-8?Q?DQBjTnSGmnyWNx2xj0D+zpPteR0JzFksHSWhMBg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 799f77dc-6c0f-4dcf-4431-08d972e86534 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 16:47:51.0746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ky3HauDgPJmNhQYYSlQEoZpZNE/0E6r//h/JrsoijkjUJSXu1XqJCN6nAsOGORpZNwxfFjericgEAJq8NpXNpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > +static void * > +idxd_vdev_mmap_wq(struct rte_dsa_device *dev) Some inconsistent naming between vdev and bus in some of these functions the above should be idxd_bus_mmap_wq for example. > +{ > + void *addr; > + char path[PATH_MAX]; > + int fd; > + > + snprintf(path, sizeof(path), "%s/%s", dsa_get_dev_path(), dev->wq_name); > + fd = open(path, O_RDWR); > + if (fd < 0) { > + IDXD_PMD_ERR("Failed to open device path: %s", path); > + return NULL; > + } > + > + addr = mmap(NULL, 0x1000, PROT_WRITE, MAP_SHARED, fd, 0); > + close(fd); > + if (addr == MAP_FAILED) { > + IDXD_PMD_ERR("Failed to mmap device %s", path); > + return NULL; > + } > + > + return addr; > +} Reviewed-by: Conor Walsh