* [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables
@ 2018-09-20 9:34 Anatoly Burakov
2018-09-20 11:25 ` Bruce Richardson
2018-09-20 12:26 ` [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error Anatoly Burakov
0 siblings, 2 replies; 5+ messages in thread
From: Anatoly Burakov @ 2018-09-20 9:34 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, thomas, xuemingx.zhang
Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
index 06afbcc99..a5847f0bd 100644
--- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c
+++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
@@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void)
}
int
-eal_memalloc_get_seg_fd(int list_idx, int seg_idx)
+eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused)
{
return -ENOTSUP;
}
int
-eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd)
+eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused,
+ int fd __rte_unused)
{
return -ENOTSUP;
}
int
-eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset)
+eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused,
+ int seg_idx __rte_unused, size_t *offset __rte_unused)
{
return -ENOTSUP;
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables
2018-09-20 9:34 [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables Anatoly Burakov
@ 2018-09-20 11:25 ` Bruce Richardson
2018-09-20 11:29 ` Burakov, Anatoly
2018-09-20 12:26 ` [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error Anatoly Burakov
1 sibling, 1 reply; 5+ messages in thread
From: Bruce Richardson @ 2018-09-20 11:25 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, thomas, xuemingx.zhang
On Thu, Sep 20, 2018 at 10:34:46AM +0100, Anatoly Burakov wrote:
> Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Sorry, I missed your patch by about 1 hour - hadn't got through my mail
fully when sent mine.
I think you could do with a couple of other fixes tags on it, just take
them from my patch. Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
> index 06afbcc99..a5847f0bd 100644
> --- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
> @@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void)
> }
>
> int
> -eal_memalloc_get_seg_fd(int list_idx, int seg_idx)
> +eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused)
> {
> return -ENOTSUP;
> }
>
> int
> -eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd)
> +eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused,
> + int fd __rte_unused)
> {
> return -ENOTSUP;
> }
>
> int
> -eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset)
> +eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused,
> + int seg_idx __rte_unused, size_t *offset __rte_unused)
> {
> return -ENOTSUP;
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables
2018-09-20 11:25 ` Bruce Richardson
@ 2018-09-20 11:29 ` Burakov, Anatoly
0 siblings, 0 replies; 5+ messages in thread
From: Burakov, Anatoly @ 2018-09-20 11:29 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, thomas, xuemingx.zhang
On 20-Sep-18 12:25 PM, Bruce Richardson wrote:
> On Thu, Sep 20, 2018 at 10:34:46AM +0100, Anatoly Burakov wrote:
>> Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>
> Sorry, I missed your patch by about 1 hour - hadn't got through my mail
> fully when sent mine.
> I think you could do with a couple of other fixes tags on it, just take
> them from my patch. Otherwise:
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
My patch had one too few Fixes tags, yours had one too many :)
I'll resubmit a v2 with new extra tags and probably changed commit message.
>
>> lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
>> index 06afbcc99..a5847f0bd 100644
>> --- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c
>> +++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
>> @@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void)
>> }
>>
>> int
>> -eal_memalloc_get_seg_fd(int list_idx, int seg_idx)
>> +eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused)
>> {
>> return -ENOTSUP;
>> }
>>
>> int
>> -eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd)
>> +eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused,
>> + int fd __rte_unused)
>> {
>> return -ENOTSUP;
>> }
>>
>> int
>> -eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset)
>> +eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused,
>> + int seg_idx __rte_unused, size_t *offset __rte_unused)
>> {
>> return -ENOTSUP;
>> }
>> --
>> 2.17.1
>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error
2018-09-20 9:34 [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables Anatoly Burakov
2018-09-20 11:25 ` Bruce Richardson
@ 2018-09-20 12:26 ` Anatoly Burakov
2018-09-20 12:58 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Anatoly Burakov @ 2018-09-20 12:26 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, thomas, xuemingx.zhang
When compiling on FreeBSD, lots of warnings/errors are thrown for
unused parameter. Fix these by marking the parameters as unused
in the code.
Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
Fixes: 3a44687139eb ("mem: allow querying offset into segment fd")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
Notes:
v2:
- Added missing Fixes tag
- Reworded commit message
lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
index 06afbcc99..a5847f0bd 100644
--- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c
+++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c
@@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void)
}
int
-eal_memalloc_get_seg_fd(int list_idx, int seg_idx)
+eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused)
{
return -ENOTSUP;
}
int
-eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd)
+eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused,
+ int fd __rte_unused)
{
return -ENOTSUP;
}
int
-eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset)
+eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused,
+ int seg_idx __rte_unused, size_t *offset __rte_unused)
{
return -ENOTSUP;
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error
2018-09-20 12:26 ` [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error Anatoly Burakov
@ 2018-09-20 12:58 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-09-20 12:58 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, Bruce Richardson, xuemingx.zhang
20/09/2018 14:26, Anatoly Burakov:
> When compiling on FreeBSD, lots of warnings/errors are thrown for
> unused parameter. Fix these by marking the parameters as unused
> in the code.
>
> Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd")
> Fixes: 3a44687139eb ("mem: allow querying offset into segment fd")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-20 12:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-20 9:34 [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables Anatoly Burakov
2018-09-20 11:25 ` Bruce Richardson
2018-09-20 11:29 ` Burakov, Anatoly
2018-09-20 12:26 ` [dpdk-dev] [PATCH v2] eal/bsd: fix unused parameters compile error Anatoly Burakov
2018-09-20 12:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).