DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Rahul Bhansali <rbhansali@marvell.com>, <dev@dpdk.org>,
	Jan Viktorin <viktorin@rehivetech.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: <jerinj@marvell.com>
Subject: Re: [PATCH v2 1/2] config/arm: add SVE ACLE control flag
Date: Mon, 9 May 2022 08:49:38 +0800	[thread overview]
Message-ID: <df8c37b3-ed02-edb9-b732-3a0ed0c04bfb@huawei.com> (raw)
In-Reply-To: <20220507093943.2065586-1-rbhansali@marvell.com>

On 2022/5/7 17:39, Rahul Bhansali wrote:
> This add the control flag for SVE ACLE to enable or disable
> RTE_HAS_SVE_ACLE macro in the build.
> 
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> ---
> Changes in v2:
> - Renamed the flag to sve_acle from sve
> - Added double-indent.
> 
>  config/arm/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8aead74086..2e12b541ef 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -603,7 +603,8 @@ if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
>      compile_time_cpuflags += ['RTE_CPUFLAG_NEON']
>  endif
> 
> -if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != ''
> +if (cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' and
> +        soc_config.get('sve_acle', true))
>      compile_time_cpuflags += ['RTE_CPUFLAG_SVE']
>      if (cc.check_header('arm_sve.h'))

the above sve_acle also impact RTE_CPUFLAG_SVE which don't mentioned in commit log.
suggest add soc_config.get('sve_acle', true) in above if statement.

>          dpdk_conf.set('RTE_HAS_SVE_ACLE', 1)
> --
> 2.25.1
> 
> 
> .
> 


  parent reply	other threads:[~2022-05-09  0:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 14:27 [PATCH 1/2] config/arm: add SVE " Rahul Bhansali
2022-05-05 14:27 ` [PATCH 2/2] config/arm: disable SVE for cn10k Rahul Bhansali
2022-05-06  2:29   ` fengchengwen
2022-05-06  4:54     ` [EXT] " Rahul Bhansali
2022-05-06  6:36       ` fengchengwen
2022-05-06  7:23         ` Ruifeng Wang
2022-05-06 13:17           ` Rahul Bhansali
2022-05-07  0:52             ` fengchengwen
2022-05-05 14:39 ` [PATCH 1/2] config/arm: add SVE control flag Bruce Richardson
2022-05-06 14:16   ` [EXT] " Rahul Bhansali
2022-05-06  2:23 ` fengchengwen
2022-05-07  9:39 ` [PATCH v2 1/2] config/arm: add SVE ACLE " Rahul Bhansali
2022-05-07  9:39   ` [PATCH v2 2/2] config/arm: disable SVE ACLE for cn10k Rahul Bhansali
2022-05-09  0:49   ` fengchengwen [this message]
2022-05-09  9:46   ` [PATCH v3 1/2] config/arm: add SVE ACLE control flag Rahul Bhansali
2022-05-09  9:46   ` [PATCH v3 2/2] config/arm: disable SVE ACLE for cn10k Rahul Bhansali
2022-05-09 10:19 ` [PATCH v4 1/2] config/arm: add SVE ACLE control flag Rahul Bhansali
2022-05-09 10:19   ` [PATCH v4 2/2] config/arm: disable SVE ACLE for cn10k Rahul Bhansali
2022-05-10  2:57     ` fengchengwen
2022-05-11  1:35     ` Ruifeng Wang
2022-05-11  4:12       ` Honnappa Nagarahalli
2022-05-10  2:57   ` [PATCH v4 1/2] config/arm: add SVE ACLE control flag fengchengwen
2022-05-11  1:35   ` Ruifeng Wang
2022-05-11  4:09     ` Honnappa Nagarahalli
2022-05-17  7:56   ` Juraj Linkeš
2022-05-18  9:18     ` Rahul Bhansali
2022-05-18 14:45       ` Juraj Linkeš
2022-05-19 13:28 ` [PATCH v5 " Rahul Bhansali
2022-05-19 13:28   ` [PATCH v5 2/2] config/arm: disable SVE ACLE for cn10k Rahul Bhansali
2022-06-01 22:38     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df8c37b3-ed02-edb9-b732-3a0ed0c04bfb@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=rbhansali@marvell.com \
    --cc=ruifeng.wang@arm.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).