From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 726BAA0487 for ; Thu, 4 Jul 2019 10:39:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 763051B94F; Thu, 4 Jul 2019 10:39:36 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 683071B4B6 for ; Thu, 4 Jul 2019 10:39:35 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id v19so5134539wmj.5 for ; Thu, 04 Jul 2019 01:39:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ia1oYUns4ZJ3/52CPiovObG2qg588b/svbtMhzjX2dQ=; b=sy+Z8FrkSLijS+wCl7EWiyHL0BC5bbwwcUD/gdD51mqacoaFFzRaILL2pYfWD90Zjm U+mTLr02T8TdvF5fLpryoLxaMtXGP3xa4eCY9Me3UqU8921N+KVCik9d3b9qTFqE3FSe DVkeD2aUny0/63cqYqTdj/KpFFSJqwdasNEMHkqseBco63MhYYpAyR9A43G2U7qrxvsA 8Oh7iO6Kv5AzUnsyKRaQXyaanUPExuE4texiIg9vGVvcqytZTBcOqwSncQTibRMXYC2Z q+RNOGvdki4kWR+8GAtWyOf3EtQqzng/ax/lgGoCiY2JsnKbMj0L7q9oUCpFQX0+OHYB p5UA== X-Gm-Message-State: APjAAAWdl2e71gTSXlL7PnGV0YlA0y1Q4MxwQNzAtBbYnvWbB+7tTAue IOHjAwK5wczKs1+gzIySuZI= X-Google-Smtp-Source: APXvYqyzIM5hqr+8GRgeWos5yCqKVElkW7280YPAs4sjDOMpF8cB7XidYj99JpzGJGk6mJr5QiMnyQ== X-Received: by 2002:a1c:67c3:: with SMTP id b186mr10889787wmc.34.1562229574846; Thu, 04 Jul 2019 01:39:34 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d9sm7332624wrb.71.2019.07.04.01.39.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 01:39:32 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Thu, 04 Jul 2019 09:39:32 +0100 In-Reply-To: <20190703164001.24841-3-bruce.richardson@intel.com> References: <20190703164001.24841-1-bruce.richardson@intel.com> <20190703164001.24841-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] buildtools/test-meson-builds: workaround pkg-config issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2019-07-03 at 17:40 +0100, Bruce Richardson wrote: > With Debian and Ubuntu, the default installation path for the 64-bit > libraries is set to e.g. /usr/local/lib/x86_64-linux-gnu/, compared > to > /usr/local/lib64 on Fedora and Redhat distributions. This causes > issues > when using "pkg-config --define-prefix" since pkg-config assumes the > prefix > to be the grandparent of where the .pc file is. On Ubuntu we then get > the > cflags include path as being "/path/to/install- > root/usr/local/lib/include" > i.e. with an extra "lib" in the path. >=20 > This issue only applies for test installs on Ubuntu and similar > distros, > and is not a problem for regular installs since the --define-prefix > parameter would not be passed to pkg-config in those cases. >=20 > The workaround for this in our test build script is to explicitly > make > "lib" the "libdir" setting for the install, overriding the distro- > provided > default. >=20 > Fixes: 7f80a2102bbb ("devtools: test pkg-config file") >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > devtools/test-meson-builds.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index 57d1af47e..7efc590fe 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -76,12 +76,14 @@ for c in gcc clang ; do > done > =20 > # test compilation with minimal x86 instruction set > +# set the install path for libraries to "lib" explicitly to prevent > problems > +# with pkg-config prefixes if installed in "lib/x86_64-linux-gnu" > later. > default_machine=3D'nehalem' > ok=3D$(cc -march=3D$default_machine -E - < /dev/null > /dev/null 2>&1 || > echo false) > if [ "$ok" =3D "false" ] ; then > default_machine=3D'corei7' > fi > -build build-x86-default -Dmachine=3D$default_machine $use_shared > +build build-x86-default -Dlibdir=3Dlib -Dmachine=3D$default_machine > $use_shared > =20 > # enable cross compilation if gcc cross-compiler is found > c=3Daarch64-linux-gnu-gcc I have sent a patch upstream to pkg-config to fix the issue, as it should really support the multiarch layout: https://gitlab.freedesktop.org/pkg-config/pkg-config/merge_requests/4 --=20 Kind regards, Luca Boccassi