From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CB8041CBF; Fri, 17 Feb 2023 13:43:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 054F340EE3; Fri, 17 Feb 2023 13:43:18 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2075.outbound.protection.outlook.com [40.107.243.75]) by mails.dpdk.org (Postfix) with ESMTP id 0095B40EE1 for ; Fri, 17 Feb 2023 13:43:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAPeEQJpKK/THsGUma59mvhimS2jPbpDAssO/I4QLqA5uHzk7tXBgaD6+ZxUz+vDR1EUPA3cZAItN/kTL2AcNTSVokSxVUWVixbAyK3AYGpfid6N+h4RBrSp8h3JMbPddQ94KbX9En6nHx1dIly/FLTF0v6vTuFxpGiZHuzTJ3HhfDsEHtnkNyYITFCFy6uma7hO68a9pla7OksfCn3Rw8kbyFxTHd2IDm+MjIgv2ym/qOXoPxxfI6rI72hume5xD/L2Xrv9Vcih5eYBVomjS/5hL2LoBidKSuVc5OKnAKbDt9phA0m4D8at3bxkS9LNMh0mpK5KytsRXecDcO0ayw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S026mrHXvMvz7QdmI/Y+ljqzKAHgi1BNJJT91Usgwek=; b=ktrY998n2FKp/RBYYsOneWqD32AKklMaehu90ygaDah3ys3uF/zegT4R5hYMc1hr5yLWusU0bJtT1ThOjsKSWHCv5h+FWYRHCn5i53Qjle2okvhCiHXwfvvgFgQKwQLvPjqqaARtsfXWUagNFYtd5W5/MYtXsVW0zbYnhz2GUvq1qzo3Hcfj0YpXRgHcUs4KZMFYWKjdhW/IcxY9jG7qJ/quKvBmLxNeuDpBs/anu2v3MpCrZuBcuFG9BivP+5XGh/FuOZwLyJOS5aj2zFF4LeWcYXPdBKhIfAKsjw8oZ1psvuazZF+LM7cuUXr06iP7ghd23iv5LbrFQWb7blOLBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S026mrHXvMvz7QdmI/Y+ljqzKAHgi1BNJJT91Usgwek=; b=Y9ne+PVSlJxN8zRDpy09HX0MkhkB+im8bcM2LniYWWmXtn1yf2Nug9h8VwXHpg0aalc+RqgbYgPEqkbRHM+y9P1udbbEtfDCRdK83V2WBSVbBQTL8BM3LxIBTwh+btBcFdvO5UU3jEhvgFYUW86wN5LODzXGo6mqQRWEWbHBy4U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB4560.namprd12.prod.outlook.com (2603:10b6:806:97::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Fri, 17 Feb 2023 12:43:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 12:43:13 +0000 Message-ID: Date: Fri, 17 Feb 2023 12:43:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Levend Sayar , junfeng.guo@intel.com Cc: dev@dpdk.org References: <20230216181025.23485-1-levendsayar@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH v2 1/4] net/gve: change offloading capability In-Reply-To: <20230216181025.23485-1-levendsayar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0012.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB4560:EE_ X-MS-Office365-Filtering-Correlation-Id: fd92309c-9737-4efe-e3f2-08db10e48836 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KY2XFJQId4lI65nU6xP7lJGvyqbxb9/sVKNUtX83op/tdgQ1sFR8vxHrRBab/7iryZy3G2d7wlD6sYaEBEV8Lrq6M6dr/BcLNNf7sP3MGdikxENpZ4/dRjVIda7GWclLXfqDNH0gw5uauhX8to0VW01raxdKCwQOsTSeQ6222wLxxgyhkSinoRfyQUwIg8A+pblmQcgKxaQSoeUAb2Tw/qH1CNmsoVZuGLEeLJzVOn2irlSCohrhFHdha6R1+DffsWQetTPIIiDx1Mc72FKipqw+dj4Eeeu8G+G/F5XbNYr8ugkOrAQcxerg5FVHMkxUi+rXnRzuxZohmbtu8ijoiEeXeaUaA6oK4ih246X09O141iPPFNtiqw+DkyrtdwggplyWlnnhXUL7IVm1coxogMXezUOYety4rQ8vQSUAaJo+1pz5QVNGqZO+ZCqPIDcQVTytVmlsv5s+0AGtLWemSQ8eJqBZciBNKxru29yNlPLKB4uIfhVUtGyputkw3I4DvI3W7ECYeLxEiUD6S3e+yUqlewIY4UgQJk6GFgWzSqll/YgHH/DyuQIhTGf5CAiFMsHe+bN9Yx1TSpR2x/mJI4VUhC1IeAMo4rLMRiGfQ7l+3fqMHI71A/eKwOvGwd7vQvrp3OnFhQY7EBeC6MvnYlqZNX12s5NzcAcLLPdomqLzd8cigdadfPUL0RXx4BYC9arTPuFQiWYw5Bb/Q4aXQDwhvOTJvElvOkxUwNOV2l+N9vJ1fqkqUKxCUE8QNHOoiJrY+Dhm7pp07gLuLW3mcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(451199018)(31686004)(36756003)(4326008)(66476007)(8676002)(2906002)(8936002)(66946007)(66556008)(44832011)(5660300002)(38100700002)(86362001)(31696002)(6506007)(6666004)(478600001)(6486002)(966005)(316002)(41300700001)(83380400001)(26005)(186003)(2616005)(53546011)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVlvWjA3TExpSjJUTUh4MUUrMzl0K2lVR043eWJScXRaSFFyZFkvb253djJS?= =?utf-8?B?cXV2Y2pLQ3dYT2szQlpFRllFMURTZG90VXhVZjJBbW1VbUI5cGxKZjFvbHdI?= =?utf-8?B?N3lCWHFnOFQ2Q25QOVRJOHVCVDltbnpQdHpuenhPL3Y2SERWaWc0WGdGNGFm?= =?utf-8?B?ZEZrbjR5QWltR1Boa3B3MzZIYlNqMTR0NWx5N2U2TUNqMnR4M0pLVUxxaVdO?= =?utf-8?B?dnp1ckx5dDFWc0VMOXMyTTRwVjdQdzRGS3VhTDdQVVFnM1R3bkVLbUNVNUhR?= =?utf-8?B?dUcyaThhMVdhK3VYYWZBcEZuQjRrcWxwNlQwaDh6bHZIZmZxOFg1R0hBR2dm?= =?utf-8?B?WDRqa0h6elpDb0szOUkyNEFNZVI4WW1YTjhPZ0xtYXFxa0I2UmI2b2pDOHNr?= =?utf-8?B?MllpdTFjYlZ4SmV4eER6VDN3NTNRZ09EbTRxNHIyVkxabzBTNmdEMVNFN1RO?= =?utf-8?B?SWI5WGFod2JCcGcwanhsVW9PU2padG1ienBZMDVqaE1JeFJ1cDRaVTc1VGw2?= =?utf-8?B?RCttdUIxbEw3Y0txdldsZlpJamRHR09pQlZtZ0hmSC9YWm9hcTNuY3ZnR3ZW?= =?utf-8?B?VWxaWlJBd0dYYUZQNmw5QmJWQW1rcnR6OW9ia0RKVUM5b3VnNWZocFBYRm1E?= =?utf-8?B?SnhHNmtFVUoxd2ZOdnFCOUxldUJWYmZJd2J4RTNQK2hwbTdvY01ibWk0OTU1?= =?utf-8?B?alFUMlc4NUFoMGdtd2xlckF5UmxIbEN5Y2o4ZyszamxlZWw5M0RKL0ZVWW9H?= =?utf-8?B?ZmlwMHlRMy9sNmdNeEZoUGgzdm5NZ1RDZ2dSWHNRT2NTNWExYmxLa1E3eFhl?= =?utf-8?B?emVqY3J6TUZ3em5TcmxxTEpaNmI0bHBtQzZiYXcyczRodzU0Qjl1Mmw1cC9i?= =?utf-8?B?bER0VDZhUGRvZTJNUDhJNEt2MTc1dEN0aFhmREhtTVhPd2srMDN5ZGFXakhr?= =?utf-8?B?czlLYkZrZUplT0d6K2hlZVZjWTVVV1JtaWt4RVVZUHR5NHlHemFRVWRPRUha?= =?utf-8?B?ZXcveDdZZGtLSUFGZUh6SExoWkdxSlFBNzk0WE9kYnpBdXBwSDBXN3dEWnpS?= =?utf-8?B?NzZqQjc0OERtWmJic3plYjdTMHhiQm05SkE0U3hIZkpKYk13bEdXenBzRmNu?= =?utf-8?B?WEV1ajQ4MGlXWmJPUytMR20zdTF4OVhsWDJJY3M3akdkUkF6TEowcVVTdmR6?= =?utf-8?B?S24vd2hjN1dyZFNIcHBnVy8vYlZKM0JiU2hySnYvQTBFQXljajJDNnVwVG9Q?= =?utf-8?B?QWZOSjJYbWJHTEZLTTMxQytYZkJLZ1ZXbmdFb09IYXQvQjd4dWxacmg0N1g2?= =?utf-8?B?bHp3RE42OEdubU4vNSt4WmRmdVg3blJvNUdRNWhhUFhvMDZ2dHVyQkRPZG9Q?= =?utf-8?B?SUU0OWxPOW5ybjl6NU5YL1RBdy9HUHZTRWRDZnNMTkQ1cGdqRTJ4blZVMHN5?= =?utf-8?B?NkJmdTlBOWw4VkVoUXFVMFRCcXAvY0xkQmp1OHh2ZmJ3K2ltTVhSZWlDR0lp?= =?utf-8?B?bkx5dUUvcFI4bXQ3ODBOUXE4UE1LM2p6UWZsbnVab243YlAwRTlmWjRHYXRU?= =?utf-8?B?ZXFocUsrV0NDcUdlb2FVZ2owdlkvY3U5anJFSldPMHBHTHh6OWJ6S2VvcFUv?= =?utf-8?B?d0JYVTVvNGYrZWVkQmV0MWJCbVZlRjZ5MFljZXhkMlB4TUVvOGh6WEJuN0t5?= =?utf-8?B?T3NiOVA0cEl4Q29QZEI2ejFiaDU4RFhtaU9FcVlOVGFWL2RScCtnNnhvd2U1?= =?utf-8?B?bXVqYzY2QVIxSFJ2N3pSc05NYVRvbkJmSXBCMCtSUE1ENjFNY1BXWE5xaklh?= =?utf-8?B?SWxHT1RycnNBWmdFT0NRaHBqcXRIbWJDY0lWSEI4bUJaWjBEdUpsWmRIaXhF?= =?utf-8?B?b0dKSUU0WU9rWG42WWoxcUE0Mi8xcUJaUS9ZeHVoZkhUZk1MRlhZdWFDRVdP?= =?utf-8?B?eVdEbmdhaWtHemlZNVRkRWVRQWEzNWw0U1R0Y1J1andicWdNaGdWRGVTT1BF?= =?utf-8?B?d3RKZ3ZXZStUdXh3SDZMTHIvK0ptNTlXM04zRnRvZTJCNkc2TzlhdG5Na1B4?= =?utf-8?B?MXVQM2YycldWSjkyNHI3MTc3OTNZbXArNXdPRUg1R1pxNnAzaTFtbkhHTkxY?= =?utf-8?Q?OoR+lapIxAZI8fNgKiD/brJO6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd92309c-9737-4efe-e3f2-08db10e48836 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 12:43:12.9130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tWklwYrHPURwy5Y+FiwqDZseVMcQoNTUiT/S04EKppYjEaUaKA6VHHVyaTnwgMkH X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4560 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 6:10 PM, Levend Sayar wrote: > Google Virtual NIC is not doing IPv4 checksummimg. > Removed that capability from PMD. > > Signed-off-by: Levend Sayar > --- > drivers/net/gve/gve_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index 97781f0ed3..e357f16e16 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > dev_info->rx_offload_capa = 0; > dev_info->tx_offload_capa = > RTE_ETH_TX_OFFLOAD_MULTI_SEGS | > - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | > RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM | > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | Hi Levend, there are multiple version of same patch, it is confusing for reviewers and maintainers. Can you please: - User versions tag, and keep increasing it. Like this one has v2, which is good, but next one sent after this doesn't have any version tag. - Use git send-email '--in-reply-to' parameter to keep all versions in same email thread. More details on documentation: https://doc.dpdk.org/guides/contributing/patches.html#sending-patches - Clean patchwork after a new version sent by marking old version appropriately (most of times as 'superseded') https://patches.dpdk.org/project/dpdk/list/?submitter=1813 Thanks, ferruh