From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AB0EA2EFC for ; Thu, 19 Sep 2019 14:35:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C133D1EFC3; Thu, 19 Sep 2019 14:35:54 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 360C01EFC2 for ; Thu, 19 Sep 2019 14:35:54 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id y23so3395799lje.9 for ; Thu, 19 Sep 2019 05:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hD6/Jw7dVlApC+BrWiL93fIIWOP0koWYj+M889vwuAI=; b=u5Dx5abeTUzwsrPQw6nXtRRLkfFBUfJCttkrGJ9H2U7qMecHqf/xP+/pyExFzz4FJV Uj9Nd7WWrUGRWxgmJ/gFPy/vJBhAJb3wT22O2Eln4osHJ7m/bcpLVlrfSJRKvH32UBMU zVPWk+7PfQUCO5BCGq1HcipcqoEMEm8L4Hs1tcARelx2G8Jxb3MNbbKHD34ODjBoe8Vc TEILjQK1OoJtwgRzZD/62jAxqSuIosiEd9L0Ic+ZWL5GYcoND92dysBLr/H+bNlBAW7Z kyHqHntNA1iEm3Lnxb2x15PkyLGAh5FnaJl/i6ZWkWVAeHT6gxAIVpfV7Ptwe9gwUnRN yVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hD6/Jw7dVlApC+BrWiL93fIIWOP0koWYj+M889vwuAI=; b=Jf/Z9CrqhMWI68DZDhpcUYMKrNDpMDux5osdtOcbFoqZpHVcmin11E29DBnr76VeH+ fQDYK1w+Kx4pObA9Ijnz5lBU3FIDFMyspg4mAy3qVklADWq6BwI1t8Gc6a3/DVFzTpFx OeuUw83NlfSLfrXxVRLmk8e+ypS8XfLioTfAQAoD8l5g48NG1+DIgNzLU8XnoXYzfZwV 17avRb6F0l//+pV3xncg48Cqq2rMxndTwPLBlScPNY4Dd7sTnRie/DHre71I9XQlX8rB /wfUybNGr1rxOi1k7XjW8nhHXp7mQL4QH2ja9NOqXL4IfA2JAO75ZoMIckrtWsU/QgoJ n/rA== X-Gm-Message-State: APjAAAUW0S5dTEh0F+5Q5G7w/NSgDTFHI4vqCAyrX34g9EqVdT/J2xOo CfN4wFOd7xg+c5+f0CRJn7GmCg== X-Google-Smtp-Source: APXvYqwE/e1jx19RVO7CVIMMoSTerqu9V+OLXOyHY5IdMSmw/amPPHKHF+JwN4K56EbsAYu5pqHD+g== X-Received: by 2002:a2e:9094:: with SMTP id l20mr1523992ljg.35.1568896553711; Thu, 19 Sep 2019 05:35:53 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id u10sm1537425lfk.34.2019.09.19.05.35.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 05:35:53 -0700 (PDT) To: Ray Kinsella , dev@dpdk.org, Aaron Conole , Michael Santana , Thomas Monjalon , John McNamara , Marko Kovacevic , David Hunt , Bruce Richardson , Vladimir Medvedkin , Robert Sanford , Erik Gabriel Carrillo Cc: mattias.ronnblom@ericsson.com, stephen@networkplumber.org, Andrzej Ostruszka References: <20190917075754.8310-1-amo@semihalf.com> <20190917075754.8310-2-amo@semihalf.com> <8ba7ce2f-e687-3e1c-c7ab-7749764e80d8@ashroe.eu> From: Andrzej Ostruszka Message-ID: Date: Thu, 19 Sep 2019 14:35:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <8ba7ce2f-e687-3e1c-c7ab-7749764e80d8@ashroe.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/18/19 3:32 PM, Ray Kinsella wrote: > this is cool, good work. > comments below. [...]>> +CONFIG_RTE_ENABLE_LTO=n >> + >> # >> # Compile to share library >> # > > Why would we make this optional in this way and expand the matrix of > different ways to build DPDK. To ask another way, why wouldn't a user > turn on GSO. Compilation time is much longer. In a normal hack|fix/compile/repeat cycle with "compile" part being simple "make" the link time might be a bit annoying. So I imagine keeping LTO off for the most part of the dev cycle and then at the end when doing release/cleanup turn LTO on - to either get release build ready or to get some set of warnings that you address before yet another attempt to release build. By the way - this make config option is equivalent to meson 'b_lto' option, which by default is off, so we have similar behaviour in both build types. Regards Andrzej PS. I assumed that you've meant "LTO" not "GSO" - if not, then please explain what you've meant.