From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 15E6368CA
 for <dev@dpdk.org>; Wed, 28 Sep 2016 14:16:00 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga104.jf.intel.com with ESMTP; 28 Sep 2016 05:16:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,410,1470726000"; d="scan'208";a="1046941421"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.132])
 ([10.237.220.132])
 by fmsmga001.fm.intel.com with ESMTP; 28 Sep 2016 05:15:59 -0700
To: Neil Horman <nhorman@tuxdriver.com>
References: <20160928100519.14885-1-ferruh.yigit@intel.com>
 <20160928113519.GA28138@hmsreliant.think-freely.org>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <dfffc631-7682-a9f2-9be6-da7e6f2afa1d@intel.com>
Date: Wed, 28 Sep 2016 13:15:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20160928113519.GA28138@hmsreliant.think-freely.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Sep 2016 12:16:01 -0000

On 9/28/2016 12:35 PM, Neil Horman wrote:
> On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote:
>> Compile error:
>>   CC mlx5.o.pmd.o
>> mlx5.o.pmd.c:1:227:
>> error: no newline at end of file [-Werror,-Wnewline-eof]
>>   ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
>>                                                       ^
>>
>> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
>> config options enabled.
>>
>> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  buildtools/pmdinfogen/pmdinfogen.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
>> index e1bf2e4..59ab956 100644
>> --- a/buildtools/pmdinfogen/pmdinfogen.c
>> +++ b/buildtools/pmdinfogen/pmdinfogen.c
>> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
>>  			else
>>  				fprintf(ofd, " ");
>>  		}
>> -		fprintf(ofd, "]}\";");
>> +		fprintf(ofd, "]}\";\n");
>>  		drv = drv->next;
>>  	}
>>  
>> -- 
>> 2.7.4
>>
>>
> 
> What was the error this produced?  It seems like a false positive to me to
> require a newline at the end of a string, and it certainly doesn't provide any
> benefit when pmdinfo reads it back later.

clang is complaining about missing newline while compiling autogenerated
file, build error is on commit log.