From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C60B045958; Tue, 10 Sep 2024 19:25:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 936B9402AB; Tue, 10 Sep 2024 19:25:41 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69]) by mails.dpdk.org (Postfix) with ESMTP id 883334027D for ; Tue, 10 Sep 2024 19:25:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cCRiHm29gE34Y1W7ZzlHfJghdF2ipjLYu/NWtOaopmEfxpoVuW/Din4DzuAbZXxRRTRSf9BrIrQA3fEzomMULIdLjgxncuBvQxDjVNH11gcF9IU7aoWySMGaA5U5vWZSnuLI0eBQI3spyugOzFfa82MlKvjX8goNY4ez8uFMbriCrf6qVJItAhpsW0Qa/RGRErms24eteo113XagHOpLXqblP6L4ZVrJ/YUgKb1XHFyCoQKXXbyCYbiyLrMQOH22obaK3PWQ6QfJRcQsBJbfl9hQeQ9XqWWyLkH0ahv3SNkHmL1efLZU3wxDvhkV0qE97uCaA9xrG9gElR1+o+XaDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0WoC5uP9CUInBSks4DsLj+cc2wJBPFlZDKmbaWdpG90=; b=SUJgzEpYHNQ6SFNYTtDjwXtA5Pl7IB86PjyRTidMoJpNx78hQkVAT0WrS9wBlPyGkBD+fnFSTP0k8OvHApb77Yol+cJtXLpejhid2FGRGKPQeoUHDLi/3RJqLqTHZolIV4jgOWSYOifxSSMAi6gP+wNmlp5+cef8z34d39GXft0MU6BgEt97PfI3NicLoBytpcbPjMCoVaxDAolw8GZy1iZZO4DToENPuDJaOlsQrIZfIbD4+7cLGZQFTG8Cb7VBaEY9k5/qqqQ32TUiJRpOUK+RGf5Mlb67d3RCk+meNInS9+rNk61RS9ifuI1falhKMjoymRupJv71a4VUJGevow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0WoC5uP9CUInBSks4DsLj+cc2wJBPFlZDKmbaWdpG90=; b=ldzNcc3iqoVAYcj3D7fcaYAfYQx2cMloVLHBVplEr2EksVR1hE1370fTBkJSXC2EcUlRH9VGQxcpLYUOrc/+b4Guot9WLLNtEVw72eTnppa/TEaAdcB3ZK/6D3+D9DjPAzBVEvjEsFsopSW4y7ZL1Nvl+zZSYeOSIRa/lOpY118= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6994.namprd12.prod.outlook.com (2603:10b6:806:24d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.24; Tue, 10 Sep 2024 17:25:36 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7939.017; Tue, 10 Sep 2024 17:25:32 +0000 Message-ID: Date: Tue, 10 Sep 2024 18:25:27 +0100 User-Agent: Mozilla Thunderbird Subject: Re: Crash in tap pmd when using more than 8 rx queues To: Stephen Hemminger Cc: Edwin Brossette , dev@dpdk.org, Olivier Matz , Didier Pallard , Laurent Hardy , kparameshwar@vmware.com, ferruh.yigit@intel.com References: <20240910095802.22f3ab60@hermes.local> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240910095802.22f3ab60@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::35) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6994:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c6a8dc0-6e33-47a5-fade-08dcd1bd92d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZER2YlBENkFyWEJOVEpiNFlhYTBtTit5TU42MDNQMURGKzNSTjU4eGtCSVNq?= =?utf-8?B?SjNxajBVZmFSbENrWG8xMmZkZUhESFlMV3VGRmN3NlpFNisvOTlEYjlwL01u?= =?utf-8?B?ajAzblhsWkVDZnBheHF3Q2ExKzNlOVY1anR2eUlqNUxzS3h3MDVpSU0vbXdt?= =?utf-8?B?aHVPMkllTTJ3N0R3VkltTHpzTEFUM1huZHZraFlnTUxaa3BuS3o5SWtGeG1L?= =?utf-8?B?ZjNXcUNpTGZYYTliQnNHN1hQbnFMLzdqN1hpNW5vWGlLMnRnaXJZTitvVVFa?= =?utf-8?B?eVJzbkhkSWdvakNFSWo4a2hLeU94UndML3JUMVJDVEpPS2Y3cWdsYWhWaklL?= =?utf-8?B?RVNLQjlMY0pLUHBRVmpRRjdkOGpJSTA0TThubitueExqZ0d4dG5VSXpFcWNq?= =?utf-8?B?ellhNm9Od2dLeExjanVEU1Nmb1dNdTdrODBlUzdhdm1Oa2tWWjVOWGU4UGlP?= =?utf-8?B?Q3MzRG1ibnBQbm9VUHRTdi8vOHdVUDh5d2N3S3FPMnFnQVUyNWk1aDU3NTln?= =?utf-8?B?MDJ5UWdjWi95YU5xTjhwK2dKRVdCQXdFZmNrNUJYSFViNWUycWkrWmVFaTQx?= =?utf-8?B?eGlxZ1czWFhndlNZVHZwR2VuYmdtM0tPQXBwd3Uycnk1U09jZTN6NWk0LzlJ?= =?utf-8?B?eGZVTDhzNHZvc2dVajBmWTBkUUZ4aFhqMmNXdWs0SG1VZnlGZmJvanIvYmUw?= =?utf-8?B?aURoSjVPaXI5RWQydGgxRVliVHFCYzBFWVp1NlRIUHBWWkJCLzA3Z0RHTFpL?= =?utf-8?B?VlVsWEFmaGpvVVlwcWFMdkVqTlZNbDVqTzZIQW1HdnJpYks0L20rSDNKb09T?= =?utf-8?B?dE1WWTFNZDR4WTF6djBEeWRvb24zbG1GRnFQNWlLSDJJcjAxcytBSVhKZjU0?= =?utf-8?B?ZlNyNVpkN2g3TkI3cm5CVEhYZzF3Y0NCUVRWTjFNUlc1L3FFSW9KMDU5Nm13?= =?utf-8?B?S3dkdW9Mekh6OUVPdENQUjFFbCtsaUYzY05VODFMV2RSUzFhUEl0VStEbnZV?= =?utf-8?B?U0lLUmozbkJudkhtR1AxKzBrU0ltMDZGejJPeDRqUmR3QmE2WU5zOHRya293?= =?utf-8?B?NlRDV0c4OWdFY25nR0hIYnYvYUxObnJHL1V2WXZySlVsczdLZDA2akxNbmF5?= =?utf-8?B?K1doSEMwcWtzcmZ4SUsxTW9sRktXUXZPMHJJMnBzdFVhbWRIaStLdXBwejJa?= =?utf-8?B?RmdpMk5Wd1FVWDFuZVRyMmlBSityY21saTZyUDNXMGxEOXRRWHMwQllUMEM1?= =?utf-8?B?UmFncW9qTlQvS3NrdEpNZWIvQ0VCSEhCRUovUFFhbXpvTWduNC9GcmR6dGI4?= =?utf-8?B?MFluK2d5ZFpDRFZXa2d5STJjekFTWW10OGtXeWpwWndObVJYbk1lalkyMlF1?= =?utf-8?B?QlF0akxwQzN0dkV2YjlBYjNDVlgvbVJpalNzMEp5Z0NUbkhVM0JQNlVXV1hK?= =?utf-8?B?c0g2QlJxcFd1QndvbFZYNUJ2ZTJmWjZqSnRaTU5vWFVhaTVuUVEydTUrQXNT?= =?utf-8?B?NWFBVG9FeXlqUlRoWTdyWVlnUFJYbG8vQW9sWGlZZDUwTWQ1RGlaZWpsWFV3?= =?utf-8?B?SGVIaFlEOFRNeXVWOUxlYmF0bk5RbEZRSmF0YXNnSHFtbkMxdThpYzZzSUNU?= =?utf-8?B?NWtBQnM3eHRQM29JalpPamJvcUVCTWZSTnp0UnJrekZWQThOc2ZGdWYvbGtn?= =?utf-8?B?WXBLNjJjMzdWZzBDSytGZmg5ZVRaNzVwakdPTHcxMlBRcWxUSGR4OStJQmtR?= =?utf-8?Q?JjvtYBFvWpSSBQ+qLw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHdOV3ZYWVVTbHRIQmRxQ0p5VjBGblNOS28xOW8vV1dzaklOVmRWaE1HYjVO?= =?utf-8?B?RjlPTzhOL1cwZUUyams4eFVWSUZxR0lTU0xDOVVudWRMcUN6ZXdENHdZQk5K?= =?utf-8?B?WnNnQ3RHZE5yWWI2Q0lkN3huNTQ5QU4rRUJaM3puY2xxRWVENGpYSGlreVJX?= =?utf-8?B?MURWOUVhNDBJVFNPeHdwVFhFZ1k5c2N1VElxUU1ObU1lREl3NFoxSWNDVUZ5?= =?utf-8?B?SVlZRHpwejgwK0RQZG5uNi9KdVVTVXhvQU1JRGgyRWROaDJVVzVQcVBnTHln?= =?utf-8?B?ZlNTSytaWlBXQklhN3gra3VISFVnK1VjMzNKNEZJdDFGNStKRURBcGxYT3pT?= =?utf-8?B?VCtIeTRXK3hQQ3ZNWkMyVGJ4dU43ek8velVuR2hJRGpOSnlRYkpyZDEyS083?= =?utf-8?B?dVlzeFR0WlRESGg2Q1hpT1BRcXFwMi82REVVNUxyMHJGU0NUOCtsUGZJbExi?= =?utf-8?B?cUFma3BKeHBDeGRlRWNqTXhmTEd3UGJzd2IyQ3hIbkNsYU11WDcwWWFRMUs4?= =?utf-8?B?RXpNYnV4TDhJWGFTVVZPQW9IdVkzb2lDN2F0MmRJTVlmRkhTRzRrZnR2RC9L?= =?utf-8?B?dzBRaE1QTHIwQU1Ja0NQb2wvcWo3c3RqbzBxSysvQnl2MUhSL3YxTEgvcjVY?= =?utf-8?B?U3BiMktlZnkyaVVrSmhGbTVBVjhyRFNlQVFjZ2RrRTFuOG9GVjlWUWU5bnll?= =?utf-8?B?Zkg4eDA5UE5adFIxMXk5V2FBcDY1dkJVeEt3dTFsa21LY2FXM1liTUdNOTly?= =?utf-8?B?Wnpkb3B1UUt1RjZITUZhRExrd2pzRXhvck9tMzROOC94cTBGbXFJUGRhQnRZ?= =?utf-8?B?MlhEZmVlbUJ2U09ZVU9jS2VQbENCV2REQ2loVTdlZ3p6YUNtQmVLMnljMU40?= =?utf-8?B?QlU1blBYaDRZSk0wZGhBdm9YMVNZbktSR21oVURNL0crZUk5Wk4vQ1JIZnBK?= =?utf-8?B?cTRBWUhkbnRCQktiM0hGaHdxSjRXeW1MRURIV28vdk1IbzdNMGlRVVRrSEVu?= =?utf-8?B?WCsxU09RS2trQXY5aWY4NkdwOE1udFV0L2NJaS9uUlVRRGNrbHBMd2VPaW0r?= =?utf-8?B?OXVMby9PSWZXelY2NHViVHFlRyt2T0xHVmppbkVZUDZPZGZJNVhENEVDTDBW?= =?utf-8?B?UlE4VTYvU2w4Y3FDdnpvZGNTWFE0V2NQTmVnZTVlVzBUeWkrVENjbkY5WGRK?= =?utf-8?B?N25nc1EzdDNlOTBtcmtxb1YyTnZJOTB6VGN4djJXSThQcyt5aTZUaWFwMGZR?= =?utf-8?B?MFJYUkhQMnFJdWZmVHNzeUMvcytybjFuNWdjUzJhQXd4S1BpdWZRQnhpK01Y?= =?utf-8?B?MURWeFBkNGlwL2dKV3hka3d2ZVJGUDNGU2pYQmNJc1Iyay9aWTlsOGw3ZVBw?= =?utf-8?B?THAxbkZHYnlBRGVUMGNtdFdJb3dzS2hKNFlnWHFlSk1PRVpyRGw5czVhMUJ1?= =?utf-8?B?b0pmTkZXM2lIalN0cklLZS9OQ0VQSjhScU9PZ1B4UXk0d3dRL1RudDZGOHl0?= =?utf-8?B?MytTWlVZdUh1Rm5xWFgzNWR6dE1JS25GUlFCZmN6T2NJWDU3azU1MkllVmlR?= =?utf-8?B?M05VWGlFQVhnekwxZ1BmNjhzMHliMnRvOHZQV2FXbnRkUUZheEY3RE5lK0Fv?= =?utf-8?B?VGN0QzZIM1RhUzBjVkN2OEtiZ1Z4MzQvZzFOems1bFRaVDlybGZuTTBWT1VR?= =?utf-8?B?dXZzQTRzUWVVajg1cDNqN0xCT09QcldKMlBOTThqYnl0RnJ5N25IbUxHT3Nj?= =?utf-8?B?SVRod1h6YjAvL0d1eEJNdGNKZEpneU9YVEYvL3JXN0hlVDdwNnBERWVoaDlH?= =?utf-8?B?eUVQL29xQ0JCM2s0cjl4UjJIdkZLL0VNanNLSW54cFM1ckQwSTdieUYvOS9J?= =?utf-8?B?czBCM3JMWjExeGRudENURzMxTTJsNEFHT3o1bVk4OGowUnl3OVVxc3VuazFP?= =?utf-8?B?SWhQVWNDTVh2VnFzcGc1TGZhbzdtcVlJM3lrVnlzcVB4SlJYKytTa3h5SWpM?= =?utf-8?B?SERrbk5BQWNaNG5ON3R2UEI4bVhscitld3ZvN2h3b1VEZk9obHBXOEh6TWZO?= =?utf-8?B?TnRwcThQVzgrcTFVY3JBTXZvdlBtTnRRdlU5M1lYVFQrS0phc21Ic0xaUVJF?= =?utf-8?Q?+CEBWlNvs2o+mqDZ9/Db7F7GU?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c6a8dc0-6e33-47a5-fade-08dcd1bd92d2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2024 17:25:32.6321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1de/s6EFdiRYW7fpgrnCHeexmB4c6WISPwh1zZzVpW5mv0xs8l2WHiJW4FIimGPA X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6994 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/10/2024 5:58 PM, Stephen Hemminger wrote: > On Fri, 6 Sep 2024 12:16:47 +0100 > Ferruh Yigit wrote: > >> On 9/5/2024 1:55 PM, Edwin Brossette wrote: >>> Hello, >>> >>> I have recently stumbled into an issue with my DPDK-based application >>> running the failsafe pmd. This pmd uses a tap device, with which my >>> application fails to start if more than 8 rx queues are used. This issue >>> appears to be related to this patch: >>> https://git.dpdk.org/dpdk/commit/? >>> id=c36ce7099c2187926cd62cff7ebd479823554929 >> commit/?id=c36ce7099c2187926cd62cff7ebd479823554929> >>> >>> I have seen in the documentation that there was a limitation to 8 max >>> queues shared when using a tap device shared between multiple processes. >>> However, my application uses a single primary process, with no secondary >>> process, but it appears that I am still running into this limitation. >>> >>> Now if we look at this small chunk of code: >>> >>> memset(&msg, 0, sizeof(msg)); >>> strlcpy(msg.name , TAP_MP_REQ_START_RXTX, >>> sizeof(msg.name )); >>> strlcpy(request_param->port_name, dev->data->name, sizeof(request_param- >>>> port_name)); >>> msg.len_param = sizeof(*request_param); >>> for (i = 0; i < dev->data->nb_tx_queues; i++) { >>>     msg.fds[fd_iterator++] = process_private->txq_fds[i]; >>>     msg.num_fds++; >>>     request_param->txq_count++; >>> } >>> for (i = 0; i < dev->data->nb_rx_queues; i++) { >>>     msg.fds[fd_iterator++] = process_private->rxq_fds[i]; >>>     msg.num_fds++; >>>     request_param->rxq_count++; >>> } >>> (Note that I am not using the latest DPDK version, but stable v23.11.1. >>> But I believe the issue is still present on latest.) >>> >>> There are no checks on the maximum value i can take in the for loops. >>> Since the size of msg.fds is limited by the maximum of 8 queues shared >>> between process because of the IPC API, there is a potential buffer >>> overflow which can happen here. >>> >>> See the struct declaration: >>> struct rte_mp_msg { >>>      char name[RTE_MP_MAX_NAME_LEN]; >>>      int len_param; >>>      int num_fds; >>>      uint8_t param[RTE_MP_MAX_PARAM_LEN]; >>>      int fds[RTE_MP_MAX_FD_NUM]; >>> }; >>> >>> This means that if the number of queues used is more than 8, the program >>> will crash. This is what happens on my end as I get the following log: >>> *** stack smashing detected ***: terminated >>> >>> Reverting the commit mentionned above fixes my issue. Also setting a >>> check like this works for me: >>> >>> if (dev->data->nb_tx_queues + dev->data->nb_rx_queues > RTE_MP_MAX_FD_NUM) >>>      return -1; >>> >>> I've made the changes on my local branch to fix my issue. This mail is >>> just to bring attention on this problem. >>> Thank you in advance for considering it. >>> >> >> Hi Edwin, >> >> Thanks for the report, I confirm issue is valid, although that code >> changed a little (to increase 8 limit) [3]. >> >> And in this release Stephen put another patch [1] to increase the limit >> even more, but irrelevant from the limit, tap code needs to be fixed. >> >> To fix: >> 1. We need to add "nb_rx_queues > RTE_MP_MAX_FD_NUM" check you >> mentioned, to not blindly update the 'msg.fds[]' >> 2. We should prevent this to be a limit for tap PMD when there is only >> primary process, this seems was oversight in our end. >> > > It is not clear what the error handling should be if the user requests > 10 queues but RTE_MP_MAX_FD_NUM is 8. Ideally, it should work if no secondary > process is used. But there is no good way to know that in the driver. > > That is why it is best to just set TAP max queues to be less than > or equal to RTE_MP_MAX_FD_NUM, and enforce that with a static assertion > at compile time. > We can limit queue number to RTE_MP_MAX_FD_NUM when there is secondary process, but when there is only primary process this restriction is artificial, and I think we should try to remove it. One solution can be to provide a devarg if tap pmd will be used only in primary process, and in this case it skips all code required for secondary process support, this removes the queue number limit. Also this can be backward compatible, without devarg default behavior can be secondary support and queue number is limited, with devarg limit removed etc.. By spending some time on it probably we can come with even better solution. Like improving MP socket communication to remove this restriction completely independent from RTE_MP_MAX_FD_NUM size...